René's URL Explorer Experiment


Title: Fix image vlim clipping again by tacaswell · Pull Request #17636 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix image vlim clipping again by tacaswell · Pull Request #17636 · matplotlib/matplotlib

X Title: Fix image vlim clipping again by tacaswell · Pull Request #17636 · matplotlib/matplotlib

Description: PR Summary We use the Agg resampling routines to resample the user supplied data to the number of pixels we need in the final rendering. The Agg routines require that the input be in the range [0, 1] and it aggressively clips input and output to that range. Thus, we rescale the user data to [0, 1], pass it to the resampling routine and then rescale the result back to the original range. The resampled (shape wise) data is than passed to the user supplied norm to normalize the data to [0, 1] (again), and then onto the color map to get to RBGA. Due to float precision, the first re-scaling does not round-trip exactly in all casses. The error is extremely small (8-16 orders of magnitude smaller than the data) but for values that are exactly equal to the user supplied vmin or vmax this can be enough to push the data out of the "valid" gamut and be marked as "over" or "under". The colormaps default to using the top/bottom color for the over/under color so this is not visible, however if the user sets the over/under colors of the cmap this issue will be visible. closes #16910 PR Checklist Has Pytest style unit tests Code is Flake 8 compliant

Open Graph Description: PR Summary We use the Agg resampling routines to resample the user supplied data to the number of pixels we need in the final rendering. The Agg routines require that the input be in the range [0,...

X Description: PR Summary We use the Agg resampling routines to resample the user supplied data to the number of pixels we need in the final rendering. The Agg routines require that the input be in the range [0,...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/17636

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:35fad8bb-7b5f-f160-f2eb-ab711008effb
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCA0E:366107:1191D:16528:6A52D9AC
html-safe-nonce50d0c2493b3e0cc2032023ac292c5f35cdcbd153eea3aa7e436b0da6062408d8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQTBFOjM2NjEwNzoxMTkxRDoxNjUyODo2QTUyRDlBQyIsInZpc2l0b3JfaWQiOiI4MTgzNzI2Nzc4ODg1NTI3OTgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac96e25f53f848d5e0a7ec46d8928f5bfb888d0d0d57d5e4ed0160f6d1329dc1fd
hovercard-subject-tagpull_request:434713140
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/17636/files
twitter:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
og:image:altPR Summary We use the Agg resampling routines to resample the user supplied data to the number of pixels we need in the final rendering. The Agg routines require that the input be in the range [0,...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/17636/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17636%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17636%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/17636/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/17636/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/17636/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17636/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17636/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
jklymakhttps://github.com/jklymak
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tacaswell:fix_image_vlim_clipping_againhttps://github.com/tacaswell/matplotlib/tree/fix_image_vlim_clipping_again
Conversation 1 https://github.com/matplotlib/matplotlib/pull/17636
Commits 2 https://github.com/matplotlib/matplotlib/pull/17636/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/17636/checks
Files changed https://github.com/matplotlib/matplotlib/pull/17636/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17636/files
Fix image vlim clipping again https://github.com/matplotlib/matplotlib/pull/17636/files#top
Show all changes 2 commits https://github.com/matplotlib/matplotlib/pull/17636/files
3dea5c7 MNT: also transform vmin/vmax when rendering imshow tacaswell Jun 15, 2020 https://github.com/matplotlib/matplotlib/pull/17636/commits/3dea5c7000b5db91ff1aedd19c733fdbeb86fc2a
ca53448 TST: adjust test images for previous commit tacaswell Jun 15, 2020 https://github.com/matplotlib/matplotlib/pull/17636/commits/ca534486cf7f1432d4d3dc6db38e61ae44b7f600
Clear filters https://github.com/matplotlib/matplotlib/pull/17636/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17636/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17636/files
image.py https://github.com/matplotlib/matplotlib/pull/17636/files#diff-25ae7458ece3baeb36f57b6d14661c66781454a7a0532e5847eb4ed425ec0f5f
imshow_masked_interpolation.pdf https://github.com/matplotlib/matplotlib/pull/17636/files#diff-a8f2110d67b4b20db63b55b577ab5468520a0b3eb7856c951592529e402fb15a
imshow_masked_interpolation.png https://github.com/matplotlib/matplotlib/pull/17636/files#diff-63558c7a21dd861c55d2da4801f3fd111ee60ea490ac52f1cdd16328fe800c2f
imshow_masked_interpolation.svg https://github.com/matplotlib/matplotlib/pull/17636/files#diff-57f42393947af8e049b846ac7b51c4adbeb2aad7d9d9477653f616e5b5c86d65
test_image.py https://github.com/matplotlib/matplotlib/pull/17636/files#diff-8a96f32702b9c91b992e6cc9cb438eaaa26993101dbf40ea31ccbc097b47f68a
lib/matplotlib/image.pyhttps://github.com/matplotlib/matplotlib/pull/17636/files#diff-25ae7458ece3baeb36f57b6d14661c66781454a7a0532e5847eb4ed425ec0f5f
View file https://github.com/tacaswell/matplotlib/blob/ca534486cf7f1432d4d3dc6db38e61ae44b7f600/lib/matplotlib/image.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/17636/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/17636/files#diff-25ae7458ece3baeb36f57b6d14661c66781454a7a0532e5847eb4ed425ec0f5f
https://github.com/matplotlib/matplotlib/pull/17636/files#diff-25ae7458ece3baeb36f57b6d14661c66781454a7a0532e5847eb4ed425ec0f5f
https://github.com/matplotlib/matplotlib/pull/17636/files#diff-25ae7458ece3baeb36f57b6d14661c66781454a7a0532e5847eb4ed425ec0f5f
https://github.com/matplotlib/matplotlib/pull/17636/files#diff-25ae7458ece3baeb36f57b6d14661c66781454a7a0532e5847eb4ed425ec0f5f
lib/matplotlib/tests/baseline_images/test_image/imshow_masked_interpolation.pdfhttps://github.com/matplotlib/matplotlib/pull/17636/files#diff-a8f2110d67b4b20db63b55b577ab5468520a0b3eb7856c951592529e402fb15a
View file https://github.com/tacaswell/matplotlib/blob/ca534486cf7f1432d4d3dc6db38e61ae44b7f600/lib/matplotlib/tests/baseline_images/test_image/imshow_masked_interpolation.pdf
Open in desktop https://desktop.github.com
lib/matplotlib/tests/baseline_images/test_image/imshow_masked_interpolation.pnghttps://github.com/matplotlib/matplotlib/pull/17636/files#diff-63558c7a21dd861c55d2da4801f3fd111ee60ea490ac52f1cdd16328fe800c2f
View file https://github.com/tacaswell/matplotlib/blob/ca534486cf7f1432d4d3dc6db38e61ae44b7f600/lib/matplotlib/tests/baseline_images/test_image/imshow_masked_interpolation.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/17636/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17636/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.