René's URL Explorer Experiment


Title: MNT: make _setattr_cm more conservative by tacaswell · Pull Request #17620 · matplotlib/matplotlib · GitHub

Open Graph Title: MNT: make _setattr_cm more conservative by tacaswell · Pull Request #17620 · matplotlib/matplotlib

X Title: MNT: make _setattr_cm more conservative by tacaswell · Pull Request #17620 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary special case methods because they are descriptors fail on any other non-instance attribute This is a simpler version of #17561 PR Checklist Has Pytest style unit tests Code is Flak...

X Description: PR Summary special case methods because they are descriptors fail on any other non-instance attribute This is a simpler version of #17561 PR Checklist Has Pytest style unit tests Code is Flak...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/17620

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:9c185d6b-5feb-b4d0-747d-0e7c0d3afced
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idEDBA:15F4EE:A03DE8:D9B949:6A5299D7
html-safe-nonce7f1c7caaf8c360814533df59a710239a7a89d044aac69f7fd21e85e6fdcd7cd4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFREJBOjE1RjRFRTpBMDNERTg6RDlCOTQ5OjZBNTI5OUQ3IiwidmlzaXRvcl9pZCI6IjMyMjE2OTYzNjU0MDgxOTcwODAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac53d4e2f32799aaf404fed62f3228c97d0409d643c914cb759bfc0da5320b91dc
hovercard-subject-tagpull_request:433335049
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/17620/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/6352eab58b045c5aa9faea8b0661971f5458570abef3812a317ed7a681025f25/matplotlib/matplotlib/pull/17620
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6352eab58b045c5aa9faea8b0661971f5458570abef3812a317ed7a681025f25/matplotlib/matplotlib/pull/17620
og:image:altPR Summary special case methods because they are descriptors fail on any other non-instance attribute This is a simpler version of #17561 PR Checklist Has Pytest style unit tests Code is Flak...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametacaswell
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/17620#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17620
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17620
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/17620
Reloadhttps://github.com/matplotlib/matplotlib/pull/17620
Reloadhttps://github.com/matplotlib/matplotlib/pull/17620
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
anntzerhttps://github.com/anntzer
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tacaswell:simplified_setattr_cm_method_handlinghttps://github.com/tacaswell/matplotlib/tree/simplified_setattr_cm_method_handling
Conversationhttps://github.com/matplotlib/matplotlib/pull/17620
Commits1 (1)https://github.com/matplotlib/matplotlib/pull/17620/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/17620/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/17620/files
MNT: make _setattr_cm more conservativehttps://github.com/matplotlib/matplotlib/pull/17620#top
anntzerhttps://github.com/anntzer
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tacaswell:simplified_setattr_cm_method_handlinghttps://github.com/tacaswell/matplotlib/tree/simplified_setattr_cm_method_handling
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jun 11, 2020https://github.com/matplotlib/matplotlib/pull/17620#issue-637323170
#17561https://github.com/matplotlib/matplotlib/pull/17561
Flake 8http://flake8.pycqa.org/en/latest/
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
v3.3.0https://github.com/matplotlib/matplotlib/milestone/48
Jun 11, 2020https://github.com/matplotlib/matplotlib/pull/17620#event-3435978616
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Jun 11, 2020https://github.com/matplotlib/matplotlib/pull/17620#issuecomment-642946727
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jun 11, 2020https://github.com/matplotlib/matplotlib/pull/17620#issuecomment-642969504
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
force-pushedhttps://github.com/matplotlib/matplotlib/compare/4111ab61daf7741f222a78a14ae2b010b8c0592a..d0849a6d4f3ad7237e93de22997e4ce98b1f6e30
4111ab6https://github.com/matplotlib/matplotlib/commit/4111ab61daf7741f222a78a14ae2b010b8c0592a
d0849a6https://github.com/matplotlib/matplotlib/commit/d0849a6d4f3ad7237e93de22997e4ce98b1f6e30
Compare https://github.com/matplotlib/matplotlib/compare/4111ab61daf7741f222a78a14ae2b010b8c0592a..d0849a6d4f3ad7237e93de22997e4ce98b1f6e30
June 11, 2020 23:03https://github.com/matplotlib/matplotlib/pull/17620#event-3436272689
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jun 11, 2020https://github.com/matplotlib/matplotlib/pull/17620#issuecomment-642973248
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
force-pushedhttps://github.com/matplotlib/matplotlib/compare/d0849a6d4f3ad7237e93de22997e4ce98b1f6e30..3b4da04bba576752a2a405b3874b83635e7111af
d0849a6https://github.com/matplotlib/matplotlib/commit/d0849a6d4f3ad7237e93de22997e4ce98b1f6e30
3b4da04https://github.com/matplotlib/matplotlib/commit/3b4da04bba576752a2a405b3874b83635e7111af
Compare https://github.com/matplotlib/matplotlib/compare/d0849a6d4f3ad7237e93de22997e4ce98b1f6e30..3b4da04bba576752a2a405b3874b83635e7111af
June 12, 2020 00:01https://github.com/matplotlib/matplotlib/pull/17620#event-3436385091
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Jun 13, 2020 https://github.com/matplotlib/matplotlib/pull/17620#pullrequestreview-430108534
View reviewed changes https://github.com/matplotlib/matplotlib/pull/17620/files
QuLogichttps://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/17620#pullrequestreview-430108534
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#17561https://github.com/matplotlib/matplotlib/pull/17561
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
lib/matplotlib/tests/test_cbook.pyhttps://github.com/matplotlib/matplotlib/pull/17620/files#diff-e4aa42656b8cbb97bd27e9dca12fd85bb34b8fa7f4f9639c61bd11f031f2c713
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jun 13, 2020 https://github.com/matplotlib/matplotlib/pull/17620#pullrequestreview-430132783
View reviewed changes https://github.com/matplotlib/matplotlib/pull/17620/files
lib/matplotlib/cbook/__init__.pyhttps://github.com/matplotlib/matplotlib/pull/17620/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
anntzerhttps://github.com/anntzer
Jun 13, 2020https://github.com/matplotlib/matplotlib/pull/17620#discussion_r439731808
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
tacaswellhttps://github.com/tacaswell
Jun 14, 2020https://github.com/matplotlib/matplotlib/pull/17620#discussion_r439863336
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
force-pushedhttps://github.com/matplotlib/matplotlib/compare/6ee399afda5414c2428c113a00785f838d262f81..756b9c38c73fa3aca049bf4ef82ba80f8fecab19
6ee399ahttps://github.com/matplotlib/matplotlib/commit/6ee399afda5414c2428c113a00785f838d262f81
756b9c3https://github.com/matplotlib/matplotlib/commit/756b9c38c73fa3aca049bf4ef82ba80f8fecab19
Compare https://github.com/matplotlib/matplotlib/compare/6ee399afda5414c2428c113a00785f838d262f81..756b9c38c73fa3aca049bf4ef82ba80f8fecab19
June 14, 2020 20:42https://github.com/matplotlib/matplotlib/pull/17620#event-3442023083
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
anntzerhttps://github.com/anntzer
June 14, 2020 20:42https://github.com/matplotlib/matplotlib/pull/17620#event-3442023386
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jun 14, 2020 https://github.com/matplotlib/matplotlib/pull/17620#pullrequestreview-430250198
View reviewed changes https://github.com/matplotlib/matplotlib/pull/17620/files
lib/matplotlib/cbook/__init__.pyhttps://github.com/matplotlib/matplotlib/pull/17620/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jun 14, 2020 https://github.com/matplotlib/matplotlib/pull/17620#pullrequestreview-430250228
View reviewed changes https://github.com/matplotlib/matplotlib/pull/17620/files
lib/matplotlib/tests/test_cbook.pyhttps://github.com/matplotlib/matplotlib/pull/17620/files#diff-e4aa42656b8cbb97bd27e9dca12fd85bb34b8fa7f4f9639c61bd11f031f2c713
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jun 14, 2020 https://github.com/matplotlib/matplotlib/pull/17620#pullrequestreview-430250239
View reviewed changes https://github.com/matplotlib/matplotlib/pull/17620/files
lib/matplotlib/tests/test_cbook.pyhttps://github.com/matplotlib/matplotlib/pull/17620/files#diff-e4aa42656b8cbb97bd27e9dca12fd85bb34b8fa7f4f9639c61bd11f031f2c713
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jun 14, 2020 https://github.com/matplotlib/matplotlib/pull/17620#pullrequestreview-430250250
View reviewed changes https://github.com/matplotlib/matplotlib/pull/17620/files
anntzerhttps://github.com/anntzer
https://github.com/matplotlib/matplotlib/pull/17620#pullrequestreview-430250250
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/tacaswell
MNT: make _setattr_cm more conservativehttps://github.com/matplotlib/matplotlib/pull/17620/commits/9e88fa552ff80520d15de396c33dc7e0c2150321
9e88fa5https://github.com/matplotlib/matplotlib/pull/17620/commits/9e88fa552ff80520d15de396c33dc7e0c2150321
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
force-pushedhttps://github.com/matplotlib/matplotlib/compare/756b9c38c73fa3aca049bf4ef82ba80f8fecab19..9e88fa552ff80520d15de396c33dc7e0c2150321
756b9c3https://github.com/matplotlib/matplotlib/commit/756b9c38c73fa3aca049bf4ef82ba80f8fecab19
9e88fa5https://github.com/matplotlib/matplotlib/commit/9e88fa552ff80520d15de396c33dc7e0c2150321
Compare https://github.com/matplotlib/matplotlib/compare/756b9c38c73fa3aca049bf4ef82ba80f8fecab19..9e88fa552ff80520d15de396c33dc7e0c2150321
June 15, 2020 15:43https://github.com/matplotlib/matplotlib/pull/17620#event-3445029758
https://github.com/anntzer
anntzerhttps://github.com/anntzer
e86e059https://github.com/matplotlib/matplotlib/commit/e86e05960610e1e9f4b7a9c6e095392e50238744
Jun 15, 2020https://github.com/matplotlib/matplotlib/pull/17620#event-3445433374
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
June 15, 2020 18:29https://github.com/matplotlib/matplotlib/pull/17620#event-3445654372
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jun 16, 2020 https://github.com/matplotlib/matplotlib/pull/17620#ref-issue-639691393
more conservative setattr_cm broke mplcairo #17646 https://github.com/matplotlib/matplotlib/issues/17646
https://github.com/ianhi
ianhihttps://github.com/ianhi
Aug 24, 2020 https://github.com/matplotlib/matplotlib/pull/17620#ref-issue-670026262
Saving png figures matplotlib 3.3.0 results in "AttributeError: __delete__" matplotlib/ipympl#252 https://github.com/matplotlib/ipympl/issues/252
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17620
https://github.com/QuLogic
QuLogic https://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/17620/files/3b4da04bba576752a2a405b3874b83635e7111af
https://github.com/anntzer
anntzer https://github.com/anntzer
https://github.com/matplotlib/matplotlib/pull/17620/files/756b9c38c73fa3aca049bf4ef82ba80f8fecab19
v3.3.0 https://github.com/matplotlib/matplotlib/milestone/48
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17620
https://github.com/tacaswell
https://github.com/QuLogic
https://github.com/anntzer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.