Title: FIX: correctly handle large arcs by tacaswell · Pull Request #17564 · matplotlib/matplotlib · GitHub
Open Graph Title: FIX: correctly handle large arcs by tacaswell · Pull Request #17564 · matplotlib/matplotlib
X Title: FIX: correctly handle large arcs by tacaswell · Pull Request #17564 · matplotlib/matplotlib
Description: The draw method of mpatches.Arc has two paths: if the arc is "small" compared to its size in the rendered image then render the whole arc and let clipping do it's thing if the arc is "big" compared to its size on the screen then sort out where the circle intersects the axes boundary and only draw that part of it This makes several changes to the Arc draw method: only "squash" the angles in the "small" case is we handle it in the "big" case via transforms make sure that we don't re-order the angles while "squashing" them. Adjusted the test image to use this failing case and to exercise both code paths, but could be convinced to split it out into its own file. closes #17547 PR Checklist Has Pytest style unit tests Code is Flake 8 compliant
Open Graph Description: The draw method of mpatches.Arc has two paths: if the arc is "small" compared to its size in the rendered image then render the whole arc and let clipping do it's thing if the arc is...
X Description: The draw method of mpatches.Arc has two paths: if the arc is "small" compared to its size in the rendered image then render the whole arc and let clipping do it's thing i...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/17564
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:20879717-f330-6ba6-f696-0ff4f88f58dd |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | E596:95C7C:4A6F6C:642E00:6A540ADF |
| html-safe-nonce | ba18e3f2160a8a4594c6cc7d8b6fa38295ba2aca9c277b45a28828fe8e81b972 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNTk2Ojk1QzdDOjRBNkY2Qzo2NDJFMDA6NkE1NDBBREYiLCJ2aXNpdG9yX2lkIjoiMTg2ODAyMTQxOTMwMjE5Mzg4NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8ef24ec3885e75561c7577441042f1a248a5b6eb928ac3ea7a68adfd1ef6c98b |
| hovercard-subject-tag | pull_request:427578762 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/17564/files |
| twitter:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/199813?s=400&v=4 |
| og:image:alt | The draw method of mpatches.Arc has two paths: if the arc is "small" compared to its size in the rendered image then render the whole arc and let clipping do it's thing if the arc is... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width
