René's URL Explorer Experiment


Title: FIX: do not let no-op monkey patches to renderer leak out by tacaswell · Pull Request #17560 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: do not let no-op monkey patches to renderer leak out by tacaswell · Pull Request #17560 · matplotlib/matplotlib

X Title: FIX: do not let no-op monkey patches to renderer leak out by tacaswell · Pull Request #17560 · matplotlib/matplotlib

Description: PR Summary closes #17542 This issue is that in some cases the no-op monkey patched renderer was getting cached deep in the backend code and the no-op functions were getting used for the actual save which resulted in empty figures. This moves the monkey patching to the call sites so we can use the _setattr_cm to manage this. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant [NA] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way (internal api only)

Open Graph Description: PR Summary closes #17542 This issue is that in some cases the no-op monkey patched renderer was getting cached deep in the backend code and the no-op functions were getting used for the actual save...

X Description: PR Summary closes #17542 This issue is that in some cases the no-op monkey patched renderer was getting cached deep in the backend code and the no-op functions were getting used for the actual save...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/17560

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:74625f28-816a-85ec-32a7-730249440a12
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE940:3DC42C:63EE06:85E352:6A52FC77
html-safe-noncef1a2728fd18ea8a541ad360aa926dcf8423178e2a90ed34c012be18129b7e9c6
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOTQwOjNEQzQyQzo2M0VFMDY6ODVFMzUyOjZBNTJGQzc3IiwidmlzaXRvcl9pZCI6IjIzNDEzMDcyNTYwNDAyNTg2NzkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacd1683fe19fd82c76cb4866a475b7082c5da782a6a7707c7cf372d1a3c2342b74
hovercard-subject-tagpull_request:427437369
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/17560/files
twitter:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/199813?s=400&v=4
og:image:altPR Summary closes #17542 This issue is that in some cases the no-op monkey patched renderer was getting cached deep in the backend code and the no-op functions were getting used for the actual save...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/17560/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17560%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17560%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/17560/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/17560/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/17560/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17560/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17560/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tacaswell:fix_noop_tight_bboxhttps://github.com/tacaswell/matplotlib/tree/fix_noop_tight_bbox
Conversation 8 https://github.com/matplotlib/matplotlib/pull/17560
Commits 2 https://github.com/matplotlib/matplotlib/pull/17560/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/17560/checks
Files changed https://github.com/matplotlib/matplotlib/pull/17560/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17560/files
FIX: do not let no-op monkey patches to renderer leak out https://github.com/matplotlib/matplotlib/pull/17560/files#top
Show all changes 2 commits https://github.com/matplotlib/matplotlib/pull/17560/files
5324ada FIX: do not let no-op monkey patches to renderer leak out tacaswell Jun 3, 2020 https://github.com/matplotlib/matplotlib/pull/17560/commits/5324adaec6a7fd3d78dea7b28451d5f6e95392a6
f777177 MNT: consolidate the no-op logic into a RenderBase method tacaswell Jun 8, 2020 https://github.com/matplotlib/matplotlib/pull/17560/commits/f777177971f12c79d46e85819caad5539c5c221b
Clear filters https://github.com/matplotlib/matplotlib/pull/17560/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17560/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17560/files
backend_bases.py https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
figure.py https://github.com/matplotlib/matplotlib/pull/17560/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
test_bbox_tight.py https://github.com/matplotlib/matplotlib/pull/17560/files#diff-f2f0f12dbfe63ae94e21688d3465b81421c6a1c1d8876766a905040d449b14c8
tight_layout.py https://github.com/matplotlib/matplotlib/pull/17560/files#diff-10debfd0ac57a591c4fe93987427a88707d0342695705334479d17820a3c8fe8
lib/matplotlib/backend_bases.pyhttps://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
View file https://github.com/tacaswell/matplotlib/blob/f777177971f12c79d46e85819caad5539c5c221b/lib/matplotlib/backend_bases.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/17560/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-c21fb96269cbb9b214edf0c22981b347d8b710abaad167da678242ce8a539bb2
lib/matplotlib/figure.pyhttps://github.com/matplotlib/matplotlib/pull/17560/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
View file https://github.com/tacaswell/matplotlib/blob/f777177971f12c79d46e85819caad5539c5c221b/lib/matplotlib/figure.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/17560/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
lib/matplotlib/tests/test_bbox_tight.pyhttps://github.com/matplotlib/matplotlib/pull/17560/files#diff-f2f0f12dbfe63ae94e21688d3465b81421c6a1c1d8876766a905040d449b14c8
View file https://github.com/tacaswell/matplotlib/blob/f777177971f12c79d46e85819caad5539c5c221b/lib/matplotlib/tests/test_bbox_tight.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/17560/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-f2f0f12dbfe63ae94e21688d3465b81421c6a1c1d8876766a905040d449b14c8
lib/matplotlib/tight_layout.pyhttps://github.com/matplotlib/matplotlib/pull/17560/files#diff-10debfd0ac57a591c4fe93987427a88707d0342695705334479d17820a3c8fe8
View file https://github.com/tacaswell/matplotlib/blob/f777177971f12c79d46e85819caad5539c5c221b/lib/matplotlib/tight_layout.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/17560/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-10debfd0ac57a591c4fe93987427a88707d0342695705334479d17820a3c8fe8
https://github.com/matplotlib/matplotlib/pull/17560/files#diff-10debfd0ac57a591c4fe93987427a88707d0342695705334479d17820a3c8fe8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.