| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:cc6b411e-2b2f-a0d0-fdbd-43e603fccec9 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC38:19C73D:254A30:31F985:6A52E81A |
| html-safe-nonce | 6d8d72dd60620a9b434a5e6b31d9eb27936258e56ec2285d600e5ff2b96f5c9d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzM4OjE5QzczRDoyNTRBMzA6MzFGOTg1OjZBNTJFODFBIiwidmlzaXRvcl9pZCI6IjQyMzExNzEzNjk2OTI0ODk3NTQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b4a960dfdf6ec867b41a62556b740552d84578b995b9ebd0e2a805b677307e27 |
| hovercard-subject-tag | pull_request:414351593 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/17344/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/01f2a27ee44d068719cf215d46f617c307a6f5b1812a2a5048029d76653822cd/matplotlib/matplotlib/pull/17344 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/01f2a27ee44d068719cf215d46f617c307a6f5b1812a2a5048029d76653822cd/matplotlib/matplotlib/pull/17344 |
| og:image:alt | PR Summary
Closes #17343
add_subplot is meant to accept spans for the third parameter, but this was broken by #16527 which was doing more careful argument checking. Happy to take criticism on how... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jklymak |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/17344#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17344 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17344 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/17344 |
| Reload | https://github.com/matplotlib/matplotlib/pull/17344 |
| Reload | https://github.com/matplotlib/matplotlib/pull/17344 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| jklymak | https://github.com/jklymak |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| jklymak:fix-allow-start-stop-subplot | https://github.com/jklymak/matplotlib/tree/fix-allow-start-stop-subplot |
| Conversation | https://github.com/matplotlib/matplotlib/pull/17344 |
| Commits2 (2) | https://github.com/matplotlib/matplotlib/pull/17344/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/17344/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/17344/files |
| FIX: allow start-stop subplot | https://github.com/matplotlib/matplotlib/pull/17344#top |
| jklymak | https://github.com/jklymak |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| jklymak:fix-allow-start-stop-subplot | https://github.com/jklymak/matplotlib/tree/fix-allow-start-stop-subplot |
|
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| May 6, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#issue-613634258 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| #17343 | https://github.com/matplotlib/matplotlib/issues/17343 |
| #16527 | https://github.com/matplotlib/matplotlib/pull/16527 |
| https://user-images.githubusercontent.com/1562854/81231838-b3150b80-8fa8-11ea-9ae0-8fc235c7aa9a.png |
| Flake 8 | http://flake8.pycqa.org/en/latest/ |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| v3.3.0 | https://github.com/matplotlib/matplotlib/milestone/48 |
| May 6, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#event-3310423627 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
API: argument checking
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22API%3A%20argument%20checking%22 |
|
Release critical
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22 |
| May 6, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#event-3310424312 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| timhoffm | https://github.com/timhoffm |
| May 6, 2020 22:04 | https://github.com/matplotlib/matplotlib/pull/17344#event-3310463838 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/a2f73b176b02d2f87a07af09702d498d459f8a2c..37593c498b44e0c94bd5cda075a57c7c0a41fe3f |
| a2f73b1 | https://github.com/matplotlib/matplotlib/commit/a2f73b176b02d2f87a07af09702d498d459f8a2c |
| 37593c4 | https://github.com/matplotlib/matplotlib/commit/37593c498b44e0c94bd5cda075a57c7c0a41fe3f |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/a2f73b176b02d2f87a07af09702d498d459f8a2c..37593c498b44e0c94bd5cda075a57c7c0a41fe3f |
| May 6, 2020 22:05 | https://github.com/matplotlib/matplotlib/pull/17344#event-3310466577 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| May 6, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#issuecomment-624918049 |
| @story645 | https://github.com/story645 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| May 6, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#issuecomment-624921648 |
| https://www.mathworks.com/help/matlab/ref/subplot.html | https://www.mathworks.com/help/matlab/ref/subplot.html |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
May 6, 2020
| https://github.com/matplotlib/matplotlib/pull/17344#pullrequestreview-407027089 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/17344/files |
| lib/matplotlib/figure.py | https://github.com/matplotlib/matplotlib/pull/17344/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| lib/matplotlib/figure.py | https://github.com/matplotlib/matplotlib/pull/17344/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| lib/matplotlib/figure.py | https://github.com/matplotlib/matplotlib/pull/17344/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
May 6, 2020
| https://github.com/matplotlib/matplotlib/pull/17344#pullrequestreview-407060519 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/17344/files |
| lib/matplotlib/figure.py | https://github.com/matplotlib/matplotlib/pull/17344/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
May 6, 2020
| https://github.com/matplotlib/matplotlib/pull/17344#ref-pullrequest-613683753 |
|
ENH: reuse oldgridspec is possible...
#17347
| https://github.com/matplotlib/matplotlib/pull/17347 |
|
| https://github.com/jklymak |
| FIX: allow start-stop subplot | https://github.com/matplotlib/matplotlib/pull/17344/commits/be1b73041cba9c5e7963276d0520f0fdf132a67e |
| be1b730 | https://github.com/matplotlib/matplotlib/pull/17344/commits/be1b73041cba9c5e7963276d0520f0fdf132a67e |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/89fa0e0b2cc76ab6c87117d0ed01218b7c6a1549..be1b73041cba9c5e7963276d0520f0fdf132a67e |
| 89fa0e0 | https://github.com/matplotlib/matplotlib/commit/89fa0e0b2cc76ab6c87117d0ed01218b7c6a1549 |
| be1b730 | https://github.com/matplotlib/matplotlib/commit/be1b73041cba9c5e7963276d0520f0fdf132a67e |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/89fa0e0b2cc76ab6c87117d0ed01218b7c6a1549..be1b73041cba9c5e7963276d0520f0fdf132a67e |
| May 7, 2020 00:02 | https://github.com/matplotlib/matplotlib/pull/17344#event-3310710140 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
May 7, 2020
| https://github.com/matplotlib/matplotlib/pull/17344#pullrequestreview-407157699 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/17344/files/be1b73041cba9c5e7963276d0520f0fdf132a67e |
| lib/matplotlib/figure.py | https://github.com/matplotlib/matplotlib/pull/17344/files/be1b73041cba9c5e7963276d0520f0fdf132a67e#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df |
| QuLogic | https://github.com/QuLogic |
| May 7, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#discussion_r421247503 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
May 7, 2020
| https://github.com/matplotlib/matplotlib/pull/17344#ref-pullrequest-613944025 |
|
Move integerness checks to SubplotSpec._from_subplot_args.
#17350
| https://github.com/matplotlib/matplotlib/pull/17350 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| May 7, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#issuecomment-625167697 |
| #17350 | https://github.com/matplotlib/matplotlib/pull/17350 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
|
| https://github.com/jklymak |
| FIX: re-factor | https://github.com/matplotlib/matplotlib/pull/17344/commits/fdc90859bb40d7daa61f53c510abbeadd07bcd1c |
| fdc9085 | https://github.com/matplotlib/matplotlib/pull/17344/commits/fdc90859bb40d7daa61f53c510abbeadd07bcd1c |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| May 7, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#issuecomment-625356620 |
| #17350 | https://github.com/matplotlib/matplotlib/pull/17350 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| May 7, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#event-3313663945 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| May 7, 2020 16:21 | https://github.com/matplotlib/matplotlib/pull/17344#event-3313664293 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| May 7, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#issuecomment-625359279 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| v3.3.0 | https://github.com/matplotlib/matplotlib/milestone/48 |
| Jul 9, 2020 | https://github.com/matplotlib/matplotlib/pull/17344#event-3528888178 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17344 |
|
| https://github.com/QuLogic |
|
QuLogic
| https://github.com/QuLogic |
|
| https://github.com/matplotlib/matplotlib/pull/17344/files/be1b73041cba9c5e7963276d0520f0fdf132a67e |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
API: argument checking
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22API%3A%20argument%20checking%22 |
|
Release critical
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22 |
|
Regression in add_subplot..
| https://github.com/matplotlib/matplotlib/issues/17343 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/17344 |
|
| https://github.com/jklymak |
|
| https://github.com/tacaswell |
|
| https://github.com/anntzer |
|
| https://github.com/QuLogic |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |