René's URL Explorer Experiment


Title: Make API of get_tightbbox more consistent between Axes and Axis. by anntzer · Pull Request #17287 · matplotlib/matplotlib · GitHub

Open Graph Title: Make API of get_tightbbox more consistent between Axes and Axis. by anntzer · Pull Request #17287 · matplotlib/matplotlib

X Title: Make API of get_tightbbox more consistent between Axes and Axis. by anntzer · Pull Request #17287 · matplotlib/matplotlib

Description: Instead of having Axes trying to figure out what direction to ignore, let the Axis handle that. This keeps the signature of get_tightbbox consistent between Axes and Axis. Also fix a typo bb_xaxis -> bb_yaxis. Followup to #17222; was discussed briefly in #17222 (comment) though not acted upon. Even if we decide not to go that route at least the bb_xaxis->bb_yaxis change should be split out and merged for 3.3. Marked as release critical so that we don't change the API after the release, if we decide to go this route. PR Summary PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Open Graph Description: Instead of having Axes trying to figure out what direction to ignore, let the Axis handle that. This keeps the signature of get_tightbbox consistent between Axes and Axis. Also fix a typo bb_xaxis...

X Description: Instead of having Axes trying to figure out what direction to ignore, let the Axis handle that. This keeps the signature of get_tightbbox consistent between Axes and Axis. Also fix a typo bb_xaxis...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/17287

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0f6d39a7-7dd7-033a-f3c1-2a38d3614e64
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBB8:2A51A:9C8AF7:D4C975:6A569583
html-safe-nonceb6b87063b6b5aa51f68e9b2f7294d2e8c2be76bf0657805a5bd73bd19ed8a77d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkI4OjJBNTFBOjlDOEFGNzpENEM5NzU6NkE1Njk1ODMiLCJ2aXNpdG9yX2lkIjoiODU1NDA4NzY4NDg2MzMyMTkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacbbc6c67034ea337347f430a984b50480f4fe50b5fa80320f6bb0bc0f44a07079
hovercard-subject-tagpull_request:411875534
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/17287/files
twitter:imagehttps://avatars.githubusercontent.com/u/1322974?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1322974?s=400&v=4
og:image:altInstead of having Axes trying to figure out what direction to ignore, let the Axis handle that. This keeps the signature of get_tightbbox consistent between Axes and Axis. Also fix a typo bb_xaxis...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None647a25f437e2f54eccdd162bd007c8ae70f4235c4125dba0f4518747cc8b9615
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release05adb86a60ce3d701e556eded3ab26300ec6bcc4
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/17287/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17287%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F17287%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/17287/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/17287/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/17287/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17287/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17287/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 410 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
anntzer:tbbhttps://github.com/anntzer/matplotlib/tree/tbb
Conversation 11 https://github.com/matplotlib/matplotlib/pull/17287
Commits 2 https://github.com/matplotlib/matplotlib/pull/17287/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/17287/checks
Files changed https://github.com/matplotlib/matplotlib/pull/17287/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17287/files
Make API of get_tightbbox more consistent between Axes and Axis. https://github.com/matplotlib/matplotlib/pull/17287/files#top
Show all changes 2 commits https://github.com/matplotlib/matplotlib/pull/17287/files
0fe574e Make API of get_tightbbox more consistent between Axes and Axis. anntzer Apr 30, 2020 https://github.com/matplotlib/matplotlib/pull/17287/commits/0fe574ef6bfb913d9bd5b48616f1b24113783e56
d530e47 Only consider visible Axises in Axes tightbbox. anntzer May 7, 2020 https://github.com/matplotlib/matplotlib/pull/17287/commits/d530e47b8665122ead89192e63cc1af5c0ee4914
Clear filters https://github.com/matplotlib/matplotlib/pull/17287/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17287/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17287/files
behaviour.rst https://github.com/matplotlib/matplotlib/pull/17287/files#diff-922c53de3c8172692f510272a85e85902a1c1b42ce2771c793529f611a41d6bc
_base.py https://github.com/matplotlib/matplotlib/pull/17287/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
axis.py https://github.com/matplotlib/matplotlib/pull/17287/files#diff-04227e6d4900298b309bddab2e848da8cc638da2913c64b5dcf0d800ba2a0c16
doc/api/api_changes_3.3/behaviour.rsthttps://github.com/matplotlib/matplotlib/pull/17287/files#diff-922c53de3c8172692f510272a85e85902a1c1b42ce2771c793529f611a41d6bc
View file https://github.com/anntzer/matplotlib/blob/d530e47b8665122ead89192e63cc1af5c0ee4914/doc/api/api_changes_3.3/behaviour.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/17287/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/17287/files#diff-922c53de3c8172692f510272a85e85902a1c1b42ce2771c793529f611a41d6bc
https://github.com/matplotlib/matplotlib/pull/17287/files#diff-922c53de3c8172692f510272a85e85902a1c1b42ce2771c793529f611a41d6bc
lib/matplotlib/axes/_base.pyhttps://github.com/matplotlib/matplotlib/pull/17287/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
View file https://github.com/anntzer/matplotlib/blob/d530e47b8665122ead89192e63cc1af5c0ee4914/lib/matplotlib/axes/_base.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/17287/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/17287/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
https://github.com/matplotlib/matplotlib/pull/17287/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
lib/matplotlib/axis.pyhttps://github.com/matplotlib/matplotlib/pull/17287/files#diff-04227e6d4900298b309bddab2e848da8cc638da2913c64b5dcf0d800ba2a0c16
View file https://github.com/anntzer/matplotlib/blob/d530e47b8665122ead89192e63cc1af5c0ee4914/lib/matplotlib/axis.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/17287/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/17287/files#diff-04227e6d4900298b309bddab2e848da8cc638da2913c64b5dcf0d800ba2a0c16
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17287/files
jklymakhttps://github.com/jklymak
May 1, 2020https://github.com/matplotlib/matplotlib/pull/17287/files#r418558437
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17287/files
https://github.com/matplotlib/matplotlib/pull/17287/files#diff-04227e6d4900298b309bddab2e848da8cc638da2913c64b5dcf0d800ba2a0c16
jklymakhttps://github.com/jklymak
May 1, 2020https://github.com/matplotlib/matplotlib/pull/17287/files#r418558888
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17287/files
tacaswellhttps://github.com/tacaswell
May 7, 2020https://github.com/matplotlib/matplotlib/pull/17287/files#r421776009
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/17287/files
https://github.com/matplotlib/matplotlib/pull/17287/files#diff-04227e6d4900298b309bddab2e848da8cc638da2913c64b5dcf0d800ba2a0c16
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.