Title: Fix RecursionError when closing nbAgg figures. by QuLogic · Pull Request #17025 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix RecursionError when closing nbAgg figures. by QuLogic · Pull Request #17025 · matplotlib/matplotlib
X Title: Fix RecursionError when closing nbAgg figures. by QuLogic · Pull Request #17025 · matplotlib/matplotlib
Description: PR Summary Previously, if a figure number was not in the list of managed figures, the destroy would be skipped, but now that only happens if a figure number is passed. If a figure manager is passed, then the destroy happens regardless. In nbAgg, this loops around closing/close_event and eventually calls destroy again, leading to a RecursionError. This broke in 9e6f112; cc @anntzer. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant [N/A] New features are documented, with examples if plot related [N/A] Documentation is sphinx and numpydoc compliant [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: PR Summary Previously, if a figure number was not in the list of managed figures, the destroy would be skipped, but now that only happens if a figure number is passed. If a figure manager is passed...
X Description: PR Summary Previously, if a figure number was not in the list of managed figures, the destroy would be skipped, but now that only happens if a figure number is passed. If a figure manager is passed...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/17025
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1f215d20-dd54-bea4-7b63-23ac3c2867f6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CB74:3D0DAC:61DEADC:89D6FB6:6A574B35 |
| html-safe-nonce | 201a1fc5695180dbdb30358c9abfbbad39438c5c94dfd35c204030584175d594 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQjc0OjNEMERBQzo2MURFQURDOjg5RDZGQjY6NkE1NzRCMzUiLCJ2aXNpdG9yX2lkIjoiMzcwNjkxMjQ1NzM1ODc4OTQyOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b5249c3d487a3c46856be1a44f6220d98db3e04d8fd85dc286c163ebce91e961 |
| hovercard-subject-tag | pull_request:398488956 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/17025/files |
| twitter:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/302469?s=400&v=4 |
| og:image:alt | PR Summary Previously, if a figure number was not in the list of managed figures, the destroy would be skipped, but now that only happens if a figure number is passed. If a figure manager is passed... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 602250ea3b6dd8302a7220ef98adb828dbc807e4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width