| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:2bfa867b-e50a-6c76-85b5-11a9d2471c8a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8F0E:334ED5:3F763B:555790:6A5275C2 |
| html-safe-nonce | ea51a7b74776fdab10ad21f1c596eb0f9d3f2171250028409bebb8d69cb2aad2 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjBFOjMzNEVENTozRjc2M0I6NTU1NzkwOjZBNTI3NUMyIiwidmlzaXRvcl9pZCI6Ijg5MzQ1Mzg0MzAwMzUxNjI1NjIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | d638e34f91b79d6b5b4a7696a99bd040ab9caf0e5ae02d3688274b458052e4d3 |
| hovercard-subject-tag | pull_request:395001557 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/16940/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/4bb83d60075e56225ddb6639d643df067f7033655b073eeee90de808a78dad31/matplotlib/matplotlib/pull/16940 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/4bb83d60075e56225ddb6639d643df067f7033655b073eeee90de808a78dad31/matplotlib/matplotlib/pull/16940 |
| og:image:alt | PR Summary
Clarify that the names matter and add a check with a better exception.
closes #16916
PR Checklist
Has Pytest style unit tests
Code is Flake 8 compliant
New features are documented, w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tacaswell |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/16940#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16940 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16940 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/16940 |
| Reload | https://github.com/matplotlib/matplotlib/pull/16940 |
| Reload | https://github.com/matplotlib/matplotlib/pull/16940 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| QuLogic | https://github.com/QuLogic |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| tacaswell:doc_compare_figures_equal | https://github.com/tacaswell/matplotlib/tree/doc_compare_figures_equal |
| Conversation | https://github.com/matplotlib/matplotlib/pull/16940 |
| Commits2 (2) | https://github.com/matplotlib/matplotlib/pull/16940/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/16940/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/16940/files |
| DOC/FIX: clarify the docs for check_figures_equal | https://github.com/matplotlib/matplotlib/pull/16940#top |
| QuLogic | https://github.com/QuLogic |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| tacaswell:doc_compare_figures_equal | https://github.com/tacaswell/matplotlib/tree/doc_compare_figures_equal |
|
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Mar 27, 2020 | https://github.com/matplotlib/matplotlib/pull/16940#issue-589451607 |
| #16916 | https://github.com/matplotlib/matplotlib/issues/16916 |
| Flake 8 | http://flake8.pycqa.org/en/latest/ |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| v3.2.2 | https://github.com/matplotlib/matplotlib/milestone/52 |
| Mar 27, 2020 | https://github.com/matplotlib/matplotlib/pull/16940#event-3174332515 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
topic: testing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22 |
| Mar 28, 2020 | https://github.com/matplotlib/matplotlib/pull/16940#event-3174438740 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Mar 28, 2020
| https://github.com/matplotlib/matplotlib/pull/16940#pullrequestreview-383258662 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/16940/files |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
|
Mar 29, 2020
| https://github.com/matplotlib/matplotlib/pull/16940#pullrequestreview-383366046 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/16940/files |
| lib/matplotlib/testing/decorators.py | https://github.com/matplotlib/matplotlib/pull/16940/files#diff-634eb58f2970e77b1feabc7824a5d757378ee8c3174867d1c7a1481a833637f3 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
| lib/matplotlib/tests/test_testing.py | https://github.com/matplotlib/matplotlib/pull/16940/files#diff-70b44bc766a2a31e87fe04979c3561883d09e6106df985930797ca268f937d61 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
|
| https://github.com/tacaswell |
| DOC/FIX: clarify the docs for check_figures_equal | https://github.com/matplotlib/matplotlib/pull/16940/commits/b0d63b56cc5437e46fa23ea2b8fc73b8b41a533c |
| b0d63b5 | https://github.com/matplotlib/matplotlib/pull/16940/commits/b0d63b56cc5437e46fa23ea2b8fc73b8b41a533c |
| matplotlib#16916 | https://github.com/matplotlib/matplotlib/issues/16916 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/d2328feda9df1584f9589248ddb6c7239e3cc7c6..b0d63b56cc5437e46fa23ea2b8fc73b8b41a533c |
| d2328fe | https://github.com/matplotlib/matplotlib/commit/d2328feda9df1584f9589248ddb6c7239e3cc7c6 |
| b0d63b5 | https://github.com/matplotlib/matplotlib/commit/b0d63b56cc5437e46fa23ea2b8fc73b8b41a533c |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/d2328feda9df1584f9589248ddb6c7239e3cc7c6..b0d63b56cc5437e46fa23ea2b8fc73b8b41a533c |
| March 30, 2020 03:37 | https://github.com/matplotlib/matplotlib/pull/16940#event-3176761810 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Mar 30, 2020 | https://github.com/matplotlib/matplotlib/pull/16940#issuecomment-605765167 |
| @QuLogic | https://github.com/QuLogic |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Mar 30, 2020
| https://github.com/matplotlib/matplotlib/pull/16940#pullrequestreview-383606077 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/16940/files/b0d63b56cc5437e46fa23ea2b8fc73b8b41a533c |
| lib/matplotlib/testing/decorators.py | https://github.com/matplotlib/matplotlib/pull/16940/files/b0d63b56cc5437e46fa23ea2b8fc73b8b41a533c#diff-634eb58f2970e77b1feabc7824a5d757378ee8c3174867d1c7a1481a833637f3 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
|
| https://github.com/tacaswell |
|
| https://github.com/timhoffm |
| MNT: use simpler set opretaions | https://github.com/matplotlib/matplotlib/pull/16940/commits/0a33534f3b45ec44c5128b27a2278f828b89540d |
| 0a33534 | https://github.com/matplotlib/matplotlib/pull/16940/commits/0a33534f3b45ec44c5128b27a2278f828b89540d |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Mar 30, 2020
| https://github.com/matplotlib/matplotlib/pull/16940#pullrequestreview-384194535 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/16940/files/0a33534f3b45ec44c5128b27a2278f828b89540d |
| timhoffm | https://github.com/timhoffm |
| https://github.com/matplotlib/matplotlib/pull/16940#pullrequestreview-384194535 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Mar 30, 2020 | https://github.com/matplotlib/matplotlib/pull/16940#issuecomment-606255552 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| Mar 31, 2020 | https://github.com/matplotlib/matplotlib/pull/16940#issuecomment-606389158 |
| #16973 | https://github.com/matplotlib/matplotlib/pull/16973 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| b01325c | https://github.com/matplotlib/matplotlib/commit/b01325cd0e85ef856c241435a6658ed1a74f5de4 |
| Mar 31, 2020 | https://github.com/matplotlib/matplotlib/pull/16940#event-3181798563 |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Mar 31, 2020
| https://github.com/matplotlib/matplotlib/pull/16940#ref-commit-2ce7057 |
|
| https://github.com/QuLogic |
|
| https://github.com/meeseeksmachine |
| Backport PR | https://github.com/meeseeksmachine/matplotlib/commit/2ce7057e674217ce6511d1bc68ce9ab395433cb3 |
| matplotlib#16940 | https://github.com/matplotlib/matplotlib/pull/16940 |
| : DOC/FIX: clarify the docs for check_fig… | https://github.com/meeseeksmachine/matplotlib/commit/2ce7057e674217ce6511d1bc68ce9ab395433cb3 |
| 2ce7057 | https://github.com/meeseeksmachine/matplotlib/commit/2ce7057e674217ce6511d1bc68ce9ab395433cb3 |
| https://github.com/meeseeksmachine |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Mar 31, 2020
| https://github.com/matplotlib/matplotlib/pull/16940#ref-pullrequest-590844936 |
|
Backport PR #16940 on branch v3.2.x (DOC/FIX: clarify the docs for check_figures_equal)
#16974
| https://github.com/matplotlib/matplotlib/pull/16974 |
| QuLogic | https://github.com/QuLogic |
|
Mar 31, 2020
| https://github.com/matplotlib/matplotlib/pull/16940#ref-commit-39e5589 |
|
| https://github.com/QuLogic |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/39e55892ed454b1c72075c025524d6d49f5db0ae |
| #16974 | https://github.com/matplotlib/matplotlib/pull/16974 |
| from meeseeksmachine/auto-backport-of-pr-16… | https://github.com/matplotlib/matplotlib/commit/39e55892ed454b1c72075c025524d6d49f5db0ae |
| 39e5589 | https://github.com/matplotlib/matplotlib/commit/39e55892ed454b1c72075c025524d6d49f5db0ae |
| #16940 | https://github.com/matplotlib/matplotlib/pull/16940 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| May 6, 2021 23:03 | https://github.com/matplotlib/matplotlib/pull/16940#event-4698320723 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16940 |
|
| https://github.com/QuLogic |
|
QuLogic
| https://github.com/QuLogic |
|
| https://github.com/matplotlib/matplotlib/pull/16940/files/d2328feda9df1584f9589248ddb6c7239e3cc7c6 |
|
| https://github.com/anntzer |
|
anntzer
| https://github.com/anntzer |
|
| https://github.com/matplotlib/matplotlib/pull/16940/files/d2328feda9df1584f9589248ddb6c7239e3cc7c6 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/16940/files/0a33534f3b45ec44c5128b27a2278f828b89540d |
|
topic: testing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22 |
|
v3.2.2
| https://github.com/matplotlib/matplotlib/milestone/52 |
|
check_figures_equal regression from 3.2.0 to 3.2.1
| https://github.com/matplotlib/matplotlib/issues/16916 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/16940 |
|
| https://github.com/tacaswell |
|
| https://github.com/QuLogic |
|
| https://github.com/anntzer |
|
| https://github.com/timhoffm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |