Title: Warn in the docs that MouseEvent.key can be wrong. by anntzer · Pull Request #16892 · matplotlib/matplotlib · GitHub
Open Graph Title: Warn in the docs that MouseEvent.key can be wrong. by anntzer · Pull Request #16892 · matplotlib/matplotlib
X Title: Warn in the docs that MouseEvent.key can be wrong. by anntzer · Pull Request #16892 · matplotlib/matplotlib
Description: PR Summary MouseEvent.key is just derived from the last key_press_event/key_release_event, so will be wrong e.g. if one presses a key while the canvas does not have focus, then move the mouse to the canvas and clicks. In general I think it isn't possible to know what keys are pressed while a mouse even occurs; one can only have a list of modifiers (ctrl/alt/shift). There's a PR adding that at #6159 but it needs a bit of work, so let's document the limitation for now. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: PR Summary MouseEvent.key is just derived from the last key_press_event/key_release_event, so will be wrong e.g. if one presses a key while the canvas does not have focus, then move the mouse to th...
X Description: PR Summary MouseEvent.key is just derived from the last key_press_event/key_release_event, so will be wrong e.g. if one presses a key while the canvas does not have focus, then move the mouse to th...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/16892
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:2a5ae49a-e5af-bcad-8fa3-5427e56c8b91 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CE36:2F9C11:18260E3:20C3D1A:6A547064 |
| html-safe-nonce | bfedfb510ac50773637ff0712d01a91a4cfd87f0b686de62d9a7ff4a810407f4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRTM2OjJGOUMxMToxODI2MEUzOjIwQzNEMUE6NkE1NDcwNjQiLCJ2aXNpdG9yX2lkIjoiODg0NTkyNDM4NTYxMTM0NjAyMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a777bda875ae6dd36386f949f94c18067fc09cf88f66053314a1f09d2dd4c434 |
| hovercard-subject-tag | pull_request:392618291 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/16892/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | PR Summary MouseEvent.key is just derived from the last key_press_event/key_release_event, so will be wrong e.g. if one presses a key while the canvas does not have focus, then move the mouse to th... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6d28624802c2f7d9500239dd6870ed7031b7353b |
| ui-target | canary-2 |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width