René's URL Explorer Experiment


Title: Fix check_figures_equal for tests that use its fixtures. by QuLogic · Pull Request #16800 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix check_figures_equal for tests that use its fixtures. by QuLogic · Pull Request #16800 · matplotlib/matplotlib

X Title: Fix check_figures_equal for tests that use its fixtures. by QuLogic · Pull Request #16800 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary When #16770 was merged, it interacted poorly with the last change to check_figures_equal, due to the new arguments. This should work on tests both with and without any of those fixtures...

X Description: PR Summary When #16770 was merged, it interacted poorly with the last change to check_figures_equal, due to the new arguments. This should work on tests both with and without any of those fixtures...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/16800

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:a604fa9a-eba4-3918-b80d-96602affd49a
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC616:141904:2377402:2ED3F20:6A51FEA4
html-safe-nonce3cf3d4755b92d2c16cfc1eb06a33ed3c7963279e5ac5af4ec914944ea4de4621
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjE2OjE0MTkwNDoyMzc3NDAyOjJFRDNGMjA6NkE1MUZFQTQiLCJ2aXNpdG9yX2lkIjoiNzk3NDU1OTkwODc3MDIxNzYzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb6e37c78b790c8bbd2d1651b798d85d67939681bae721427022d0255d224048d
hovercard-subject-tagpull_request:389577543
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/16800/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/f689c17ed5dbc11a627c473e0ee4ff8a3d77264951396a470afb736678403e86/matplotlib/matplotlib/pull/16800
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f689c17ed5dbc11a627c473e0ee4ff8a3d77264951396a470afb736678403e86/matplotlib/matplotlib/pull/16800
og:image:altPR Summary When #16770 was merged, it interacted poorly with the last change to check_figures_equal, due to the new arguments. This should work on tests both with and without any of those fixtures...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameQuLogic
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/16800#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16800
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16800
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/16800
Reloadhttps://github.com/matplotlib/matplotlib/pull/16800
Reloadhttps://github.com/matplotlib/matplotlib/pull/16800
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16800
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16800
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
QuLogic:checkfigeqhttps://github.com/QuLogic/matplotlib/tree/checkfigeq
Conversationhttps://github.com/matplotlib/matplotlib/pull/16800
Commits1 (1)https://github.com/matplotlib/matplotlib/pull/16800/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/16800/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/16800/files
Fix check_figures_equal for tests that use its fixtures.https://github.com/matplotlib/matplotlib/pull/16800#top
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
QuLogic:checkfigeqhttps://github.com/QuLogic/matplotlib/tree/checkfigeq
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Mar 17, 2020https://github.com/matplotlib/matplotlib/pull/16800#issue-582697950
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16800
#16770https://github.com/matplotlib/matplotlib/pull/16770
Flake 8http://flake8.pycqa.org/en/latest/
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16800
https://github.com/QuLogic
Fix check_figures_equal for tests that use its fixtures.https://github.com/matplotlib/matplotlib/pull/16800/commits/6340b34cd031764a71823fa135a6b887a06c610d
6340b34https://github.com/matplotlib/matplotlib/pull/16800/commits/6340b34cd031764a71823fa135a6b887a06c610d
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
topic: testing https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22
Mar 17, 2020https://github.com/matplotlib/matplotlib/pull/16800#event-3135524020
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
v3.2.1https://github.com/matplotlib/matplotlib/milestone/49
Mar 17, 2020https://github.com/matplotlib/matplotlib/pull/16800#event-3135524027
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Mar 17, 2020 https://github.com/matplotlib/matplotlib/pull/16800#pullrequestreview-375693694
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16800/files/6340b34cd031764a71823fa135a6b887a06c610d
tacaswellhttps://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/16800#pullrequestreview-375693694
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16800
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Mar 17, 2020 https://github.com/matplotlib/matplotlib/pull/16800#ref-pullrequest-582644130
Backport #15589 and #16693, fixes for check_figures_equal #16797 https://github.com/matplotlib/matplotlib/pull/16797
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
7540cddhttps://github.com/matplotlib/matplotlib/commit/7540cdde6d33ec05859968c11f0af87fe1565932
Mar 17, 2020https://github.com/matplotlib/matplotlib/pull/16800#event-3136311357
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
March 17, 2020 08:31https://github.com/matplotlib/matplotlib/pull/16800#event-3136311603
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Mar 17, 2020https://github.com/matplotlib/matplotlib/pull/16800#issuecomment-599943012
#16800https://github.com/matplotlib/matplotlib/pull/16800
suggest an improvementhttps://github.com/MeeseeksBox/MeeseeksDev
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16800
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Still Needs Manual Backport https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22
Mar 17, 2020https://github.com/matplotlib/matplotlib/pull/16800#event-3136313346
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Mar 17, 2020https://github.com/matplotlib/matplotlib/pull/16800#issuecomment-599943451
#16797https://github.com/matplotlib/matplotlib/pull/16797
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16800
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Still Needs Manual Backport https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Still%20Needs%20Manual%20Backport%22
Mar 17, 2020https://github.com/matplotlib/matplotlib/pull/16800#event-3136317268
weiji14https://github.com/weiji14
Sep 3, 2020 https://github.com/matplotlib/matplotlib/pull/16800#ref-commit-d3cab24
https://github.com/weiji14
Ensure that pytest can be used with check_figures_equalhttps://github.com/GenericMappingTools/pygmt/commit/d3cab2499a520fe14c519b844eb9366277305bca
d3cab24https://github.com/GenericMappingTools/pygmt/commit/d3cab2499a520fe14c519b844eb9366277305bca
matplotlib/matplotlib#16800https://github.com/matplotlib/matplotlib/pull/16800
weiji14https://github.com/weiji14
Sep 3, 2020 https://github.com/matplotlib/matplotlib/pull/16800#ref-commit-3e0d3fb
https://github.com/weiji14
Ensure pytest fixtures can be used with check_figures_equal decoratorhttps://github.com/GenericMappingTools/pygmt/commit/3e0d3fb1d7685f8b23775860636900b4e10e5c0f
3e0d3fbhttps://github.com/GenericMappingTools/pygmt/commit/3e0d3fb1d7685f8b23775860636900b4e10e5c0f
matplotlib/matplotlib#16800https://github.com/matplotlib/matplotlib/pull/16800
https://github.com/weiji14
weiji14https://github.com/weiji14
Sep 3, 2020 https://github.com/matplotlib/matplotlib/pull/16800#ref-pullrequest-673956995
Add testing.check_figures_equal to avoid storing baseline images GenericMappingTools/pygmt#555 https://github.com/GenericMappingTools/pygmt/pull/555
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16800
https://github.com/tacaswell
tacaswell https://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/16800/files/6340b34cd031764a71823fa135a6b887a06c610d
topic: testing https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22
v3.2.1 https://github.com/matplotlib/matplotlib/milestone/49
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16800
https://github.com/QuLogic
https://github.com/tacaswell
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.