Title: Pad Axes3D.plot_surface inputs to allow for vectorized processing by apaszke · Pull Request #16699 · matplotlib/matplotlib · GitHub
Open Graph Title: Pad Axes3D.plot_surface inputs to allow for vectorized processing by apaszke · Pull Request #16699 · matplotlib/matplotlib
X Title: Pad Axes3D.plot_surface inputs to allow for vectorized processing by apaszke · Pull Request #16699 · matplotlib/matplotlib
Description: PR Summary As suggested by @anntzer, inputs which normally cannot be processed by the vectorized patch extraction routines from #16675 can be padded. This works out quite nicely and should extend the speedups I've been working on to all kinds of surface plots. I'm not 100% sure if I'm handling the face colors correctly, mostly because I cannot find enough documentation to fully understand how to work with this argument, and I also don't think that any of the tests actually uses it. It would be great if someone could tell me how to correctly set up such a test so that I can make sure that I haven't messed it up. Note that I needed to update one figure, because this patch does change the values of the surface normals for padded faces. This is because normal vectors are currently approximated by taking vertices with indices 0, n//3, 2*n//3 (for n being the number of vertices on the boundary of this face), and so padding can obviously affect those choices. The color differences are however barely noticeable, and it's an approximation anyway, so I don't think it should be a blocking issue. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: PR Summary As suggested by @anntzer, inputs which normally cannot be processed by the vectorized patch extraction routines from #16675 can be padded. This works out quite nicely and should extend t...
X Description: PR Summary As suggested by @anntzer, inputs which normally cannot be processed by the vectorized patch extraction routines from #16675 can be padded. This works out quite nicely and should extend t...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/16699
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:41626b2e-92ca-de20-62c5-d6c39ff42acb |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | A8DA:C92EC:1585AC0:1CB498A:6A52B358 |
| html-safe-nonce | 9aba4a5541973f3c83a32d62bb350bb7d6d010025da8ae9d9504838accca19aa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOERBOkM5MkVDOjE1ODVBQzA6MUNCNDk4QTo2QTUyQjM1OCIsInZpc2l0b3JfaWQiOiI2MTYxNzg4OTI0Nzc3OTAyOTM2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 7ec3a539e18e551ce9615601bf6c0b1c93886a0827c2fe0ce5ad51ad429bf95e |
| hovercard-subject-tag | pull_request:384825893 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/16699/files |
| twitter:image | https://avatars.githubusercontent.com/u/4583066?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/4583066?s=400&v=4 |
| og:image:alt | PR Summary As suggested by @anntzer, inputs which normally cannot be processed by the vectorized patch extraction routines from #16675 can be padded. This works out quite nicely and should extend t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width
