René's URL Explorer Experiment


Title: Store vertices as (masked) arrays in Poly3DCollection by apaszke · Pull Request #16688 · matplotlib/matplotlib · GitHub

Open Graph Title: Store vertices as (masked) arrays in Poly3DCollection by apaszke · Pull Request #16688 · matplotlib/matplotlib

X Title: Store vertices as (masked) arrays in Poly3DCollection by apaszke · Pull Request #16688 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary This removes a bunch of very expensive list comprehensions, dropping rendering times by half for some 3D surface plots. Runtime of the following code drops from 16s to 10s after #16675, ...

X Description: PR Summary This removes a bunch of very expensive list comprehensions, dropping rendering times by half for some 3D surface plots. Runtime of the following code drops from 16s to 10s after #16675, ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/16688

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b18f0107-7f47-318b-9e2c-d1b93868b9e6
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idAEBE:1C6AF8:630520:65D3F8:6A51A602
html-safe-nonce9ada77ae416c8c2689acaf7aafb86632f3c1b0502b9632ed1c755ee048386422
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUJFOjFDNkFGODo2MzA1MjA6NjVEM0Y4OjZBNTFBNjAyIiwidmlzaXRvcl9pZCI6IjY5NTc0MjEzMjEzMjUyMjU0NzQiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ==
visitor-hmac06dc4e526f84f63628b2296a543d3bfffb930b98bf232170b1dbaf8e7c59e544
hovercard-subject-tagpull_request:384496886
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/16688/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/d0ac7a49c8de54981703cf072210bd3be8efedcdc203f09ca5f4d13963cc5b30/matplotlib/matplotlib/pull/16688
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d0ac7a49c8de54981703cf072210bd3be8efedcdc203f09ca5f4d13963cc5b30/matplotlib/matplotlib/pull/16688
og:image:altPR Summary This removes a bunch of very expensive list comprehensions, dropping rendering times by half for some 3D surface plots. Runtime of the following code drops from 16s to 10s after #16675, ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameapaszke
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/16688#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16688
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16688
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/16688
Reloadhttps://github.com/matplotlib/matplotlib/pull/16688
Reloadhttps://github.com/matplotlib/matplotlib/pull/16688
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
apaszkehttps://github.com/apaszke
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
apaszke:vectorize_3d_projectionhttps://github.com/apaszke/matplotlib/tree/vectorize_3d_projection
Conversationhttps://github.com/matplotlib/matplotlib/pull/16688
Commits4 (4)https://github.com/matplotlib/matplotlib/pull/16688/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/16688/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/16688/files
Store vertices as (masked) arrays in Poly3DCollectionhttps://github.com/matplotlib/matplotlib/pull/16688#top
apaszkehttps://github.com/apaszke
matplotlib:mainhttps://github.com/matplotlib/matplotlib/tree/main
apaszke:vectorize_3d_projectionhttps://github.com/apaszke/matplotlib/tree/vectorize_3d_projection
https://github.com/apaszke
apaszkehttps://github.com/apaszke
Mar 5, 2020https://github.com/matplotlib/matplotlib/pull/16688#issue-576526334
#16675https://github.com/matplotlib/matplotlib/pull/16675
#16675https://github.com/matplotlib/matplotlib/pull/16675
Flake 8http://flake8.pycqa.org/en/latest/
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/apaszke
apaszkehttps://github.com/apaszke
Mar 5, 2020 https://github.com/matplotlib/matplotlib/pull/16688#ref-pullrequest-576354698
Optimize Poly3DCollection.get_vector for ndarray arguments #16680 https://github.com/matplotlib/matplotlib/pull/16680
https://github.com/anntzer
anntzerhttps://github.com/anntzer
topic: mplot3d https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20mplot3d%22
Mar 5, 2020https://github.com/matplotlib/matplotlib/pull/16688#event-3102960490
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Mar 5, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-369933428
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/proj3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-e30069a1daedc94cd16421b0842e7ef3e42bd2d2702334472e96d91645a2ac79
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Vectorize patch extraction in Axes3D.plot_surface #16675 https://github.com/matplotlib/matplotlib/pull/16675
Add a fast path for NumPy arrays to Collection.set_verts #16689 https://github.com/matplotlib/matplotlib/pull/16689
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-372629183
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-372632090
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/proj3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-e30069a1daedc94cd16421b0842e7ef3e42bd2d2702334472e96d91645a2ac79
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-372632927
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-372633615
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-372661225
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/proj3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-e30069a1daedc94cd16421b0842e7ef3e42bd2d2702334472e96d91645a2ac79
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r390895706
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 11, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r390899849
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r390901259
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 11, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r390907482
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r390911745
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r391027555
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
numpy/numpy#15742https://github.com/numpy/numpy/issues/15742
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 11, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r391037364
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r391040885
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 11, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r391173195
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 21, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396024378
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-372663136
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/proj3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-e30069a1daedc94cd16421b0842e7ef3e42bd2d2702334472e96d91645a2ac79
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-372665460
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 11, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-372670428
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Mar 13, 2020 https://github.com/matplotlib/matplotlib/pull/16688#ref-pullrequest-576937962
Pad Axes3D.plot_surface inputs to allow for vectorized processing #16699 https://github.com/matplotlib/matplotlib/pull/16699
https://github.com/apaszke
apaszkehttps://github.com/apaszke
Mar 20, 2020 https://github.com/matplotlib/matplotlib/pull/16688#ref-issue-575569099
Speeding up Axes3D.plot_surface 4-8x #16659 https://github.com/matplotlib/matplotlib/issues/16659
https://github.com/apaszke
apaszkehttps://github.com/apaszke
Mar 21, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-602095327
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Mar 21, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-378948138
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/apaszke
apaszkehttps://github.com/apaszke
force-pushedhttps://github.com/matplotlib/matplotlib/compare/872818be86f22e88d9122e7d0721794a9706076a..fbee126687443dd22b8a325798691d68183b24a8
872818bhttps://github.com/matplotlib/matplotlib/commit/872818be86f22e88d9122e7d0721794a9706076a
fbee126https://github.com/matplotlib/matplotlib/commit/fbee126687443dd22b8a325798691d68183b24a8
Compare https://github.com/matplotlib/matplotlib/compare/872818be86f22e88d9122e7d0721794a9706076a..fbee126687443dd22b8a325798691d68183b24a8
March 22, 2020 12:31https://github.com/matplotlib/matplotlib/pull/16688#event-3152619464
https://github.com/apaszke
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-602192695
@eric-wieserhttps://github.com/eric-wieser
@timhoffmhttps://github.com/timhoffm
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-379001001
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396088970
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396089725
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396090437
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396090763
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-379001040
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396089034
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396089817
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-379001524
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396089634
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396090909
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396091130
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396091250
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396091803
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396107093
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-379002112
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/proj3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-e30069a1daedc94cd16421b0842e7ef3e42bd2d2702334472e96d91645a2ac79
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-602237315
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/apaszke
apaszkehttps://github.com/apaszke
force-pushedhttps://github.com/matplotlib/matplotlib/compare/41f36ac99249268295ded1dd29d4cc77db20fcd3..1e0808474156117faafd96d5dd2197261b4f1680
41f36achttps://github.com/matplotlib/matplotlib/commit/41f36ac99249268295ded1dd29d4cc77db20fcd3
1e08084https://github.com/matplotlib/matplotlib/commit/1e0808474156117faafd96d5dd2197261b4f1680
Compare https://github.com/matplotlib/matplotlib/compare/41f36ac99249268295ded1dd29d4cc77db20fcd3..1e0808474156117faafd96d5dd2197261b4f1680
March 22, 2020 17:24https://github.com/matplotlib/matplotlib/pull/16688#event-3152884795
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-379028540
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396119793
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396125758
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396126119
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396126268
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396126352
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396126490
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/apaszke
Store vertices as (masked) arrays in Poly3DCollectionhttps://github.com/matplotlib/matplotlib/pull/16688/commits/8633bbd22d2be5581baec6ce221c892f26a1572b
8633bbdhttps://github.com/matplotlib/matplotlib/pull/16688/commits/8633bbd22d2be5581baec6ce221c892f26a1572b
https://github.com/apaszke
apaszkehttps://github.com/apaszke
force-pushedhttps://github.com/matplotlib/matplotlib/compare/1e0808474156117faafd96d5dd2197261b4f1680..8633bbd22d2be5581baec6ce221c892f26a1572b
1e08084https://github.com/matplotlib/matplotlib/commit/1e0808474156117faafd96d5dd2197261b4f1680
8633bbdhttps://github.com/matplotlib/matplotlib/commit/8633bbd22d2be5581baec6ce221c892f26a1572b
Compare https://github.com/matplotlib/matplotlib/compare/1e0808474156117faafd96d5dd2197261b4f1680..8633bbd22d2be5581baec6ce221c892f26a1572b
March 22, 2020 18:35https://github.com/matplotlib/matplotlib/pull/16688#event-3152948890
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-602255180
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/apaszke
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-602259500
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
This is the reduction.https://github.com/matplotlib/matplotlib/pull/16688/files#diff-fc54f86f287bf203dfa9e78102e2678bR684
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-602277841
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/apaszke
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-602299366
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/apaszke
apaszkehttps://github.com/apaszke
Mar 22, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-602299536
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-602301474
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/apaszke
Don't store faces as masked arrayshttps://github.com/matplotlib/matplotlib/pull/16688/commits/06105a177458bc02e1467266a30cdd2d565633d4
06105a1https://github.com/matplotlib/matplotlib/pull/16688/commits/06105a177458bc02e1467266a30cdd2d565633d4
https://github.com/apaszke
apaszkehttps://github.com/apaszke
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-602567982
@eric-wieserhttps://github.com/eric-wieser
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 23, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-379397440
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files/06105a177458bc02e1467266a30cdd2d565633d4
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files/06105a177458bc02e1467266a30cdd2d565633d4#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
eric-wieserhttps://github.com/eric-wieser
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396426399
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396434715
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396566550
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396602863
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396608378
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396617504
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
eric-wieserhttps://github.com/eric-wieser
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396650761
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396653802
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 23, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-379397762
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files/06105a177458bc02e1467266a30cdd2d565633d4
lib/mpl_toolkits/mplot3d/proj3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files/06105a177458bc02e1467266a30cdd2d565633d4#diff-e30069a1daedc94cd16421b0842e7ef3e42bd2d2702334472e96d91645a2ac79
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
apaszkehttps://github.com/apaszke
March 23, 2020 14:05https://github.com/matplotlib/matplotlib/pull/16688#commits-pushed-076bfcb
https://github.com/apaszke
https://github.com/eric-wieser
Update lib/mpl_toolkits/mplot3d/proj3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/commits/076bfcbef20276d7cdd745de565d3b1208504dd9
076bfcbhttps://github.com/matplotlib/matplotlib/pull/16688/commits/076bfcbef20276d7cdd745de565d3b1208504dd9
https://github.com/apaszke
Ignore floating point errorshttps://github.com/matplotlib/matplotlib/pull/16688/commits/301b6fe59d311a942a4fdb5da55dbacf5a4d70a6
301b6fehttps://github.com/matplotlib/matplotlib/pull/16688/commits/301b6fe59d311a942a4fdb5da55dbacf5a4d70a6
https://github.com/eric-wieser
eric-wieserhttps://github.com/eric-wieser
Mar 23, 2020 https://github.com/matplotlib/matplotlib/pull/16688#pullrequestreview-379631986
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16688/files/301b6fe59d311a942a4fdb5da55dbacf5a4d70a6
lib/mpl_toolkits/mplot3d/art3d.pyhttps://github.com/matplotlib/matplotlib/pull/16688/files/301b6fe59d311a942a4fdb5da55dbacf5a4d70a6#diff-21a889bd7f4e011757170a6a94b732dc543121b7580141ea5f9e82132c5f1c9f
eric-wieserhttps://github.com/eric-wieser
Mar 23, 2020https://github.com/matplotlib/matplotlib/pull/16688#discussion_r396609045
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
timhoffmhttps://github.com/timhoffm
Jul 12, 2023https://github.com/matplotlib/matplotlib/pull/16688#discussion_r1260766900
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Aug 7, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-670314332
#11577https://github.com/matplotlib/matplotlib/pull/11577
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Sep 9, 2020https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-689214268
@apaszkehttps://github.com/apaszke
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
status: needs rebase https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20rebase%22
status: orphaned PR https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20orphaned%20PR%22
Nov 1, 2020https://github.com/matplotlib/matplotlib/pull/16688#event-3945745864
https://github.com/jklymak
jklymakhttps://github.com/jklymak
April 23, 2021 16:43https://github.com/matplotlib/matplotlib/pull/16688#event-4637895509
https://github.com/ccaprani
ccapranihttps://github.com/ccaprani
Sep 24, 2021 https://github.com/matplotlib/matplotlib/pull/16688#ref-issue-1006086647
[Bug]: Surface draws incorrectly after set_verts on Poly3DCollection #21163 https://github.com/matplotlib/matplotlib/issues/21163
https://github.com/scottshambaugh
scottshambaughhttps://github.com/scottshambaugh
Jan 3, 2025 https://github.com/matplotlib/matplotlib/pull/16688#ref-pullrequest-2766980212
3D plotting performance improvements #29397 https://github.com/matplotlib/matplotlib/pull/29397
https://github.com/scottshambaugh
scottshambaughhttps://github.com/scottshambaugh
Jan 7, 2025https://github.com/matplotlib/matplotlib/pull/16688#issuecomment-2576064931
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
#29397https://github.com/matplotlib/matplotlib/pull/29397
@apaszkehttps://github.com/apaszke
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/scottshambaugh
scottshambaughhttps://github.com/scottshambaugh
Jan 7, 2025https://github.com/matplotlib/matplotlib/pull/16688#event-15843362176
https://github.com/scottshambaugh
scottshambaughhttps://github.com/scottshambaugh
status: superseded https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20superseded%22
Jan 7, 2025https://github.com/matplotlib/matplotlib/pull/16688#event-15843364178
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16688
https://github.com/anntzer
anntzer https://github.com/anntzer
https://github.com/matplotlib/matplotlib/pull/16688/files/dc357f66fb80a784870c00a45c19a32729ee9aa0
https://github.com/timhoffm
timhoffm https://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/16688/files/301b6fe59d311a942a4fdb5da55dbacf5a4d70a6
https://github.com/eric-wieser
eric-wieser https://github.com/eric-wieser
https://github.com/matplotlib/matplotlib/pull/16688/files/301b6fe59d311a942a4fdb5da55dbacf5a4d70a6
status: needs rebase https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20rebase%22
status: orphaned PR https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20orphaned%20PR%22
status: superseded https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20superseded%22
topic: mplot3d https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20mplot3d%22
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16688
https://github.com/apaszke
https://github.com/timhoffm
https://github.com/eric-wieser
https://github.com/QuLogic
https://github.com/scottshambaugh
https://github.com/anntzer
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.