Title: Avoid floating point rounding causing bezier.get_parallels to fail by ksunden · Pull Request #16682 · matplotlib/matplotlib · GitHub
Open Graph Title: Avoid floating point rounding causing bezier.get_parallels to fail by ksunden · Pull Request #16682 · matplotlib/matplotlib
X Title: Avoid floating point rounding causing bezier.get_parallels to fail by ksunden · Pull Request #16682 · matplotlib/matplotlib
Description: PR Summary Avoids failing due to a very particular floating point cutoff mismatch when determining if two lines are parallel via two different methods. This is the diff provided by @anntzer here Closes #12820 PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way I am unclear what, if any, tests are expected for this diff, as discussed in #12820. Causing this to happen on an actual figure requires a rather unlucky set of very specific layout and annotation placement that is difficult to replicate. A simple test of get_parallels is possible, but probably not particularly helpful. My understanding is that since this is only changing floating point cutoff behaviour, this is not considered an API change, therefore I did not write a release note. If I am mistaken, please let me know.
Open Graph Description: PR Summary Avoids failing due to a very particular floating point cutoff mismatch when determining if two lines are parallel via two different methods. This is the diff provided by @anntzer here Cl...
X Description: PR Summary Avoids failing due to a very particular floating point cutoff mismatch when determining if two lines are parallel via two different methods. This is the diff provided by @anntzer here Cl...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/16682
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a42f8a4a-fab7-0dfa-41a3-9b55a0f2a0b5 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | EE36:1B675D:1C4B2E6:2675AC5:6A5377EB |
| html-safe-nonce | a3d9d5f1765c20629d55ff5f4bd9c8020efc195f4be96ff1785327edb2f88cf5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRTM2OjFCNjc1RDoxQzRCMkU2OjI2NzVBQzU6NkE1Mzc3RUIiLCJ2aXNpdG9yX2lkIjoiMzMxNjMxMDk4MTY1NTg4NTgwMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 013f3bd946c0683541265d0d85e87b82fb714f326a6889754c5529456f8a7cfd |
| hovercard-subject-tag | pull_request:384370881 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/16682/files |
| twitter:image | https://avatars.githubusercontent.com/u/2501846?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/2501846?s=400&v=4 |
| og:image:alt | PR Summary Avoids failing due to a very particular floating point cutoff mismatch when determining if two lines are parallel via two different methods. This is the diff provided by @anntzer here Cl... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width