Title: Catch shadowed imports in style checks. by anntzer · Pull Request #16193 · matplotlib/matplotlib · GitHub
Open Graph Title: Catch shadowed imports in style checks. by anntzer · Pull Request #16193 · matplotlib/matplotlib
X Title: Catch shadowed imports in style checks. by anntzer · Pull Request #16193 · matplotlib/matplotlib
Description: matplotlib.rc_context is redefined in pyplot with a wrapper function so that it shows up in the docs (like setp, getp and a few others). spines imports cbook twice. The imports of category and dates in _axes.py don't need to be assigned to "_" (they're not assigned to a global name to start with anyways). Would have caught #16189 (comment). PR Summary PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: matplotlib.rc_context is redefined in pyplot with a wrapper function so that it shows up in the docs (like setp, getp and a few others). spines imports cbook twice. The imports of category and date...
X Description: matplotlib.rc_context is redefined in pyplot with a wrapper function so that it shows up in the docs (like setp, getp and a few others). spines imports cbook twice. The imports of category and date...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/16193
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:59789cfd-781a-26c3-f770-7f5f3d7cff10 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BAC8:2BB83B:DC133F:12A4D83:6A5561C2 |
| html-safe-nonce | fc36be96381937eaa52df2cede968f00187eb4ba02748a27bcfa14cd75e5e595 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQUM4OjJCQjgzQjpEQzEzM0Y6MTJBNEQ4Mzo2QTU1NjFDMiIsInZpc2l0b3JfaWQiOiIzMDI2Nzg0NTg5NDA4NzUyMDIiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 66d1822f29d6e38e5ce0e73fc34efc1e25e675c716f646e4633fb6224b8eb631 |
| hovercard-subject-tag | pull_request:361829373 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/16193/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | matplotlib.rc_context is redefined in pyplot with a wrapper function so that it shows up in the docs (like setp, getp and a few others). spines imports cbook twice. The imports of category and date... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8201d0b7bc32164c4662de52242e463a356df543 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width