René's URL Explorer Experiment


Title: MNT: set default canvas when un-pickling by tacaswell · Pull Request #16189 · matplotlib/matplotlib · GitHub

Open Graph Title: MNT: set default canvas when un-pickling by tacaswell · Pull Request #16189 · matplotlib/matplotlib

X Title: MNT: set default canvas when un-pickling by tacaswell · Pull Request #16189 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: In 380c531 / #12450 we set the default canvas on Figure __init__ to FigureCanvasBase but were still setting it to None in __setstate__. Found this while investigating #8291. After inline displays i...

X Description: In 380c531 / #12450 we set the default canvas on Figure __init__ to FigureCanvasBase but were still setting it to None in __setstate__. Found this while investigating #8291. After inline displays i...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/16189

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:fbb2c92e-9219-9f8f-517e-cf9c4d33354f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idDBA0:2ECA08:1866979:2140ACC:6A53E778
html-safe-nonce59d32ccc89a38aae4db2ff759704e7881fd973be1f2c0685ae53a356c4d9ce68
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQkEwOjJFQ0EwODoxODY2OTc5OjIxNDBBQ0M6NkE1M0U3NzgiLCJ2aXNpdG9yX2lkIjoiMjc5NTA0NTEwMzE4MTQ5MDA0MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac3bde72c38c2f4e0d5a90039b658403cf2a17065cfcd4d1808774991485d073d6
hovercard-subject-tagpull_request:361797688
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/16189/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b45ef5de545925ccb0ff6a5240eb55f5783a5b01be8476f05200262b4d183370/matplotlib/matplotlib/pull/16189
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b45ef5de545925ccb0ff6a5240eb55f5783a5b01be8476f05200262b4d183370/matplotlib/matplotlib/pull/16189
og:image:altIn 380c531 / #12450 we set the default canvas on Figure __init__ to FigureCanvasBase but were still setting it to None in __setstate__. Found this while investigating #8291. After inline displays i...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametacaswell
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/16189#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16189
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16189
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/16189
Reloadhttps://github.com/matplotlib/matplotlib/pull/16189
Reloadhttps://github.com/matplotlib/matplotlib/pull/16189
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16189
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16189
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
efiringhttps://github.com/efiring
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tacaswell:fix_unpickled_canvashttps://github.com/tacaswell/matplotlib/tree/fix_unpickled_canvas
Conversationhttps://github.com/matplotlib/matplotlib/pull/16189
Commits1 (1)https://github.com/matplotlib/matplotlib/pull/16189/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/16189/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/16189/files
MNT: set default canvas when un-picklinghttps://github.com/matplotlib/matplotlib/pull/16189#top
efiringhttps://github.com/efiring
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
tacaswell:fix_unpickled_canvashttps://github.com/tacaswell/matplotlib/tree/fix_unpickled_canvas
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jan 12, 2020https://github.com/matplotlib/matplotlib/pull/16189#issue-548525850
380c531https://github.com/matplotlib/matplotlib/commit/380c531d58dd0dacbd303f06f2c2d3711eee1ff4
#12450https://github.com/matplotlib/matplotlib/pull/12450
#8291https://github.com/matplotlib/matplotlib/issues/8291
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16189
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
v3.2.0https://github.com/matplotlib/matplotlib/milestone/43
Jan 12, 2020https://github.com/matplotlib/matplotlib/pull/16189#event-2941037819
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
anntzerhttps://github.com/anntzer
January 12, 2020 05:56https://github.com/matplotlib/matplotlib/pull/16189#event-2941037974
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jan 12, 2020 https://github.com/matplotlib/matplotlib/pull/16189#ref-pullrequest-548528945
MNT: ensure we can show un-pickled figures ipython/ipython#12085 https://github.com/ipython/ipython/pull/12085
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jan 12, 2020 https://github.com/matplotlib/matplotlib/pull/16189#pullrequestreview-341570752
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16189/files
lib/matplotlib/tests/test_pickle.pyhttps://github.com/matplotlib/matplotlib/pull/16189/files#diff-1027bd6462841c22490c64a3c4cd10e5e260f11145a7c23f0776926113727e86
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16189
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jan 12, 2020 https://github.com/matplotlib/matplotlib/pull/16189#pullrequestreview-341570837
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16189/files
lib/matplotlib/figure.pyhttps://github.com/matplotlib/matplotlib/pull/16189/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
anntzerhttps://github.com/anntzer
Jan 12, 2020https://github.com/matplotlib/matplotlib/pull/16189#discussion_r365578145
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16189
tacaswellhttps://github.com/tacaswell
Jan 13, 2020https://github.com/matplotlib/matplotlib/pull/16189#discussion_r365646949
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16189
anntzerhttps://github.com/anntzer
Jan 13, 2020https://github.com/matplotlib/matplotlib/pull/16189#discussion_r365656004
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16189
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jan 12, 2020 https://github.com/matplotlib/matplotlib/pull/16189#pullrequestreview-341570850
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16189/files
anntzerhttps://github.com/anntzer
https://github.com/matplotlib/matplotlib/pull/16189#pullrequestreview-341570850
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16189
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jan 12, 2020 https://github.com/matplotlib/matplotlib/pull/16189#ref-pullrequest-548569562
Catch shadowed imports in style checks. #16193 https://github.com/matplotlib/matplotlib/pull/16193
https://github.com/tacaswell
MNT: set default canvas when un-picklinghttps://github.com/matplotlib/matplotlib/pull/16189/commits/d20ea496fb7682cd24e9c94eb01c3c086c06b249
d20ea49https://github.com/matplotlib/matplotlib/pull/16189/commits/d20ea496fb7682cd24e9c94eb01c3c086c06b249
380c531https://github.com/tacaswell/matplotlib/commit/380c531d58dd0dacbd303f06f2c2d3711eee1ff4
matplotlib#12450https://github.com/matplotlib/matplotlib/pull/12450
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
force-pushedhttps://github.com/matplotlib/matplotlib/compare/6c64ea73266793391edde8d6dc73aac99ddadf1c..d20ea496fb7682cd24e9c94eb01c3c086c06b249
6c64ea7https://github.com/matplotlib/matplotlib/commit/6c64ea73266793391edde8d6dc73aac99ddadf1c
d20ea49https://github.com/matplotlib/matplotlib/commit/d20ea496fb7682cd24e9c94eb01c3c086c06b249
Compare https://github.com/matplotlib/matplotlib/compare/6c64ea73266793391edde8d6dc73aac99ddadf1c..d20ea496fb7682cd24e9c94eb01c3c086c06b249
January 13, 2020 05:01https://github.com/matplotlib/matplotlib/pull/16189#event-2941871355
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jan 13, 2020 https://github.com/matplotlib/matplotlib/pull/16189#pullrequestreview-342131657
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16189/files/d20ea496fb7682cd24e9c94eb01c3c086c06b249
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Jan 13, 2020 https://github.com/matplotlib/matplotlib/pull/16189#pullrequestreview-342133210
View reviewed changes https://github.com/matplotlib/matplotlib/pull/16189/files/d20ea496fb7682cd24e9c94eb01c3c086c06b249
https://github.com/efiring
efiringhttps://github.com/efiring
af49c1bhttps://github.com/matplotlib/matplotlib/commit/af49c1bb2c3d831e72194601d7100f29a6e2f0fa
Jan 13, 2020https://github.com/matplotlib/matplotlib/pull/16189#event-2944737895
meeseeksmachinehttps://github.com/meeseeksmachine
Jan 13, 2020 https://github.com/matplotlib/matplotlib/pull/16189#ref-commit-d497f85
https://github.com/efiring
https://github.com/meeseeksmachine
Backport PRhttps://github.com/meeseeksmachine/matplotlib/commit/d497f85283f4b91a6fe4b47d4a84f70f54bb3bd7
matplotlib#16189https://github.com/matplotlib/matplotlib/pull/16189
: MNT: set default canvas when un-picklinghttps://github.com/meeseeksmachine/matplotlib/commit/d497f85283f4b91a6fe4b47d4a84f70f54bb3bd7
d497f85https://github.com/meeseeksmachine/matplotlib/commit/d497f85283f4b91a6fe4b47d4a84f70f54bb3bd7
https://github.com/meeseeksmachine
meeseeksmachinehttps://github.com/meeseeksmachine
Jan 13, 2020 https://github.com/matplotlib/matplotlib/pull/16189#ref-pullrequest-549177360
Backport PR #16189 on branch v3.2.x (MNT: set default canvas when un-pickling) #16207 https://github.com/matplotlib/matplotlib/pull/16207
timhoffmhttps://github.com/timhoffm
Jan 13, 2020 https://github.com/matplotlib/matplotlib/pull/16189#ref-commit-9091975
https://github.com/timhoffm
Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/90919758108519fbd9c2167d38b9dd6e7844c5bd
#16207https://github.com/matplotlib/matplotlib/pull/16207
from meeseeksmachine/auto-backport-of-pr-16…https://github.com/matplotlib/matplotlib/commit/90919758108519fbd9c2167d38b9dd6e7844c5bd
9091975https://github.com/matplotlib/matplotlib/commit/90919758108519fbd9c2167d38b9dd6e7844c5bd
#16189https://github.com/matplotlib/matplotlib/pull/16189
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
January 13, 2020 22:40https://github.com/matplotlib/matplotlib/pull/16189#event-2945028952
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Jan 20, 2020 https://github.com/matplotlib/matplotlib/pull/16189#ref-issue-214075958
Unable to pickle.load(fig) with mpl in jupyter notebook #8291 https://github.com/matplotlib/matplotlib/issues/8291
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F16189
https://github.com/anntzer
anntzer https://github.com/anntzer
https://github.com/matplotlib/matplotlib/pull/16189/files/d20ea496fb7682cd24e9c94eb01c3c086c06b249
https://github.com/timhoffm
timhoffm https://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/16189/files/d20ea496fb7682cd24e9c94eb01c3c086c06b249
v3.2.0 https://github.com/matplotlib/matplotlib/milestone/43
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/16189
https://github.com/tacaswell
https://github.com/anntzer
https://github.com/timhoffm
https://github.com/efiring
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.