| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:69875bbd-e810-e00d-d691-885b1531b445 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8AC6:23E45A:10C6DB3:162024F:6A51A685 |
| html-safe-nonce | 9504979f83324e8264ebf0606824c2021dc2015c17c2fa41b5fa8f7b2e9b992d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QUM2OjIzRTQ1QToxMEM2REIzOjE2MjAyNEY6NkE1MUE2ODUiLCJ2aXNpdG9yX2lkIjoiNjA3NDk0MzA1ODI2MDEwODkzMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 268fb45d4710103cd54ca6086f0d2d571d1b3ca1fa6a03b6c75e0fd9c8628774 |
| hovercard-subject-tag | pull_request:335807821 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/15589/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/f64515c30c0cf709a44828d09486aa58d8b4c706f91cd02508400a6ac79a07b6/matplotlib/matplotlib/pull/15589 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f64515c30c0cf709a44828d09486aa58d8b4c706f91cd02508400a6ac79a07b6/matplotlib/matplotlib/pull/15589 |
| og:image:alt | PR Summary
fixes #15079. Closes figures after check_figures_equal has finished so that different tests don't overwrite each others' figures.
PR Checklist
Has Pytest style unit tests
Code... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | MarcoGorelli |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | canary-1 |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/15589#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F15589 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F15589 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/15589 |
| Reload | https://github.com/matplotlib/matplotlib/pull/15589 |
| Reload | https://github.com/matplotlib/matplotlib/pull/15589 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/15589 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/15589 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
409
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| dopplershift | https://github.com/dopplershift |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| MarcoGorelli:close-plots-in-check-figures-equal | https://github.com/MarcoGorelli/matplotlib/tree/close-plots-in-check-figures-equal |
| Conversation | https://github.com/matplotlib/matplotlib/pull/15589 |
| Commits1 (1) | https://github.com/matplotlib/matplotlib/pull/15589/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/15589/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/15589/files |
| Make sure that figures are closed when check_figures_equal finishes | https://github.com/matplotlib/matplotlib/pull/15589#top |
| dopplershift | https://github.com/dopplershift |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| MarcoGorelli:close-plots-in-check-figures-equal | https://github.com/MarcoGorelli/matplotlib/tree/close-plots-in-check-figures-equal |
|
| https://github.com/MarcoGorelli |
| MarcoGorelli | https://github.com/MarcoGorelli |
| Nov 2, 2019 | https://github.com/matplotlib/matplotlib/pull/15589#issue-516566158 |
| #15079 | https://github.com/matplotlib/matplotlib/issues/15079 |
| Flake 8 | http://flake8.pycqa.org/en/latest/ |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/15589 |
|
| https://github.com/MarcoGorelli |
| Make sure that figures are closed when check_figures_equal finishes | https://github.com/matplotlib/matplotlib/pull/15589/commits/75498742e93652112b0d43a89c98e984a39b6a7f |
| 7549874 | https://github.com/matplotlib/matplotlib/pull/15589/commits/75498742e93652112b0d43a89c98e984a39b6a7f |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Nov 2, 2019
| https://github.com/matplotlib/matplotlib/pull/15589#pullrequestreview-310767125 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/15589/files/75498742e93652112b0d43a89c98e984a39b6a7f |
| anntzer | https://github.com/anntzer |
| https://github.com/matplotlib/matplotlib/pull/15589#pullrequestreview-310767125 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/15589 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
topic: testing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22 |
| Nov 2, 2019 | https://github.com/matplotlib/matplotlib/pull/15589#event-2765180520 |
| https://github.com/dopplershift |
| dopplershift | https://github.com/dopplershift |
|
Nov 2, 2019
| https://github.com/matplotlib/matplotlib/pull/15589#pullrequestreview-310780594 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/15589/files/75498742e93652112b0d43a89c98e984a39b6a7f |
| https://github.com/dopplershift |
| dopplershift | https://github.com/dopplershift |
| 4ddf004 | https://github.com/matplotlib/matplotlib/commit/4ddf00401314461d6cb6eeddfb7b31794fd4123a |
| Nov 2, 2019 | https://github.com/matplotlib/matplotlib/pull/15589#event-2765418144 |
| https://github.com/MarcoGorelli |
| MarcoGorelli | https://github.com/MarcoGorelli |
| November 2, 2019 17:32 | https://github.com/matplotlib/matplotlib/pull/15589#event-2765418749 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| v3.3.0 | https://github.com/matplotlib/matplotlib/milestone/48 |
| Nov 2, 2019 | https://github.com/matplotlib/matplotlib/pull/15589#event-2765434229 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
mentored: hackathon
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22mentored%3A%20hackathon%22 |
| Nov 2, 2019 | https://github.com/matplotlib/matplotlib/pull/15589#event-2765631556 |
|
Backport #15589 and #16693, fixes for check_figures_equal
#16797
| https://github.com/matplotlib/matplotlib/pull/16797 |
|
TST: use pytest name in naming files for check_figures_equal
#16693
| https://github.com/matplotlib/matplotlib/pull/16693 |
| QuLogic | https://github.com/QuLogic |
|
Mar 17, 2020
| https://github.com/matplotlib/matplotlib/pull/15589#ref-commit-3ee24e5 |
|
| https://github.com/QuLogic |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/3ee24e5224ead612ea7eb555add2b707708082fb |
| #16797 | https://github.com/matplotlib/matplotlib/pull/16797 |
| from QuLogic/backport-checkfigeq | https://github.com/matplotlib/matplotlib/commit/3ee24e5224ead612ea7eb555add2b707708082fb |
| 3ee24e5 | https://github.com/matplotlib/matplotlib/commit/3ee24e5224ead612ea7eb555add2b707708082fb |
| #15589 | https://github.com/matplotlib/matplotlib/pull/15589 |
| #16693 | https://github.com/matplotlib/matplotlib/pull/16693 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F15589 |
|
| https://github.com/dopplershift |
|
dopplershift
| https://github.com/dopplershift |
|
| https://github.com/matplotlib/matplotlib/pull/15589/files/75498742e93652112b0d43a89c98e984a39b6a7f |
|
| https://github.com/anntzer |
|
anntzer
| https://github.com/anntzer |
|
| https://github.com/matplotlib/matplotlib/pull/15589/files/75498742e93652112b0d43a89c98e984a39b6a7f |
|
mentored: hackathon
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22mentored%3A%20hackathon%22 |
|
topic: testing
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22topic%3A%20testing%22 |
|
v3.3.0
| https://github.com/matplotlib/matplotlib/milestone/48 |
|
check_figures_equal decorator reuses figures if called multiple times inside a single test.
| https://github.com/matplotlib/matplotlib/issues/15079 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/15589 |
|
| https://github.com/MarcoGorelli |
|
| https://github.com/dopplershift |
|
| https://github.com/anntzer |
|
| https://github.com/tacaswell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |