Title: Don't assume transform is valid on access to matrix. by djdt · Pull Request #14840 · matplotlib/matplotlib · GitHub
Open Graph Title: Don't assume transform is valid on access to matrix. by djdt · Pull Request #14840 · matplotlib/matplotlib
X Title: Don't assume transform is valid on access to matrix. by djdt · Pull Request #14840 · matplotlib/matplotlib
Description: PR Summary Accessing the matrix of an Affine2D transform via get_matrix sets _invalid to 0. This can cause the transform returned by inverted() to be incorrect if the matrix is accessed between a transform and the call to inverted(). Another possible fix would be to check if invalid and set _inverted to None and _invalid to 0. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: PR Summary Accessing the matrix of an Affine2D transform via get_matrix sets _invalid to 0. This can cause the transform returned by inverted() to be incorrect if the matrix is accessed between a t...
X Description: PR Summary Accessing the matrix of an Affine2D transform via get_matrix sets _invalid to 0. This can cause the transform returned by inverted() to be incorrect if the matrix is accessed between a t...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/14840
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:a0d1f0b4-361a-ead6-97b1-c12cd5406aff |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DF4A:12F083:11CAC81:199FE57:6A58A589 |
| html-safe-nonce | 39a96eb2bdcb94b2b1422222528cee021e193e789753089c0047a26b11177395 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERjRBOjEyRjA4MzoxMUNBQzgxOjE5OUZFNTc6NkE1OEE1ODkiLCJ2aXNpdG9yX2lkIjoiMTA1MDcyNjE0NDAxNjk1MDY2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 136bd5ccb8735f79d06622433225118c18607b8e5f2b36ae83c67c116c8c6db9 |
| hovercard-subject-tag | pull_request:298776761 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/14840/files |
| twitter:image | https://avatars.githubusercontent.com/u/10266332?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/10266332?s=400&v=4 |
| og:image:alt | PR Summary Accessing the matrix of an Affine2D transform via get_matrix sets _invalid to 0. This can cause the transform returned by inverted() to be incorrect if the matrix is accessed between a t... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 5f2a0c7865178af3d91dd9f13b0cdfc3c73a2529c873d2780bb4c01271a57ec6 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8aae7b8d6caacacf5c66eaeb2702d8dc88d85b4a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width