Title: Remove redundant is_landscape kwarg from backend_ps helpers. by anntzer · Pull Request #14352 · matplotlib/matplotlib · GitHub
Open Graph Title: Remove redundant is_landscape kwarg from backend_ps helpers. by anntzer · Pull Request #14352 · matplotlib/matplotlib
X Title: Remove redundant is_landscape kwarg from backend_ps helpers. by anntzer · Pull Request #14352 · matplotlib/matplotlib
Description: The internal backend_ps _print_figure and _print_figure_tex helpers get passed both the orientation="portrait"/"landscape" and the is_landscape=True/False kwargs. Remove is_landscape and change orientation to be an enum. Also deprecate dryrun from _print_figure_tex (this should have happened at the same time as when it was deprecated from _print_figure (it's the same public API). Also remove unnecessary default parameters from _print_figure (these arguments are always passed positionally to the helper, and not present in _print_figure_tex). PR Summary PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: The internal backend_ps _print_figure and _print_figure_tex helpers get passed both the orientation="portrait"/"landscape" and the is_landscape=True/False kwargs. Remove is_land...
X Description: The internal backend_ps _print_figure and _print_figure_tex helpers get passed both the orientation="portrait"/"landscape" and the is_landscape=True/False kwargs...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/14352
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:88d390d4-b541-0b26-7c3c-e7ab64269b66 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 8912:19106:DA982F:12B460B:6A53AEE1 |
| html-safe-nonce | 68c18c251a988957a763a3ce5d68e0892d722d4f54bb1da1310bbdb24688aa00 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4OTEyOjE5MTA2OkRBOTgyRjoxMkI0NjBCOjZBNTNBRUUxIiwidmlzaXRvcl9pZCI6IjgyMTM1MDY2MDQ2NDcyOTY3MzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | b81f45115a6452ee84829c0e7c4224dc14a1c1b7390d8859d9ac883b58ab8e85 |
| hovercard-subject-tag | pull_request:282754398 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/14352/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | The internal backend_ps _print_figure and _print_figure_tex helpers get passed both the orientation="portrait"/"landscape" and the is_landscape=True/False kwargs. Remove is_land... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width