Title: Remove `asfileobj=False` from a bunch of examples loading sample_data. by anntzer · Pull Request #13621 · matplotlib/matplotlib · GitHub
Open Graph Title: Remove `asfileobj=False` from a bunch of examples loading sample_data. by anntzer · Pull Request #13621 · matplotlib/matplotlib
X Title: Remove `asfileobj=False` from a bunch of examples loading sample_data. by anntzer · Pull Request #13621 · matplotlib/matplotlib
Description: Using a file object works just fine. There are some more examples that use genfromtxt, but their conversion effectively needs numpy>=1.14 per https://github.com/numpy/numpy/blob/master/doc/release/1.14.0-notes.rst#encoding-argument-for-text-io-functions There are some more examples that load bivariate_normal.npy, but they have a bunch of duplicated code that could use some more refactor. PR Summary PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: Using a file object works just fine. There are some more examples that use genfromtxt, but their conversion effectively needs numpy>=1.14 per https://github.com/numpy/numpy/blob/master/doc/relea...
X Description: Using a file object works just fine. There are some more examples that use genfromtxt, but their conversion effectively needs numpy>=1.14 per https://github.com/numpy/numpy/blob/master/doc/r...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/13621
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:434582f8-9bf4-3f00-aff0-49fa4a4173be |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C2AA:17402E:418F3AF:5D419B3:6A550960 |
| html-safe-nonce | 39fe2630ab0d79f0a764d0470cc9818bd0a67a74e1be4dc6d061bffa86366e92 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMkFBOjE3NDAyRTo0MThGM0FGOjVENDE5QjM6NkE1NTA5NjAiLCJ2aXNpdG9yX2lkIjoiNzc4MjcxOTgzODY3MDM1ODg4MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | de4ff68cad5826d814248be39da4883727a10c8cebfd1cf6b4997b5ba4e6b15a |
| hovercard-subject-tag | pull_request:259292370 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/13621/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | Using a file object works just fine. There are some more examples that use genfromtxt, but their conversion effectively needs numpy>=1.14 per https://github.com/numpy/numpy/blob/master/doc/relea... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | eae2aab99907699a22d2c8449aa683ca74454fca87211b98f7c7b722086b2839 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6a35ab858be185cd86d12b93a43bccf34e8d8536 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width