Title: Simplify Text.get_usetex. by anntzer · Pull Request #13166 · matplotlib/matplotlib · GitHub
Open Graph Title: Simplify Text.get_usetex. by anntzer · Pull Request #13166 · matplotlib/matplotlib
X Title: Simplify Text.get_usetex. by anntzer · Pull Request #13166 · matplotlib/matplotlib
Description: Make the module-level _wrap_text a text method instead, and don't make it yield anything as it is modifying the text object in-place anyways. (This avoids having to wonder where other textobj attributes come from.) Removed this as I realized there's an even simpler way to handle it, but would be better on top of #12951. text._usetex is never None because set_usetex already replaces None by the rc value, so we don't need to additionally validate in the getter. Preliminary work towards fixing #13139 (comment) (#12951 would be needed too to avoid a rebase). PR Summary PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: Make the module-level _wrap_text a text method instead, and don't make it yield anything as it is modifying the text object in-place anyways. (This avoids having to wonder where other textobj a...
X Description: Make the module-level _wrap_text a text method instead, and don't make it yield anything as it is modifying the text object in-place anyways. (This avoids having to wonder where other texto...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/13166
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:fc62bf48-2a70-7507-0e98-1612613c976b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | DA5C:3102C2:13758B1:1A6EE12:6A545B37 |
| html-safe-nonce | 29f47adbf40903c3f3849202832a5684506513510d54ea163a4fbf200717808d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEQTVDOjMxMDJDMjoxMzc1OEIxOjFBNkVFMTI6NkE1NDVCMzciLCJ2aXNpdG9yX2lkIjoiNjQ3ODIwMzE0NjkwOTAxNDgzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | e4cd8cacf1bbed619c3ed25f9a654cac32ae0988a61c9bb7153449be6741d8cb |
| hovercard-subject-tag | pull_request:244226589 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/13166/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | Make the module-level _wrap_text a text method instead, and don't make it yield anything as it is modifying the text object in-place anyways. (This avoids having to wonder where other textobj a... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 6d28624802c2f7d9500239dd6870ed7031b7353b |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width