Title: Add shading to Axes3D.voxels, and enable it by default by eric-wieser · Pull Request #13123 · matplotlib/matplotlib · GitHub
Open Graph Title: Add shading to Axes3D.voxels, and enable it by default by eric-wieser · Pull Request #13123 · matplotlib/matplotlib
X Title: Add shading to Axes3D.voxels, and enable it by default by eric-wieser · Pull Request #13123 · matplotlib/matplotlib
Description: PR Summary The conclusion of my normals and shading work (#12792, #12136 ). The rich image diffs in the patch should show the effect. For a quick summary, here's what the output now looks like: PR Checklist Has Pytest style unit tests Do the existing ones count? Should I set shade=False on one of the existing tests, or parametrize them all on shaded vs not Code is Flake 8 compliant Awaiting CI New features are documented, with examples if plot related Do existing examples count? Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Is this major enough? Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way Not backward-incompatible
Open Graph Description: PR Summary The conclusion of my normals and shading work (#12792, #12136 ). The rich image diffs in the patch should show the effect. For a quick summary, here's what the output now looks like:...
X Description: PR Summary The conclusion of my normals and shading work (#12792, #12136 ). The rich image diffs in the patch should show the effect. For a quick summary, here's what the output now looks l...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/13123
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1c26d7c9-9cd1-d233-dd22-a783d709727a |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C650:221AEC:45E571A:5D71DA2:6A652E87 |
| html-safe-nonce | 7f7a38c5258524aa53238d61ee791e5d7fd8e5134f9c933fc34fec04745517a6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNjUwOjIyMUFFQzo0NUU1NzFBOjVENzFEQTI6NkE2NTJFODciLCJ2aXNpdG9yX2lkIjoiNjU5NTQ3NzE4MTY4Mjc1NzI1NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fd05e61ab387ecb926544f5012e47ecc2a8c357adab8d9977188498abcd4eef0 |
| hovercard-subject-tag | pull_request:242514968 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/13123/files |
| twitter:image | https://avatars.githubusercontent.com/u/425260?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/425260?s=400&v=4 |
| og:image:alt | PR Summary The conclusion of my normals and shading work (#12792, #12136 ). The rich image diffs in the patch should show the effect. For a quick summary, here's what the output now looks like:... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 52c76df668885aaff23b50bdca1fa1ea44ac9c1553e888ebc70ff1e4daa4625b |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 309153364422b3c499922d1a2a6404910a58ed8e |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width
