René's URL Explorer Experiment


Title: Simplify callable(self._contains) checks by twmr · Pull Request #13057 · matplotlib/matplotlib · GitHub

Open Graph Title: Simplify callable(self._contains) checks by twmr · Pull Request #13057 · matplotlib/matplotlib

X Title: Simplify callable(self._contains) checks by twmr · Pull Request #13057 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: Artist._contains can either be None (not-set) or a callable (see docstring of Artist.set_contains). Therefore, the callable(self._contains) checks can be simplified to bool(self._contains). PR Summ...

X Description: Artist._contains can either be None (not-set) or a callable (see docstring of Artist.set_contains). Therefore, the callable(self._contains) checks can be simplified to bool(self._contains). PR Summ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/13057

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:11b8efb3-01aa-f3a4-7e6e-f2c048a0b777
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idA960:234E06:15BF2CF:1CE6CC8:6A52B2FA
html-safe-nonce42136638b2fdbe96c71509a8fd1d646e415f7eacad9d37a4fadb93f8f64ead34
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBOTYwOjIzNEUwNjoxNUJGMkNGOjFDRTZDQzg6NkE1MkIyRkEiLCJ2aXNpdG9yX2lkIjoiMTE1NDExOTg1ODEwMDgxMDQ5MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8144b1a4aa11f951c75b8b1ccd6e268df1b99758dfaf5c6a09ab77693a29becd
hovercard-subject-tagpull_request:241198577
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/13057/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/254eff31557ad45a3274d9f6c2db1508f77457c1a9c8ff458304283c0246ff13/matplotlib/matplotlib/pull/13057
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/254eff31557ad45a3274d9f6c2db1508f77457c1a9c8ff458304283c0246ff13/matplotlib/matplotlib/pull/13057
og:image:altArtist._contains can either be None (not-set) or a callable (see docstring of Artist.set_contains). Therefore, the callable(self._contains) checks can be simplified to bool(self._contains). PR Summ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametwmr
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/13057#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F13057
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F13057
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/13057
Reloadhttps://github.com/matplotlib/matplotlib/pull/13057
Reloadhttps://github.com/matplotlib/matplotlib/pull/13057
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
tacaswellhttps://github.com/tacaswell
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
twmr:simplifycallablehttps://github.com/twmr/matplotlib/tree/simplifycallable
Conversationhttps://github.com/matplotlib/matplotlib/pull/13057
Commits1 (1)https://github.com/matplotlib/matplotlib/pull/13057/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/13057/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/13057/files
Simplify callable(self._contains) checkshttps://github.com/matplotlib/matplotlib/pull/13057#top
tacaswellhttps://github.com/tacaswell
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
twmr:simplifycallablehttps://github.com/twmr/matplotlib/tree/simplifycallable
https://github.com/twmr
twmrhttps://github.com/twmr
Dec 27, 2018https://github.com/matplotlib/matplotlib/pull/13057#issue-394454909
#4762https://github.com/matplotlib/matplotlib/pull/4762
Flake 8http://flake8.pycqa.org/en/latest/
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Dec 27, 2018 https://github.com/matplotlib/matplotlib/pull/13057#pullrequestreview-188183360
View reviewed changes https://github.com/matplotlib/matplotlib/pull/13057/files
timhoffmhttps://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/13057#pullrequestreview-188183360
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
lib/matplotlib/artist.pyhttps://github.com/matplotlib/matplotlib/pull/13057/files#diff-387b214c5fcea589dc666d01c8877efc5960ea34625a8de60c857fe312223d63
timhoffmhttps://github.com/timhoffm
Dec 27, 2018https://github.com/matplotlib/matplotlib/pull/13057#discussion_r244230959
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
https://github.com/twmr
twmrhttps://github.com/twmr
Dec 28, 2018https://github.com/matplotlib/matplotlib/pull/13057#issuecomment-450418159
@rmorsheahttps://github.com/rmorshea
#4762https://github.com/matplotlib/matplotlib/pull/4762
@timhoffmhttps://github.com/timhoffm
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Dec 29, 2018https://github.com/matplotlib/matplotlib/pull/13057#issuecomment-450445877
PEP8https://www.python.org/dev/peps/pep-0008/#programming-recommendations
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
https://github.com/twmr
twmrhttps://github.com/twmr
force-pushedhttps://github.com/matplotlib/matplotlib/compare/cfb6c29685737dc7f51923c2a2b48f828cda5af2..ac470d9d7320261930a1cae5dcdde985242426eb
cfb6c29https://github.com/matplotlib/matplotlib/commit/cfb6c29685737dc7f51923c2a2b48f828cda5af2
ac470d9https://github.com/matplotlib/matplotlib/commit/ac470d9d7320261930a1cae5dcdde985242426eb
Compare https://github.com/matplotlib/matplotlib/compare/cfb6c29685737dc7f51923c2a2b48f828cda5af2..ac470d9d7320261930a1cae5dcdde985242426eb
February 2, 2019 19:02https://github.com/matplotlib/matplotlib/pull/13057#event-2113971499
https://github.com/twmr
Simplify callable(self._contains) checkshttps://github.com/matplotlib/matplotlib/pull/13057/commits/06081dcb07a4c92e2a7e3e51d1ab29e759e221e9
06081dchttps://github.com/matplotlib/matplotlib/pull/13057/commits/06081dcb07a4c92e2a7e3e51d1ab29e759e221e9
https://github.com/twmr
twmrhttps://github.com/twmr
force-pushedhttps://github.com/matplotlib/matplotlib/compare/ac470d9d7320261930a1cae5dcdde985242426eb..06081dcb07a4c92e2a7e3e51d1ab29e759e221e9
ac470d9https://github.com/matplotlib/matplotlib/commit/ac470d9d7320261930a1cae5dcdde985242426eb
06081dchttps://github.com/matplotlib/matplotlib/commit/06081dcb07a4c92e2a7e3e51d1ab29e759e221e9
Compare https://github.com/matplotlib/matplotlib/compare/ac470d9d7320261930a1cae5dcdde985242426eb..06081dcb07a4c92e2a7e3e51d1ab29e759e221e9
February 2, 2019 19:04https://github.com/matplotlib/matplotlib/pull/13057#event-2113972297
https://github.com/twmr
twmrhttps://github.com/twmr
Feb 2, 2019https://github.com/matplotlib/matplotlib/pull/13057#issuecomment-459990629
PEP8https://www.python.org/dev/peps/pep-0008/#programming-recommendations
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Feb 14, 2019 https://github.com/matplotlib/matplotlib/pull/13057#pullrequestreview-204023644
View reviewed changes https://github.com/matplotlib/matplotlib/pull/13057/files/06081dcb07a4c92e2a7e3e51d1ab29e759e221e9
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
v3.1.0https://github.com/matplotlib/matplotlib/milestone/35
Feb 14, 2019https://github.com/matplotlib/matplotlib/pull/13057#event-2141158481
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
Feb 14, 2019https://github.com/matplotlib/matplotlib/pull/13057#issuecomment-463846433
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
https://github.com/timhoffm
timhoffmhttps://github.com/timhoffm
status: needs review https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20review%22
Feb 14, 2019https://github.com/matplotlib/matplotlib/pull/13057#event-2141166262
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
fdfe898https://github.com/matplotlib/matplotlib/commit/fdfe898b6d3a947ef0fc606a6e8d6b4ce263492f
Feb 23, 2019https://github.com/matplotlib/matplotlib/pull/13057#event-2159672796
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Feb 23, 2019https://github.com/matplotlib/matplotlib/pull/13057#issuecomment-466668745
@Thischhttps://github.com/Thisch
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
https://github.com/meeseeksmachine
meeseeksmachinehttps://github.com/meeseeksmachine
Feb 23, 2019 https://github.com/matplotlib/matplotlib/pull/13057#ref-pullrequest-413714289
Backport PR #13057 on branch v3.1.x (Simplify callable(self._contains) checks) #13497 https://github.com/matplotlib/matplotlib/pull/13497
meeseeksmachinehttps://github.com/meeseeksmachine
Feb 23, 2019 https://github.com/matplotlib/matplotlib/pull/13057#ref-commit-bc07a8e
https://github.com/tacaswell
Backport PRhttps://github.com/meeseeksmachine/matplotlib/commit/bc07a8e1a6dd03b3c928620aef32e9b98a5bd69b
matplotlib#13057https://github.com/matplotlib/matplotlib/pull/13057
: Simplify callable(self._contains) checkshttps://github.com/meeseeksmachine/matplotlib/commit/bc07a8e1a6dd03b3c928620aef32e9b98a5bd69b
bc07a8ehttps://github.com/meeseeksmachine/matplotlib/commit/bc07a8e1a6dd03b3c928620aef32e9b98a5bd69b
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Feb 23, 2019https://github.com/matplotlib/matplotlib/pull/13057#issuecomment-466668773
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
tacaswellhttps://github.com/tacaswell
Feb 23, 2019 https://github.com/matplotlib/matplotlib/pull/13057#ref-commit-a1a62b4
https://github.com/tacaswell
Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/a1a62b48ce654fcf1eb64863bbf00f00cef4eeee
#13497https://github.com/matplotlib/matplotlib/pull/13497
from meeseeksmachine/auto-backport-of-pr-13…https://github.com/matplotlib/matplotlib/commit/a1a62b48ce654fcf1eb64863bbf00f00cef4eeee
a1a62b4https://github.com/matplotlib/matplotlib/commit/a1a62b48ce654fcf1eb64863bbf00f00cef4eeee
#13057https://github.com/matplotlib/matplotlib/pull/13057
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
status: needs review https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20review%22
May 4, 2019https://github.com/matplotlib/matplotlib/pull/13057#event-2319245581
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F13057
https://github.com/timhoffm
timhoffm https://github.com/timhoffm
https://github.com/matplotlib/matplotlib/pull/13057/files/06081dcb07a4c92e2a7e3e51d1ab29e759e221e9
v3.1.0 https://github.com/matplotlib/matplotlib/milestone/35
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/13057
https://github.com/twmr
https://github.com/timhoffm
https://github.com/tacaswell
https://github.com/QuLogic
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.