René's URL Explorer Experiment


Title: textpath encoding by anntzer · Pull Request #12928 · matplotlib/matplotlib · GitHub

Open Graph Title: textpath encoding by anntzer · Pull Request #12928 · matplotlib/matplotlib

X Title: textpath encoding by anntzer · Pull Request #12928 · matplotlib/matplotlib

Description: PR Summary Consider the following example. import matplotlib.pyplot as plt plt.rcParams['text.usetex'] = True plt.rcParams['text.latex.preamble'] = r'\usepackage{siunitx}' plt.rcParams['text.hinting_factor'] = 1 plt.text(.5, .5, r'$\si{\degree}$') plt.text(.5, .4, r'ff\textwon') plt.gca().set_axis_off() plt.savefig('/tmp/plot.svg') plt.savefig('/tmp/plot.pdf') plt.savefig('/tmp/plot.png') plt.show() In the svg output, one sees that the \degree and \textwon characters (which come from a different font that the ff ligature) are now correctly loaded, but at a too small size -- this still needs to be fixedn but is already better than not loading the glyphs at all. (pdf and png output are unaffected.) Supersedes #8286, #8415 (from which a test is taken). Fixes part of #8068, #8280 (the glyph-loading part; the sizing issue is a bug this PR newly exposes). Likely the bad font sizing has something to do with the use, in textpath.py of self.FONT_SCALE rather than prop.get_size_in_points()/dvifont.size... PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Open Graph Description: PR Summary Consider the following example. import matplotlib.pyplot as plt plt.rcParams['text.usetex'] = True plt.rcParams['text.latex.preamble'] = r'\usepackage{siunitx}' p...

X Description: PR Summary Consider the following example. import matplotlib.pyplot as plt plt.rcParams['text.usetex'] = True plt.rcParams['text.latex.preamble'] = r'\usepac...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/12928

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:6831a138-8965-3e46-30fc-b01d8fc170d5
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC596:238281:CC6369:110DF3E:6A53262A
html-safe-nonceceef7bb1a842da87d42bc5663bc616fa79844aee7f4ea8e750dae86ebd9d15e4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNTk2OjIzODI4MTpDQzYzNjk6MTEwREYzRTo2QTUzMjYyQSIsInZpc2l0b3JfaWQiOiI1Njg4OTc2MDAxNDY4NDMxNzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmaccea78079ce1f3e2f7b849f069debd1dcbbc2eaaa80651c64769ddbf3344af9f2
hovercard-subject-tagpull_request:235517378
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/12928/files
twitter:imagehttps://avatars.githubusercontent.com/u/1322974?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1322974?s=400&v=4
og:image:altPR Summary Consider the following example. import matplotlib.pyplot as plt plt.rcParams['text.usetex'] = True plt.rcParams['text.latex.preamble'] = r'\usepackage{siunitx}' p...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/12928/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12928%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12928%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/12928/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/12928/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/12928/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12928/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12928/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
tacaswellhttps://github.com/tacaswell
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
anntzer:textpath-encodinghttps://github.com/anntzer/matplotlib/tree/textpath-encoding
Conversation 7 https://github.com/matplotlib/matplotlib/pull/12928
Commits 4 https://github.com/matplotlib/matplotlib/pull/12928/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/12928/checks
Files changed https://github.com/matplotlib/matplotlib/pull/12928/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12928/files
textpath encoding https://github.com/matplotlib/matplotlib/pull/12928/files#top
Show all changes 4 commits https://github.com/matplotlib/matplotlib/pull/12928/files
2c0f5ec Fix loading of encoded fonts in textpath. anntzer Dec 3, 2018 https://github.com/matplotlib/matplotlib/pull/12928/commits/2c0f5ecd8a06d6dff36e0e00dc3e7caccb2c798b
88e1b53 Added test encoding issue in SVG backend Apr 1, 2017 https://github.com/matplotlib/matplotlib/pull/12928/commits/88e1b5346d2f2458b88d708048f2c3fa0bb44b64
c5f2bbe Fix the cherry-picked test. anntzer Dec 3, 2018 https://github.com/matplotlib/matplotlib/pull/12928/commits/c5f2bbe52eef9c2ad0ded69556d8be2fada83e8c
722de6f Properly warn when glyph is not in encoding. anntzer Apr 2, 2019 https://github.com/matplotlib/matplotlib/pull/12928/commits/722de6f75bb1ed72f689055bf7d17cf3c37873ea
Clear filters https://github.com/matplotlib/matplotlib/pull/12928/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12928/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12928/files
dviread.py https://github.com/matplotlib/matplotlib/pull/12928/files#diff-305d738d17620dbdc421ea909267d08a18069d49b2ffd799a0bb086038b42268
test_backend_svg.py https://github.com/matplotlib/matplotlib/pull/12928/files#diff-596c8e30ca12976a87641765ff0dcb16ce3da0c8af5525b8067b5f1c03831a2f
textpath.py https://github.com/matplotlib/matplotlib/pull/12928/files#diff-574862438bd94ff599818f86767104b56673fa6df2ecb067a1254c842f281f4d
lib/matplotlib/dviread.pyhttps://github.com/matplotlib/matplotlib/pull/12928/files#diff-305d738d17620dbdc421ea909267d08a18069d49b2ffd799a0bb086038b42268
View file https://github.com/anntzer/matplotlib/blob/722de6f75bb1ed72f689055bf7d17cf3c37873ea/lib/matplotlib/dviread.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/12928/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-305d738d17620dbdc421ea909267d08a18069d49b2ffd799a0bb086038b42268
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-305d738d17620dbdc421ea909267d08a18069d49b2ffd799a0bb086038b42268
lib/matplotlib/tests/test_backend_svg.pyhttps://github.com/matplotlib/matplotlib/pull/12928/files#diff-596c8e30ca12976a87641765ff0dcb16ce3da0c8af5525b8067b5f1c03831a2f
View file https://github.com/anntzer/matplotlib/blob/722de6f75bb1ed72f689055bf7d17cf3c37873ea/lib/matplotlib/tests/test_backend_svg.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/12928/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-596c8e30ca12976a87641765ff0dcb16ce3da0c8af5525b8067b5f1c03831a2f
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-596c8e30ca12976a87641765ff0dcb16ce3da0c8af5525b8067b5f1c03831a2f
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-596c8e30ca12976a87641765ff0dcb16ce3da0c8af5525b8067b5f1c03831a2f
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-596c8e30ca12976a87641765ff0dcb16ce3da0c8af5525b8067b5f1c03831a2f
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-596c8e30ca12976a87641765ff0dcb16ce3da0c8af5525b8067b5f1c03831a2f
lib/matplotlib/textpath.pyhttps://github.com/matplotlib/matplotlib/pull/12928/files#diff-574862438bd94ff599818f86767104b56673fa6df2ecb067a1254c842f281f4d
View file https://github.com/anntzer/matplotlib/blob/722de6f75bb1ed72f689055bf7d17cf3c37873ea/lib/matplotlib/textpath.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/12928/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-574862438bd94ff599818f86767104b56673fa6df2ecb067a1254c842f281f4d
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-574862438bd94ff599818f86767104b56673fa6df2ecb067a1254c842f281f4d
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-574862438bd94ff599818f86767104b56673fa6df2ecb067a1254c842f281f4d
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-574862438bd94ff599818f86767104b56673fa6df2ecb067a1254c842f281f4d
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-574862438bd94ff599818f86767104b56673fa6df2ecb067a1254c842f281f4d
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-574862438bd94ff599818f86767104b56673fa6df2ecb067a1254c842f281f4d
https://github.com/matplotlib/matplotlib/pull/12928/files#diff-574862438bd94ff599818f86767104b56673fa6df2ecb067a1254c842f281f4d
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.