René's URL Explorer Experiment

Title: FIX: (broken)bar(h) math before units by jklymak · Pull Request #12903 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: (broken)bar(h) math before units by jklymak · Pull Request #12903 · matplotlib/matplotlib

X Title: FIX: (broken)bar(h) math before units by jklymak · Pull Request #12903 · matplotlib/matplotlib

Description: PR Summary OK, this works w/ bar, barh, and broken_barh, and I think it even passes the tests.... EDIT: now works w/ bar, but see issue below with the pdf (and pgf) determinism tests... EDIT: OK, this may not work: i.e. consider ax.bar(['a', 'b'], ['c', 'd']). Width defaults to 0.8, so we can't add 0.8 to 'a'. It works fine for datetime and timedelta because they have addition defined, but you can't add a float to a string. So, we may have to go back to something like delta = convert_units_delta(x, delta) and then assume that the converter can do the math. Closes #12862 Also closes #11290, though it doesn't address the call for a timedelta formatter, but at least it doesn't crash! Now time deltas work for both bar and barh. import matplotlib.pyplot as plt from datetime import datetime, timedelta lo = datetime(2018, 11, 9, 20, 0, 0) hi = datetime(2018, 11, 9, 22, 0, 0) fig, ax = plt.subplots() ax.set_xlim(lo-timedelta(hours=1), hi) ax.set_ylim(0, 30) ax.broken_barh([(lo, timedelta(hours=1))], (10, 20)) plt.show() fails on master. Now works by making sure that the timedelta math is done before the unit conversion is done. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Open Graph Description: PR Summary OK, this works w/ bar, barh, and broken_barh, and I think it even passes the tests.... EDIT: now works w/ bar, but see issue below with the pdf (and pgf) determinism tests... EDIT: OK, ...

X Description: PR Summary OK, this works w/ bar, barh, and broken_barh, and I think it even passes the tests.... EDIT: now works w/ bar, but see issue below with the pdf (and pgf) determinism tests... EDIT: OK, ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/12903

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width