René's URL Explorer Experiment


Title: FIX: allow non bbox_extra_artists calls by jklymak · Pull Request #12635 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: allow non bbox_extra_artists calls by jklymak · Pull Request #12635 · matplotlib/matplotlib

X Title: FIX: allow non bbox_extra_artists calls by jklymak · Pull Request #12635 · matplotlib/matplotlib

Description: PR Summary Closes #12634 Apparently some axes don't allow accept bbox_extra_artists kwarg. I could not track down how to get the parasite axes' get_tightbbox to accept this kwarg, but this fix seems to work fine. The offending PR was #12363 where I introduced the bbox_extra_artists as a kwarg. That was probably a mistake because some axes subclasses out there may not impliment this kwarg. This PR makes that kwarg optional - if axsubclass.get_tightbbox(renderer, bbox_extra_artists=artists) gives a TypeError, then we just call it w/o this kwarg. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant

Open Graph Description: PR Summary Closes #12634 Apparently some axes don't allow accept bbox_extra_artists kwarg. I could not track down how to get the parasite axes' get_tightbbox to accept this kwarg, but this...

X Description: PR Summary Closes #12634 Apparently some axes don't allow accept bbox_extra_artists kwarg. I could not track down how to get the parasite axes' get_tightbbox to accept this kwarg, ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/12635

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f8344403-5aa5-ef52-1cb0-e077b425a1bd
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB958:48ECA:106C903:1647A1D:6A571198
html-safe-noncece919d708b95f87d8d24a6e5cb6009d0b443df7b036135c6adbe4c05a8bfd344
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTU4OjQ4RUNBOjEwNkM5MDM6MTY0N0ExRDo2QTU3MTE5OCIsInZpc2l0b3JfaWQiOiIxODk0ODY0NTE4MjI1NzkzNDMyIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmace3e0551775aa68cb42724aeea8b15edd1efa46fbe5809ec7afae36e1774b8455
hovercard-subject-tagpull_request:225978987
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/12635/files
twitter:imagehttps://avatars.githubusercontent.com/u/1562854?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1562854?s=400&v=4
og:image:altPR Summary Closes #12634 Apparently some axes don't allow accept bbox_extra_artists kwarg. I could not track down how to get the parasite axes' get_tightbbox to accept this kwarg, but this...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2576d1f0198cf1588faf2edf27f1ed120903be10
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/12635/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12635%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12635%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/12635/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/12635/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/12635/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12635/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12635/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 410 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
timhoffmhttps://github.com/timhoffm
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-allow-non-bbox-exgtra-artistshttps://github.com/jklymak/matplotlib/tree/fix-allow-non-bbox-exgtra-artists
Conversation 3 https://github.com/matplotlib/matplotlib/pull/12635
Commits 2 https://github.com/matplotlib/matplotlib/pull/12635/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/12635/checks
Files changed 3 https://github.com/matplotlib/matplotlib/pull/12635/files
FIX: allow non bbox_extra_artists calls https://github.com/matplotlib/matplotlib/pull/12635/files#top
Show all changes 2 commits https://github.com/matplotlib/matplotlib/pull/12635/files
b9f79b5 FIX: allow non bbox_extra_artists calls jklymak Oct 26, 2018 https://github.com/matplotlib/matplotlib/pull/12635/commits/b9f79b5994cab05df47c0dd2334f8e19f69d9dd9
ed621ad TST: test get_tightbbox for axes_grid1 jklymak Oct 26, 2018 https://github.com/matplotlib/matplotlib/pull/12635/commits/ed621ad0475a2544513ce4d96990be3e40f02c51
Clear filters https://github.com/matplotlib/matplotlib/pull/12635/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12635/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12635/files
figure.py https://github.com/matplotlib/matplotlib/pull/12635/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
parasite_axes.py https://github.com/matplotlib/matplotlib/pull/12635/files#diff-3047bd98e08020ef20f2b9c8958ac0ecfa3dab4def464d5745d12342980357d5
test_axes_grid1.py https://github.com/matplotlib/matplotlib/pull/12635/files#diff-f35c45d65484a411d8cc41ec136f5995de4fc0927247557b07ba3062cd8c589a
lib/matplotlib/figure.pyhttps://github.com/matplotlib/matplotlib/pull/12635/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
View file https://github.com/jklymak/matplotlib/blob/ed621ad0475a2544513ce4d96990be3e40f02c51/lib/matplotlib/figure.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/12635/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/12635/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
https://github.com/matplotlib/matplotlib/pull/12635/files#diff-01b0c7a8c4445ae46a3c055ace167e99f59dcd54dbf04c84bca2132914d2f8df
lib/mpl_toolkits/axes_grid1/parasite_axes.pyhttps://github.com/matplotlib/matplotlib/pull/12635/files#diff-3047bd98e08020ef20f2b9c8958ac0ecfa3dab4def464d5745d12342980357d5
View file https://github.com/jklymak/matplotlib/blob/ed621ad0475a2544513ce4d96990be3e40f02c51/lib/mpl_toolkits/axes_grid1/parasite_axes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/12635/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/12635/files#diff-3047bd98e08020ef20f2b9c8958ac0ecfa3dab4def464d5745d12342980357d5
https://github.com/matplotlib/matplotlib/pull/12635/files#diff-3047bd98e08020ef20f2b9c8958ac0ecfa3dab4def464d5745d12342980357d5
lib/mpl_toolkits/tests/test_axes_grid1.pyhttps://github.com/matplotlib/matplotlib/pull/12635/files#diff-f35c45d65484a411d8cc41ec136f5995de4fc0927247557b07ba3062cd8c589a
View file https://github.com/jklymak/matplotlib/blob/ed621ad0475a2544513ce4d96990be3e40f02c51/lib/mpl_toolkits/tests/test_axes_grid1.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/12635/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/12635/files#diff-f35c45d65484a411d8cc41ec136f5995de4fc0927247557b07ba3062cd8c589a
QuLogichttps://github.com/QuLogic
Nov 10, 2018https://github.com/matplotlib/matplotlib/pull/12635/files#r232447206
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12635/files
jklymakhttps://github.com/jklymak
Nov 10, 2018https://github.com/matplotlib/matplotlib/pull/12635/files#r232455776
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12635/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.