Title: FIX: don't import macosx to check if eventloop running by jklymak · Pull Request #12603 · matplotlib/matplotlib · GitHub
Open Graph Title: FIX: don't import macosx to check if eventloop running by jklymak · Pull Request #12603 · matplotlib/matplotlib
X Title: FIX: don't import macosx to check if eventloop running by jklymak · Pull Request #12603 · matplotlib/matplotlib
Description: PR Summary Alternative to #12557 Crossref #11850, @anntzer, isn't this right? If the user has started the macosx event loop, they must have already imported macosx? OTOH I am not sure how to make a Mac GUI to test that this test now does the right thing if the user has made a GUI. If someone has a easy GUI to test, that'd help... Framework build: From python prompt: import matplotlib.pyplot as plt Goes to MacOSX backend, bounces dock icon, but keeps focus on terminal import matplotlib; matplotlib.use('qt5agg'); import matplotlib.pyplot as plt No icon until a draw command is given. (Goes to QT5) non-Framework import matplotlib.pyplot as plt falls back to qt5AGG import matplotlib; matplotlib.use('macosx'); import matplotlib.pyplot as plt Gives import error. So.... I think this all works as expected. The windows connection gets made earlier than we'd like ( NSApp = [NSApplication sharedApplication]; in verify_framework()), but there is no way around that. This also no longer uses the deprecated code. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: PR Summary Alternative to #12557 Crossref #11850, @anntzer, isn't this right? If the user has started the macosx event loop, they must have already imported macosx? OTOH I am not sure how to m...
X Description: PR Summary Alternative to #12557 Crossref #11850, @anntzer, isn't this right? If the user has started the macosx event loop, they must have already imported macosx? OTOH I am not sure how ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/12603
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:1942b2e9-d32f-be38-0e74-9e409d194407 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | CF90:56084:4E99D5:706959:6A5785D0 |
| html-safe-nonce | 8574d839dfc206b8708058ef63bf00979dfcb1feeb88d5bbf02861b36ef753aa |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRjkwOjU2MDg0OjRFOTlENTo3MDY5NTk6NkE1Nzg1RDAiLCJ2aXNpdG9yX2lkIjoiODg1MTUwMDk4NDAzMzU3NjQwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 69dc91d9cadfcfa0cebf50b04f4e71c793cca0eca257ed0948814eded98f07ac |
| hovercard-subject-tag | pull_request:225150882 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/12603/files |
| twitter:image | https://avatars.githubusercontent.com/u/1562854?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1562854?s=400&v=4 |
| og:image:alt | PR Summary Alternative to #12557 Crossref #11850, @anntzer, isn't this right? If the user has started the macosx event loop, they must have already imported macosx? OTOH I am not sure how to m... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | c6353e56e94423c9cd5abde7708a859afa36a0c1203c73749055bf6ee6704cd0 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f59ab1c46b638204e2aea09126d089be5dc773b7 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width