René's URL Explorer Experiment

Title: Fix macosx verify later by jklymak · Pull Request #12557 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix macosx verify later by jklymak · Pull Request #12557 · matplotlib/matplotlib

X Title: Fix macosx verify later by jklymak · Pull Request #12557 · matplotlib/matplotlib

Description: PR Summary This moves the verification of the framework build out of import _macosx, allowing us to call that more often, and into the creation of the figure manager... Closes #12188 Update (19 Oct 2018) Moved MacOSx framework check to pyplot.py so it errors at the same place as before rather than waiting for a draw. Note this doesn't fix the bouncing icon in the framework build if one indeed wants to use the macosx backend, but it doesn't pop one up everytime regardless of the backend. Not sure what changed in 3.0 to cause the icon to start bouncing, but this should cure the problem for 75% of the users who just want to use Matplotlib with a different backend, like a notebook... Icon bouncing is because we initialize the window manager connection to python, but we don't open a window, so the app is in an in-between state of readiness. Until conda ships a python that we can test if its a FRAMEWORK app, I am not sure we will fix this any better than this. Note the vast improvement here is that the bouncing doesn't happen for every backend like it does in 3.0.0 Non-framework python this PR >>> import matplotlib; matplotlib.use('macosx'); import matplotlib.pyplot yields: No icon popped up and Traceback (most recent call last): File "testbackend.py", line 3, in import matplotlib.pyplot File "/Users/jklymak/matplotlib/lib/matplotlib/pyplot.py", line 2357, in "Python is not installed as a framework. The Mac OS X backend " ImportError: Python is not installed as a framework. The Mac OS X backend will not be able to function correctly if Python is not installed as a framework. See the Python documentation for more information on installing Python as a framework on Mac OS X. Please either reinstall Python as a framework, or try one of the other backends. If you are using (Ana)Conda please install python.app and replace the use of 'python' with 'pythonw'. See 'Working with Matplotlib on OSX' in the Matplotlib FAQ for more information. V 2.2.3 As above, though the stacktrace is deeper: File "", line 1, in File "/Users/jklymak/matplotlib/lib/matplotlib/pyplot.py", line 115, in _backend_mod, new_figure_manager, draw_if_interactive, _show = pylab_setup() File "/Users/jklymak/matplotlib/lib/matplotlib/backends/__init__.py", line 62, in pylab_setup [backend_name], 0) File "/Users/jklymak/matplotlib/lib/matplotlib/backends/backend_macosx.py", line 17, in V3.0.0 Error is on import as above. Framework python V3.0.0 >>> import matplotlib; matplotlib.use('macosx'); import matplotlib.pyplot as pyplot Icon pops up, bounces, and terminal loses focus. >>> import matplotlib; matplotlib.use('qt5agg'); import matplotlib.pyplot as pyplot Icon pops up, bounces, and terminal loses focus. this PR >>> import matplotlib; matplotlib.use('macosx'); import matplotlib.pyplot as pyplot Icon bounces until a draw is called and terminal loses focus but focus returns to terminal. >>> import matplotlib; matplotlib.use('qt5agg'); import matplotlib.pyplot as pyplot No icon pops up.... V2.2.3 >>> import matplotlib; matplotlib.use('macosx'); import matplotlib.pyplot as pyplot Icon pops up, but doesn't bounce. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Open Graph Description: PR Summary This moves the verification of the framework build out of import _macosx, allowing us to call that more often, and into the creation of the figure manager... Closes #12188 Update (19 Oct...

X Description: PR Summary This moves the verification of the framework build out of import _macosx, allowing us to call that more often, and into the creation of the figure manager... Closes #12188 Update (19 Oct...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/12557

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width