René's URL Explorer Experiment


Title: FIX: make add_lines work with new colorbar by jklymak · Pull Request #12461 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: make add_lines work with new colorbar by jklymak · Pull Request #12461 · matplotlib/matplotlib

X Title: FIX: make add_lines work with new colorbar by jklymak · Pull Request #12461 · matplotlib/matplotlib

Description: PR Summary Closes #12458 See below for a less pathological example... cbar.add_lines was not operational after new colorbar changes in 3.0.0. import matplotlib.pyplot as plt import matplotlib as mpl import numpy as np fig = plt.figure() ax = fig.add_axes([0.05, 0.8, 0.9, 0.15]) cmap = mpl.cm.cool norm = mpl.colors.Normalize(vmin=-4, vmax=4) levels = (-1.0, 1.0, 2.0, 3.0) cb = mpl.colorbar.ColorbarBase(ax, cmap=cmap, norm=norm) colors_bg = np.tile(list((1.0, 1.0, 1.0, 1.0)), (len(levels), 1)) cb.add_lines(levels=levels, colors=colors_bg, linewidths=1) Before After import numpy as np import matplotlib.pyplot as plt fig, ax = plt.subplots() X = np.random.rand(10, 10)*10000 pcm = ax.pcolormesh(X) # add 1000 to make colors visible... cont = ax.contour(X+1000) cb = fig.colorbar(pcm) cb.add_lines(cont) plt.show() Before After PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Open Graph Description: PR Summary Closes #12458 See below for a less pathological example... cbar.add_lines was not operational after new colorbar changes in 3.0.0. import matplotlib.pyplot as plt import matplotlib as mp...

X Description: PR Summary Closes #12458 See below for a less pathological example... cbar.add_lines was not operational after new colorbar changes in 3.0.0. import matplotlib.pyplot as plt import matplotlib as mp...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/12461

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1c29b98b-9b3c-286e-83ac-33671ae4ad1c
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idCD56:1D8CC3:1727467:1F75CBE:6A52339A
html-safe-nonceef208b4fee4d1ac4a78a5934da6212a149edb35e1cc4c5d09564dc7a90213bed
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDU2OjFEOENDMzoxNzI3NDY3OjFGNzVDQkU6NkE1MjMzOUEiLCJ2aXNpdG9yX2lkIjoiOTE1OTI4MTg4MzgxMjYwNjg3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd191565241a150b16540b96aee18b7697f74a4f66ee56a8001bbf2c1df34270b
hovercard-subject-tagpull_request:221492224
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/12461/files
twitter:imagehttps://avatars.githubusercontent.com/u/1562854?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1562854?s=400&v=4
og:image:altPR Summary Closes #12458 See below for a less pathological example... cbar.add_lines was not operational after new colorbar changes in 3.0.0. import matplotlib.pyplot as plt import matplotlib as mp...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7aed05249554b889eb33d002851a973eebcc7e91
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/12461/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12461%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12461%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/12461/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/12461/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/12461/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12461/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12461/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
dstansbyhttps://github.com/dstansby
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-cbar-addlineshttps://github.com/jklymak/matplotlib/tree/fix-cbar-addlines
Conversation 11 https://github.com/matplotlib/matplotlib/pull/12461
Commits 3 https://github.com/matplotlib/matplotlib/pull/12461/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/12461/checks
Files changed https://github.com/matplotlib/matplotlib/pull/12461/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12461/files
FIX: make add_lines work with new colorbar https://github.com/matplotlib/matplotlib/pull/12461/files#top
Show all changes 3 commits https://github.com/matplotlib/matplotlib/pull/12461/files
fa971b1 FIX: make add_lines wortk with new colorbar jklymak Oct 9, 2018 https://github.com/matplotlib/matplotlib/pull/12461/commits/fa971b14cfdfaa9ae52bbb0a10bf233da2cbc009
e0177bc TST: fix test images jklymak Oct 9, 2018 https://github.com/matplotlib/matplotlib/pull/12461/commits/e0177bc8037ab82e37b1f5ec6da7d10ad2eed611
389cf07 TST: test for add_lines working as expected jklymak Oct 9, 2018 https://github.com/matplotlib/matplotlib/pull/12461/commits/389cf07a928739faa3b20baf566ee80253c5a5ce
Clear filters https://github.com/matplotlib/matplotlib/pull/12461/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12461/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12461/files
colorbar.py https://github.com/matplotlib/matplotlib/pull/12461/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
contour_colorbar.pdf https://github.com/matplotlib/matplotlib/pull/12461/files#diff-cc4c24838e1dd7e2da699063be7dd5109869e693812fbd8e24e258037a038c8c
contour_colorbar.png https://github.com/matplotlib/matplotlib/pull/12461/files#diff-f29da672f22a2f0ad2b88c59da591461e5fbe236876211e94524b8ccc02f182a
contour_colorbar.svg https://github.com/matplotlib/matplotlib/pull/12461/files#diff-37a493ea7ab1331d85b9a4290cc819812d5302e430c572527723df8b0fd50443
contour_addlines.png https://github.com/matplotlib/matplotlib/pull/12461/files#diff-ef9b564754f269995170674cc485800e53f6902f62ffc34968cefb66267723c0
contour_manual_colors_and_levels.png https://github.com/matplotlib/matplotlib/pull/12461/files#diff-26ec6a3e1df53ad79d095062a06e051fdc848a69e47fa1ded8fc7d6006f4ff6f
test_contour.py https://github.com/matplotlib/matplotlib/pull/12461/files#diff-56298727b96c2c05776fa59f72ae5f189bb16d046d5452cf8379a1fe55906bdc
lib/matplotlib/colorbar.pyhttps://github.com/matplotlib/matplotlib/pull/12461/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
View file https://github.com/jklymak/matplotlib/blob/389cf07a928739faa3b20baf566ee80253c5a5ce/lib/matplotlib/colorbar.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/12461/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/12461/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
https://github.com/matplotlib/matplotlib/pull/12461/files#diff-250555d303944dc7fd3b69fe9a14f292f9b715d738a6a0649d7d62a7c8315b05
lib/matplotlib/tests/baseline_images/test_axes/contour_colorbar.pdfhttps://github.com/matplotlib/matplotlib/pull/12461/files#diff-cc4c24838e1dd7e2da699063be7dd5109869e693812fbd8e24e258037a038c8c
View file https://github.com/jklymak/matplotlib/blob/389cf07a928739faa3b20baf566ee80253c5a5ce/lib/matplotlib/tests/baseline_images/test_axes/contour_colorbar.pdf
Open in desktop https://desktop.github.com
lib/matplotlib/tests/baseline_images/test_axes/contour_colorbar.pnghttps://github.com/matplotlib/matplotlib/pull/12461/files#diff-f29da672f22a2f0ad2b88c59da591461e5fbe236876211e94524b8ccc02f182a
View file https://github.com/jklymak/matplotlib/blob/389cf07a928739faa3b20baf566ee80253c5a5ce/lib/matplotlib/tests/baseline_images/test_axes/contour_colorbar.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/12461/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12461/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.