| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:6d09166e-832b-9434-8769-1db1e631ea44 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | B7BA:1486CD:7B96:9E37:6A521B86 |
| html-safe-nonce | ec5bbcdd9ca53b7dfe42560163b3e3460cf029fb069ba0b925b522aa8f652d74 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCN0JBOjE0ODZDRDo3Qjk2OjlFMzc6NkE1MjFCODYiLCJ2aXNpdG9yX2lkIjoiMzEzNjA3MjMzOTc3Njc0MDIzMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9829654e91408c6094cb2e8261a0d4cf23a5fa60d6e8897fbe8bdb74e6329489 |
| hovercard-subject-tag | pull_request:221492224 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/12461/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/0185938bfbe03686ac016b29fa75c7256bcb22e666baf831544d4d2b9d6e8b9b/matplotlib/matplotlib/pull/12461 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0185938bfbe03686ac016b29fa75c7256bcb22e666baf831544d4d2b9d6e8b9b/matplotlib/matplotlib/pull/12461 |
| og:image:alt | PR Summary
Closes #12458
See below for a less pathological example...
cbar.add_lines was not operational after new colorbar changes in 3.0.0.
import matplotlib.pyplot as plt
import matplotlib as mp... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jklymak |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/12461#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12461 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12461 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/12461 |
| Reload | https://github.com/matplotlib/matplotlib/pull/12461 |
| Reload | https://github.com/matplotlib/matplotlib/pull/12461 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
409
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| dstansby | https://github.com/dstansby |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| jklymak:fix-cbar-addlines | https://github.com/jklymak/matplotlib/tree/fix-cbar-addlines |
| Conversation | https://github.com/matplotlib/matplotlib/pull/12461 |
| Commits3 (3) | https://github.com/matplotlib/matplotlib/pull/12461/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/12461/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/12461/files |
| FIX: make add_lines work with new colorbar | https://github.com/matplotlib/matplotlib/pull/12461#top |
| dstansby | https://github.com/dstansby |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| jklymak:fix-cbar-addlines | https://github.com/jklymak/matplotlib/tree/fix-cbar-addlines |
|
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issue-368277910 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| #12458 | https://github.com/matplotlib/matplotlib/issues/12458 |
| https://user-images.githubusercontent.com/1562854/46681303-ce871d00-cb9f-11e8-8acd-e5defedfe90c.png |
| https://user-images.githubusercontent.com/1562854/46681265-b3b4a880-cb9f-11e8-8efd-87b24d565751.png |
| https://user-images.githubusercontent.com/1562854/46701766-b4683180-cbd5-11e8-8c18-d994ba47e396.png |
| https://user-images.githubusercontent.com/1562854/46701741-9d294400-cbd5-11e8-9006-708b7ef51fdc.png |
| Flake 8 | http://flake8.pycqa.org/en/latest/ |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
|
| https://github.com/jklymak |
| FIX: make add_lines wortk with new colorbar | https://github.com/matplotlib/matplotlib/pull/12461/commits/fa971b14cfdfaa9ae52bbb0a10bf233da2cbc009 |
| fa971b1 | https://github.com/matplotlib/matplotlib/pull/12461/commits/fa971b14cfdfaa9ae52bbb0a10bf233da2cbc009 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#event-1893234805 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| v3.0.x | https://github.com/matplotlib/matplotlib/milestone/37 |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#event-1893235126 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
Oct 9, 2018
| https://github.com/matplotlib/matplotlib/pull/12461#ref-issue-368249960 |
|
add_lines misses lines for matplotlib.colorbar.ColorbarBase
#12458
| https://github.com/matplotlib/matplotlib/issues/12458 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
status: work in progress
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20work%20in%20progress%22 |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#event-1893238805 |
| https://github.com/dstansby |
| dstansby | https://github.com/dstansby |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428247970 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428249505 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
Oct 9, 2018
| https://github.com/matplotlib/matplotlib/pull/12461#ref-issue-368286212 |
|
cbar.add_lines should allow manually adding lines, not just contour sets
#12462
| https://github.com/matplotlib/matplotlib/issues/12462 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428285797 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| jklymak | https://github.com/jklymak |
| October 9, 2018 10:48 | https://github.com/matplotlib/matplotlib/pull/12461#commits-pushed-e0177bc |
|
| https://github.com/jklymak |
| TST: fix test images | https://github.com/matplotlib/matplotlib/pull/12461/commits/e0177bc8037ab82e37b1f5ec6da7d10ad2eed611 |
| e0177bc | https://github.com/matplotlib/matplotlib/pull/12461/commits/e0177bc8037ab82e37b1f5ec6da7d10ad2eed611 |
|
| https://github.com/jklymak |
| TST: test for add_lines working as expected | https://github.com/matplotlib/matplotlib/pull/12461/commits/389cf07a928739faa3b20baf566ee80253c5a5ce |
| 389cf07 | https://github.com/matplotlib/matplotlib/pull/12461/commits/389cf07a928739faa3b20baf566ee80253c5a5ce |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428371445 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
Release critical
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22 |
|
status: work in progress
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20work%20in%20progress%22 |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#event-1894090450 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428372818 |
| @dstansby | https://github.com/dstansby |
| #12380 | https://github.com/matplotlib/matplotlib/pull/12380 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428374798 |
| @anntzer | https://github.com/anntzer |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428378275 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| #12380 | https://github.com/matplotlib/matplotlib/pull/12380 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428379423 |
| #12380 | https://github.com/matplotlib/matplotlib/pull/12380 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/QuLogic |
| QuLogic | https://github.com/QuLogic |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428380254 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428381535 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#issuecomment-428385170 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Oct 10, 2018
| https://github.com/matplotlib/matplotlib/pull/12461#pullrequestreview-163585186 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/12461/files/389cf07a928739faa3b20baf566ee80253c5a5ce |
| https://github.com/dstansby |
| dstansby | https://github.com/dstansby |
|
Oct 14, 2018
| https://github.com/matplotlib/matplotlib/pull/12461#pullrequestreview-164511555 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/12461/files/389cf07a928739faa3b20baf566ee80253c5a5ce |
| https://github.com/dstansby |
| dstansby | https://github.com/dstansby |
| fbd0fba | https://github.com/matplotlib/matplotlib/commit/fbd0fbab2ef7c337d7c9bead25a23bec4b2a6fcf |
| Oct 14, 2018 | https://github.com/matplotlib/matplotlib/pull/12461#event-1902748555 |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Oct 14, 2018
| https://github.com/matplotlib/matplotlib/pull/12461#ref-commit-3dde05b |
|
| https://github.com/dstansby |
| Backport PR | https://github.com/meeseeksmachine/matplotlib/commit/3dde05b0e05c9b84fa679c4ef9bffb40a74f9ed4 |
| matplotlib#12461 | https://github.com/matplotlib/matplotlib/pull/12461 |
| : FIX: make add_lines work with new colorbar | https://github.com/meeseeksmachine/matplotlib/commit/3dde05b0e05c9b84fa679c4ef9bffb40a74f9ed4 |
| 3dde05b | https://github.com/meeseeksmachine/matplotlib/commit/3dde05b0e05c9b84fa679c4ef9bffb40a74f9ed4 |
| https://github.com/meeseeksmachine |
| meeseeksmachine | https://github.com/meeseeksmachine |
|
Oct 14, 2018
| https://github.com/matplotlib/matplotlib/pull/12461#ref-pullrequest-369936148 |
|
Backport PR #12461 on branch v3.0.x (FIX: make add_lines work with new colorbar)
#12527
| https://github.com/matplotlib/matplotlib/pull/12527 |
| QuLogic | https://github.com/QuLogic |
|
Oct 14, 2018
| https://github.com/matplotlib/matplotlib/pull/12461#ref-commit-b8e2e1b |
|
| https://github.com/QuLogic |
| Merge pull request | https://github.com/matplotlib/matplotlib/commit/b8e2e1b7ffd8b490d3313c815f963375296fed2b |
| #12527 | https://github.com/matplotlib/matplotlib/pull/12527 |
| from meeseeksmachine/auto-backport-of-pr-12… | https://github.com/matplotlib/matplotlib/commit/b8e2e1b7ffd8b490d3313c815f963375296fed2b |
| b8e2e1b | https://github.com/matplotlib/matplotlib/commit/b8e2e1b7ffd8b490d3313c815f963375296fed2b |
| #12461 | https://github.com/matplotlib/matplotlib/pull/12461 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| October 22, 2018 17:41 | https://github.com/matplotlib/matplotlib/pull/12461#event-1918102295 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12461 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/12461/files/389cf07a928739faa3b20baf566ee80253c5a5ce |
|
| https://github.com/dstansby |
|
dstansby
| https://github.com/dstansby |
|
| https://github.com/matplotlib/matplotlib/pull/12461/files/389cf07a928739faa3b20baf566ee80253c5a5ce |
|
Release critical
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22 |
|
v3.0.1
| https://github.com/matplotlib/matplotlib/milestone/37 |
|
add_lines misses lines for matplotlib.colorbar.ColorbarBase
| https://github.com/matplotlib/matplotlib/issues/12458 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12461 |
|
| https://github.com/jklymak |
|
| https://github.com/dstansby |
|
| https://github.com/anntzer |
|
| https://github.com/QuLogic |
|
| https://github.com/timhoffm |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |