René's URL Explorer Experiment


Title: Warn when "best" loc of legend is used with lots of data by kbrose · Pull Request #12455 · matplotlib/matplotlib · GitHub

Open Graph Title: Warn when "best" loc of legend is used with lots of data by kbrose · Pull Request #12455 · matplotlib/matplotlib

X Title: Warn when "best" loc of legend is used with lots of data by kbrose · Pull Request #12455 · matplotlib/matplotlib

Description: PR Summary Warn when "best" loc of legend is used with lots of data, as it can be quite slow. Ref #12120 and #12203 PR Checklist Has Pytest style unit tests Code is Flake 8 compliant N/A New features are documented, with examples if plot related N/A Documentation is sphinx and numpydoc compliant N/A Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) N/A Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Open Graph Description: PR Summary Warn when "best" loc of legend is used with lots of data, as it can be quite slow. Ref #12120 and #12203 PR Checklist Has Pytest style unit tests Code is Flake 8 compliant ...

X Description: PR Summary Warn when "best" loc of legend is used with lots of data, as it can be quite slow. Ref #12120 and #12203 PR Checklist Has Pytest style unit tests Code is Flake 8 com...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/12455

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:f2059d46-b549-83f6-4517-5144f8b6ea3f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id9236:20C5C6:25C6D7:26AA44:6A558BB1
html-safe-noncefd50a1a9057a8c64ca82def8b4f52c97e607b5f41456bbe94ed3c42efb70cf97
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MjM2OjIwQzVDNjoyNUM2RDc6MjZBQTQ0OjZBNTU4QkIxIiwidmlzaXRvcl9pZCI6Ijc1MDQ1NjI4NDg3NDk5NDc4MjUiLCJyZWdpb25fZWRnZSI6InNlYSIsInJlZ2lvbl9yZW5kZXIiOiJzZWEifQ==
visitor-hmacf4f2115b55f9299fd75c1bd182ef5ab064f7efa40f2eb4d7901d5b05bf8d315c
hovercard-subject-tagpull_request:221309590
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/12455/files
twitter:imagehttps://avatars.githubusercontent.com/u/4053170?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/4053170?s=400&v=4
og:image:altPR Summary Warn when "best" loc of legend is used with lots of data, as it can be quite slow. Ref #12120 and #12203 PR Checklist Has Pytest style unit tests Code is Flake 8 compliant ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb5665c84831ed9ac4fb79519c16c9c5580ba8092fb8bb6e3e72972ec7197348e
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releaseaa21baa44893467b0b640d0300538f84ca8c475b
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/12455/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12455%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12455%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/12455/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/12455/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/12455/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12455/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12455/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
NelleVhttps://github.com/NelleV
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
kbrose:warn-on-legend-slownesshttps://github.com/kbrose/matplotlib/tree/warn-on-legend-slowness
Conversation 26 https://github.com/matplotlib/matplotlib/pull/12455
Commits 12 https://github.com/matplotlib/matplotlib/pull/12455/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/12455/checks
Files changed https://github.com/matplotlib/matplotlib/pull/12455/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12455/files
Warn when "best" loc of legend is used with lots of data https://github.com/matplotlib/matplotlib/pull/12455/files#top
Show all changes 12 commits https://github.com/matplotlib/matplotlib/pull/12455/files
b30e93b Warn when "best" loc of legend is used with lots of data kbrose Oct 9, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/b30e93b43b595e31be226100d490c81964c87d1f
cf1d30f Increase size limit before warning kbrose Oct 9, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/cf1d30faf6525c05147c38afc2317667060e3c91
f7be89e Update data size in test kbrose Oct 9, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/f7be89ecd29174750132a1184d48e043911e1ab1
b6e044b Only warn if best was used by default kbrose Nov 15, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/b6e044bac6f75cb5f117f848679544350f4e11e9
6bce43f Add test that no warning is issued when best specified manually kbrose Nov 15, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/6bce43f089c8559af80c6c2168d4efd0c1659567
504f619 update to new way of warning after rebase kbrose Nov 15, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/504f61916d0714f10587ee207a4be62bd366d3cf
7997f4d Remove unnecessarily copied comment in test kbrose Nov 15, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/7997f4d034fec004d192392b44883c24bff2915f
0365455 use rc_context, thanks @timhoffm for the tip kbrose Nov 17, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/03654551a3a3707b3b86a79538fe91611829d132
f01b674 forgot to import rc_context after rebase kbrose Nov 17, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/f01b674463a3027f6341426addf3ac4eb94391fd
2cb3550 Incorporate @timhoffm style change timhoffm Nov 21, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/2cb35505557edf1add41de3f1c395ce18e500617
282ac53 Incorporate @timhoffm style change timhoffm Nov 21, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/282ac5340975716314b0f5c097b4081b728ff4d1
f89a78c Some more refactoring courtesy of @timhoffm kbrose Nov 22, 2018 https://github.com/matplotlib/matplotlib/pull/12455/commits/f89a78cd4f74efb8d9c1cee1514a270214fcdd70
Clear filters https://github.com/matplotlib/matplotlib/pull/12455/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12455/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12455/files
legend.py https://github.com/matplotlib/matplotlib/pull/12455/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
test_legend.py https://github.com/matplotlib/matplotlib/pull/12455/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
lib/matplotlib/legend.pyhttps://github.com/matplotlib/matplotlib/pull/12455/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
View file https://github.com/kbrose/matplotlib/blob/f89a78cd4f74efb8d9c1cee1514a270214fcdd70/lib/matplotlib/legend.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/12455/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/12455/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
https://github.com/matplotlib/matplotlib/pull/12455/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
https://github.com/matplotlib/matplotlib/pull/12455/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
https://github.com/matplotlib/matplotlib/pull/12455/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
https://github.com/matplotlib/matplotlib/pull/12455/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
https://github.com/matplotlib/matplotlib/pull/12455/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/12455/files
https://github.com/matplotlib/matplotlib/pull/12455/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a
lib/matplotlib/tests/test_legend.pyhttps://github.com/matplotlib/matplotlib/pull/12455/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
View file https://github.com/kbrose/matplotlib/blob/f89a78cd4f74efb8d9c1cee1514a270214fcdd70/lib/matplotlib/tests/test_legend.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/12455/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/12455/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
https://github.com/matplotlib/matplotlib/pull/12455/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
https://github.com/matplotlib/matplotlib/pull/12455/files#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.