| route-pattern | /_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format) |
| route-controller | voltron_pull_requests_fragments |
| route-action | pull_request_layout |
| fetch-nonce | v2:a935ebe1-0436-27c7-f8ea-e2ea993046da |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C826:24745D:C44A1:FEF82:6A52E3E7 |
| html-safe-nonce | cc86957c4a1a078f61d037e78defc1d4e320b7a155c5c06cf3b86c10b4589215 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDODI2OjI0NzQ1RDpDNDRBMTpGRUY4Mjo2QTUyRTNFNyIsInZpc2l0b3JfaWQiOiI4NjMzNTYxNDQxMzUyNDc1NjIzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | f0d9e9e1d1babebd68aa42618f0b32d109fc038b15eefdf17d83bade89d1ad4f |
| hovercard-subject-tag | pull_request:221309590 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | ///voltron/pull_requests_fragments/pull_request_layout |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/12455/pull_request_layout |
| twitter:image | https://opengraph.githubassets.com/831e8664b88f034e3c1b9bf2670e7edf3a4d1240107df0f0ac8e95b0ce1bf4dd/matplotlib/matplotlib/pull/12455 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/831e8664b88f034e3c1b9bf2670e7edf3a4d1240107df0f0ac8e95b0ce1bf4dd/matplotlib/matplotlib/pull/12455 |
| og:image:alt | PR Summary
Warn when "best" loc of legend is used with lots of data, as it can be quite slow.
Ref #12120 and #12203
PR Checklist
Has Pytest style unit tests
Code is Flake 8 compliant
... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | kbrose |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-cache |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| Skip to content | https://github.com/matplotlib/matplotlib/pull/12455#start-of-content |
|
| https://github.com/ |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12455 |
| GitHub CopilotWrite better code with AI | https://github.com/features/copilot |
| GitHub Copilot appDirect agents from issue to merge | https://github.com/features/ai/github-app |
| MCP RegistryNewIntegrate external tools | https://github.com/mcp |
| ActionsAutomate any workflow | https://github.com/features/actions |
| CodespacesInstant dev environments | https://github.com/features/codespaces |
| IssuesPlan and track work | https://github.com/features/issues |
| Code ReviewManage code changes | https://github.com/features/code-review |
| GitHub Advanced SecurityFind and fix vulnerabilities | https://github.com/security/advanced-security |
| Code securitySecure your code as you build | https://github.com/security/advanced-security/code-security |
| Secret protectionStop leaks before they start | https://github.com/security/advanced-security/secret-protection |
| Why GitHub | https://github.com/why-github |
| Documentation | https://docs.github.com |
| Blog | https://github.blog |
| Changelog | https://github.blog/changelog |
| Marketplace | https://github.com/marketplace |
| View all features | https://github.com/features |
| Enterprises | https://github.com/enterprise |
| Small and medium teams | https://github.com/team |
| Startups | https://github.com/enterprise/startups |
| Nonprofits | https://github.com/solutions/industry/nonprofits |
| App Modernization | https://github.com/solutions/use-case/app-modernization |
| DevSecOps | https://github.com/solutions/use-case/devsecops |
| DevOps | https://github.com/solutions/use-case/devops |
| CI/CD | https://github.com/solutions/use-case/ci-cd |
| View all use cases | https://github.com/solutions/use-case |
| Healthcare | https://github.com/solutions/industry/healthcare |
| Financial services | https://github.com/solutions/industry/financial-services |
| Manufacturing | https://github.com/solutions/industry/manufacturing |
| Government | https://github.com/solutions/industry/government |
| View all industries | https://github.com/solutions/industry |
| View all solutions | https://github.com/solutions |
| AI | https://github.com/resources/articles?topic=ai |
| Software Development | https://github.com/resources/articles?topic=software-development |
| DevOps | https://github.com/resources/articles?topic=devops |
| Security | https://github.com/resources/articles?topic=security |
| View all topics | https://github.com/resources/articles |
| Customer stories | https://github.com/customer-stories |
| Events & webinars | https://github.com/resources/events |
| Ebooks & reports | https://github.com/resources/whitepapers |
| Business insights | https://github.com/solutions/executive-insights |
| GitHub Skills | https://skills.github.com |
| Documentation | https://docs.github.com |
| Customer support | https://support.github.com |
| Community forum | https://github.com/orgs/community/discussions |
| Trust center | https://github.com/trust-center |
| Partners | https://github.com/partners |
| View all resources | https://github.com/resources |
| GitHub SponsorsFund open source developers | https://github.com/open-source/sponsors |
| Security Lab | https://securitylab.github.com |
| Maintainer Community | https://maintainers.github.com |
| Accelerator | https://github.com/open-source/accelerator |
| GitHub Stars | https://stars.github.com |
| Archive Program | https://archiveprogram.github.com |
| Topics | https://github.com/topics |
| Trending | https://github.com/trending |
| Collections | https://github.com/collections |
| Enterprise platformAI-powered developer platform | https://github.com/enterprise |
| GitHub Advanced SecurityEnterprise-grade security features | https://github.com/security/advanced-security |
| Copilot for BusinessEnterprise-grade AI features | https://github.com/features/copilot/copilot-business |
| Premium SupportEnterprise-grade 24/7 support | https://github.com/enterprise/premium-support |
| Pricing | https://github.com/pricing |
| Search syntax tips | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
| documentation | https://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax |
|
Sign in
| https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12455 |
|
Sign up
| https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib |
| Reload | https://github.com/matplotlib/matplotlib/pull/12455 |
| Reload | https://github.com/matplotlib/matplotlib/pull/12455 |
| Reload | https://github.com/matplotlib/matplotlib/pull/12455 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
|
matplotlib
| https://github.com/matplotlib |
| matplotlib | https://github.com/matplotlib/matplotlib |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
|
Notifications
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Fork
8.4k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Star
23k
| https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
1.1k
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
408
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
0
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
|
Code
| https://github.com/matplotlib/matplotlib |
|
Issues
| https://github.com/matplotlib/matplotlib/issues |
|
Pull requests
| https://github.com/matplotlib/matplotlib/pulls |
|
Actions
| https://github.com/matplotlib/matplotlib/actions |
|
Projects
| https://github.com/matplotlib/matplotlib/projects |
|
Wiki
| https://github.com/matplotlib/matplotlib/wiki |
|
Security and quality
| https://github.com/matplotlib/matplotlib/security |
|
Insights
| https://github.com/matplotlib/matplotlib/pulse |
| NelleV | https://github.com/NelleV |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| kbrose:warn-on-legend-slowness | https://github.com/kbrose/matplotlib/tree/warn-on-legend-slowness |
| Conversation | https://github.com/matplotlib/matplotlib/pull/12455 |
| Commits12 (12) | https://github.com/matplotlib/matplotlib/pull/12455/commits |
| Checks | https://github.com/matplotlib/matplotlib/pull/12455/checks |
| Files changed | https://github.com/matplotlib/matplotlib/pull/12455/files |
| Warn when "best" loc of legend is used with lots of data | https://github.com/matplotlib/matplotlib/pull/12455#top |
| NelleV | https://github.com/NelleV |
| matplotlib:master | https://github.com/matplotlib/matplotlib/tree/master |
| kbrose:warn-on-legend-slowness | https://github.com/kbrose/matplotlib/tree/warn-on-legend-slowness |
|
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issue-368042276 |
| #12120 | https://github.com/matplotlib/matplotlib/issues/12120 |
| #12203 | https://github.com/matplotlib/matplotlib/pull/12203 |
| Flake 8 | http://flake8.pycqa.org/en/latest/ |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
|
Oct 9, 2018
| https://github.com/matplotlib/matplotlib/pull/12455#pullrequestreview-162717318 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/12455/files |
| lib/matplotlib/legend.py | https://github.com/matplotlib/matplotlib/pull/12455/files#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-428238744 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-428263731 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-428279045 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-428287533 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-428327074 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Oct 9, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-428332785 |
| https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/font_manager.py#L231 | https://github.com/matplotlib/matplotlib/blob/master/lib/matplotlib/font_manager.py#L231 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
| Oct 11, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-428970454 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/tacaswell |
| tacaswell | https://github.com/tacaswell |
| v3.1 | https://github.com/matplotlib/matplotlib/milestone/35 |
| Oct 11, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#event-1898573513 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
| Oct 11, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-429018871 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
| Oct 11, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-429021426 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| #7121 (comment) | https://github.com/matplotlib/matplotlib/issues/7121#issuecomment-248157784 |
| @tacaswell | https://github.com/tacaswell |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/jklymak |
| jklymak | https://github.com/jklymak |
|
Performance
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3APerformance |
| Oct 17, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#event-1910041977 |
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
| Oct 17, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-430788193 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
| Nov 15, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-438873233 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| kbrose | https://github.com/kbrose |
| November 14, 2018 18:49 | https://github.com/matplotlib/matplotlib/pull/12455#commits-pushed-b30e93b |
|
| https://github.com/kbrose |
| Warn when "best" loc of legend is used with lots of data | https://github.com/matplotlib/matplotlib/pull/12455/commits/b30e93b43b595e31be226100d490c81964c87d1f |
| b30e93b | https://github.com/matplotlib/matplotlib/pull/12455/commits/b30e93b43b595e31be226100d490c81964c87d1f |
|
| https://github.com/kbrose |
| Increase size limit before warning | https://github.com/matplotlib/matplotlib/pull/12455/commits/cf1d30faf6525c05147c38afc2317667060e3c91 |
| cf1d30f | https://github.com/matplotlib/matplotlib/pull/12455/commits/cf1d30faf6525c05147c38afc2317667060e3c91 |
|
| https://github.com/kbrose |
| Update data size in test | https://github.com/matplotlib/matplotlib/pull/12455/commits/f7be89ecd29174750132a1184d48e043911e1ab1 |
| f7be89e | https://github.com/matplotlib/matplotlib/pull/12455/commits/f7be89ecd29174750132a1184d48e043911e1ab1 |
|
| https://github.com/kbrose |
| Only warn if best was used by default | https://github.com/matplotlib/matplotlib/pull/12455/commits/b6e044bac6f75cb5f117f848679544350f4e11e9 |
| b6e044b | https://github.com/matplotlib/matplotlib/pull/12455/commits/b6e044bac6f75cb5f117f848679544350f4e11e9 |
|
| https://github.com/kbrose |
| Add test that no warning is issued when best specified manually | https://github.com/matplotlib/matplotlib/pull/12455/commits/6bce43f089c8559af80c6c2168d4efd0c1659567 |
| 6bce43f | https://github.com/matplotlib/matplotlib/pull/12455/commits/6bce43f089c8559af80c6c2168d4efd0c1659567 |
|
| https://github.com/kbrose |
| update to new way of warning after rebase | https://github.com/matplotlib/matplotlib/pull/12455/commits/504f61916d0714f10587ee207a4be62bd366d3cf |
| 504f619 | https://github.com/matplotlib/matplotlib/pull/12455/commits/504f61916d0714f10587ee207a4be62bd366d3cf |
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/8472e457b3dd910ad9707967ed0b4b1964a04626..504f61916d0714f10587ee207a4be62bd366d3cf |
| 8472e45 | https://github.com/matplotlib/matplotlib/commit/8472e457b3dd910ad9707967ed0b4b1964a04626 |
| 504f619 | https://github.com/matplotlib/matplotlib/commit/504f61916d0714f10587ee207a4be62bd366d3cf |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/8472e457b3dd910ad9707967ed0b4b1964a04626..504f61916d0714f10587ee207a4be62bd366d3cf |
| November 15, 2018 00:51 | https://github.com/matplotlib/matplotlib/pull/12455#event-1967411317 |
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
| Nov 15, 2018 | https://github.com/matplotlib/matplotlib/pull/12455#issuecomment-438874658 |
| #12006 | https://github.com/matplotlib/matplotlib/pull/12006 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
|
| https://github.com/kbrose |
| Remove unnecessarily copied comment in test | https://github.com/matplotlib/matplotlib/pull/12455/commits/7997f4d034fec004d192392b44883c24bff2915f |
| 7997f4d | https://github.com/matplotlib/matplotlib/pull/12455/commits/7997f4d034fec004d192392b44883c24bff2915f |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Nov 17, 2018
| https://github.com/matplotlib/matplotlib/pull/12455#pullrequestreview-176057642 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/12455/files/7997f4d034fec004d192392b44883c24bff2915f |
| lib/matplotlib/legend.py | https://github.com/matplotlib/matplotlib/pull/12455/files/7997f4d034fec004d192392b44883c24bff2915f#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| lib/matplotlib/tests/test_legend.py | https://github.com/matplotlib/matplotlib/pull/12455/files/7997f4d034fec004d192392b44883c24bff2915f#diff-1b573023d84935306a147bec7f137e59ae79c3d4f3bbea81152eb0c94b58a579 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| kbrose | https://github.com/kbrose |
| November 17, 2018 10:24 | https://github.com/matplotlib/matplotlib/pull/12455#commits-pushed-0365455 |
|
| https://github.com/kbrose |
| use rc_context, thanks | https://github.com/matplotlib/matplotlib/pull/12455/commits/03654551a3a3707b3b86a79538fe91611829d132 |
| @timhoffm | https://github.com/timhoffm |
| for the tip | https://github.com/matplotlib/matplotlib/pull/12455/commits/03654551a3a3707b3b86a79538fe91611829d132 |
| 0365455 | https://github.com/matplotlib/matplotlib/pull/12455/commits/03654551a3a3707b3b86a79538fe91611829d132 |
|
| https://github.com/kbrose |
| forgot to import rc_context after rebase | https://github.com/matplotlib/matplotlib/pull/12455/commits/f01b674463a3027f6341426addf3ac4eb94391fd |
| f01b674 | https://github.com/matplotlib/matplotlib/pull/12455/commits/f01b674463a3027f6341426addf3ac4eb94391fd |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Nov 17, 2018
| https://github.com/matplotlib/matplotlib/pull/12455#pullrequestreview-176063630 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/12455/files/f01b674463a3027f6341426addf3ac4eb94391fd |
| lib/matplotlib/legend.py | https://github.com/matplotlib/matplotlib/pull/12455/files/7997f4d034fec004d192392b44883c24bff2915f#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| lib/matplotlib/legend.py | https://github.com/matplotlib/matplotlib/pull/12455/files/f01b674463a3027f6341426addf3ac4eb94391fd#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| lib/matplotlib/legend.py | https://github.com/matplotlib/matplotlib/pull/12455/files/f01b674463a3027f6341426addf3ac4eb94391fd#diff-e7a00bb4a353fa623c1d0c1de5c6ca602b7ab38e8906d4842640983133b9196a |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| timhoffm | https://github.com/timhoffm |
| November 21, 2018 17:54 | https://github.com/matplotlib/matplotlib/pull/12455#commits-pushed-2cb3550 |
|
| https://github.com/timhoffm |
|
| https://github.com/kbrose |
| Incorporate | https://github.com/matplotlib/matplotlib/pull/12455/commits/2cb35505557edf1add41de3f1c395ce18e500617 |
| @timhoffm | https://github.com/timhoffm |
| style change | https://github.com/matplotlib/matplotlib/pull/12455/commits/2cb35505557edf1add41de3f1c395ce18e500617 |
| 2cb3550 | https://github.com/matplotlib/matplotlib/pull/12455/commits/2cb35505557edf1add41de3f1c395ce18e500617 |
|
| https://github.com/timhoffm |
|
| https://github.com/kbrose |
| Incorporate | https://github.com/matplotlib/matplotlib/pull/12455/commits/282ac5340975716314b0f5c097b4081b728ff4d1 |
| @timhoffm | https://github.com/timhoffm |
| style change | https://github.com/matplotlib/matplotlib/pull/12455/commits/282ac5340975716314b0f5c097b4081b728ff4d1 |
| 282ac53 | https://github.com/matplotlib/matplotlib/pull/12455/commits/282ac5340975716314b0f5c097b4081b728ff4d1 |
|
| https://github.com/kbrose |
| Some more refactoring courtesy of | https://github.com/matplotlib/matplotlib/pull/12455/commits/f89a78cd4f74efb8d9c1cee1514a270214fcdd70 |
| @timhoffm | https://github.com/timhoffm |
| f89a78c | https://github.com/matplotlib/matplotlib/pull/12455/commits/f89a78cd4f74efb8d9c1cee1514a270214fcdd70 |
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
| force-pushed | https://github.com/matplotlib/matplotlib/compare/bc91f463745a7168526d39007321acc7dda93d60..f89a78cd4f74efb8d9c1cee1514a270214fcdd70 |
| bc91f46 | https://github.com/matplotlib/matplotlib/commit/bc91f463745a7168526d39007321acc7dda93d60 |
| f89a78c | https://github.com/matplotlib/matplotlib/commit/f89a78cd4f74efb8d9c1cee1514a270214fcdd70 |
|
Compare
| https://github.com/matplotlib/matplotlib/compare/bc91f463745a7168526d39007321acc7dda93d60..f89a78cd4f74efb8d9c1cee1514a270214fcdd70 |
| November 22, 2018 00:02 | https://github.com/matplotlib/matplotlib/pull/12455#event-1981336699 |
| https://github.com/timhoffm |
| timhoffm | https://github.com/timhoffm |
|
Nov 22, 2018
| https://github.com/matplotlib/matplotlib/pull/12455#pullrequestreview-177474719 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/12455/files/f89a78cd4f74efb8d9c1cee1514a270214fcdd70 |
| https://github.com/NelleV |
| NelleV | https://github.com/NelleV |
|
Jan 21, 2019
| https://github.com/matplotlib/matplotlib/pull/12455#pullrequestreview-194461637 |
|
View reviewed changes
| https://github.com/matplotlib/matplotlib/pull/12455/files/f89a78cd4f74efb8d9c1cee1514a270214fcdd70 |
| NelleV | https://github.com/NelleV |
| https://github.com/matplotlib/matplotlib/pull/12455#pullrequestreview-194461637 |
| Learn more | https://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment |
| @kbrose | https://github.com/kbrose |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
| https://github.com/NelleV |
| NelleV | https://github.com/NelleV |
| 5702999 | https://github.com/matplotlib/matplotlib/commit/5702999ffd64e2428a0202bb9dd7b079f7763092 |
| Jan 21, 2019 | https://github.com/matplotlib/matplotlib/pull/12455#event-2085572839 |
| https://github.com/kbrose |
| kbrose | https://github.com/kbrose |
| January 21, 2019 23:24 | https://github.com/matplotlib/matplotlib/pull/12455#event-2087488661 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Feb 25, 2019
| https://github.com/matplotlib/matplotlib/pull/12455#ref-pullrequest-375692312 |
|
ENH: Introduce compass-notation for legend
#12679
| https://github.com/matplotlib/matplotlib/pull/12679 |
| https://github.com/anntzer |
| anntzer | https://github.com/anntzer |
|
Jul 26, 2019
| https://github.com/matplotlib/matplotlib/pull/12455#ref-pullrequest-473363036 |
|
Make slowness warning for legend(loc="best") more accurate.
#14894
| https://github.com/matplotlib/matplotlib/pull/14894 |
| https://github.co/hiddenchars |
| https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }} |
| Sign up for free | https://github.com/join?source=comment-repo |
| Sign in to comment | https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F12455 |
|
| https://github.com/NelleV |
|
NelleV
| https://github.com/NelleV |
|
| https://github.com/matplotlib/matplotlib/pull/12455/files/f89a78cd4f74efb8d9c1cee1514a270214fcdd70 |
|
| https://github.com/timhoffm |
|
timhoffm
| https://github.com/timhoffm |
|
| https://github.com/matplotlib/matplotlib/pull/12455/files/f89a78cd4f74efb8d9c1cee1514a270214fcdd70 |
|
Performance
| https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3APerformance |
|
v3.1.0
| https://github.com/matplotlib/matplotlib/milestone/35 |
| Please reload this page | https://github.com/matplotlib/matplotlib/pull/12455 |
|
| https://github.com/kbrose |
|
| https://github.com/jklymak |
|
| https://github.com/timhoffm |
|
| https://github.com/anntzer |
|
| https://github.com/NelleV |
|
| https://github.com/tacaswell |
|
| https://github.com |
| Terms | https://docs.github.com/site-policy/github-terms/github-terms-of-service |
| Privacy | https://docs.github.com/site-policy/privacy-policies/github-privacy-statement |
| Security | https://github.com/security |
| Status | https://www.githubstatus.com/ |
| Community | https://github.community/ |
| Docs | https://docs.github.com/ |
| Contact | https://support.github.com?tags=dotcom-footer |