Title: Unbreak formlayout for image edits. by anntzer · Pull Request #12142 · matplotlib/matplotlib · GitHub
Open Graph Title: Unbreak formlayout for image edits. by anntzer · Pull Request #12142 · matplotlib/matplotlib
X Title: Unbreak formlayout for image edits. by anntzer · Pull Request #12142 · matplotlib/matplotlib
Description: As of master, the qt editor is broken when editing an axes that contains an image throws an error when clicking OK. This is because self.data needs to be modified in-place in FormWidget.setup, as FormWidget.get later checks some explicit types in there. This means, as a side note, that passing a tuple instead of a list to generate a QComboBox is broken (one can test that by modifying the example at the bottom of the module -- the results are different depending on whether 'list2' is a list or a tuple) but that's something we can deal with some other day... Partial revert of #11684 (well, I naively assumed that the base code was correct...). PR Summary PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: As of master, the qt editor is broken when editing an axes that contains an image throws an error when clicking OK. This is because self.data needs to be modified in-place in FormWidget.setup, as ...
X Description: As of master, the qt editor is broken when editing an axes that contains an image throws an error when clicking OK. This is because self.data needs to be modified in-place in FormWidget.setup, as ...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/12142
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:05ff8a27-0f70-98b9-7d74-5ee27f9ab76e |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | ADCE:9EC5C:71FD14:A375D5:6A549311 |
| html-safe-nonce | ab367a26333f8865761c73da6317fb1769b4a08d03f9b14a12d72e8b30ee1fbe |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRENFOjlFQzVDOjcxRkQxNDpBMzc1RDU6NkE1NDkzMTEiLCJ2aXNpdG9yX2lkIjoiODA3ODU3NTQyMjQ0OTk0NzQwOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | cd0477f859c60812defc17c57bf17ce217d505b233ca2c3d124fc331a5084f13 |
| hovercard-subject-tag | pull_request:216028757 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/12142/files |
| twitter:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1322974?s=400&v=4 |
| og:image:alt | As of master, the qt editor is broken when editing an axes that contains an image throws an error when clicking OK. This is because self.data needs to be modified in-place in FormWidget.setup, as ... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | f8cfff6384f62259baea531c7f58bc7040f8dd92 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width