René's URL Explorer Experiment

Title: Fix wrong error message in #11919 by davidleejy · Pull Request #11930 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix wrong error message in #11919 by davidleejy · Pull Request #11930 · matplotlib/matplotlib

X Title: Fix wrong error message in #11919 by davidleejy · Pull Request #11930 · matplotlib/matplotlib

Description: PR Summary Fixes issue #11919 . This PR chains (appropriate) exceptions raised by mcolors.to_rgba_array() to additional exceptions raised by its caller scatter(). Now, the exception raised by mcolors.to_rgba_array() is visible if color values are outside of 0 to 1 range. Prior to this PR, exceptions are not chained - see commit e3a8004. Exceptions raised by mcolors.to_rgba_array() were suppressed by exceptions of its caller scatter(). This PR applies exception chaining solely on scatter function. Author is open to helping chain other exceptions. PEP 3134 advises on Exception Chaining. Example use: https://stackoverflow.com/questions/16414744/python-exception-chaining Outcome Case 1: color values outside 0 to 1 range python -c "import numpy as np; import matplotlib.pyplot as plt; f =plt.figure(); ax = plt.axes(); ax.scatter(np.array([2]), np.array([3]), c=np.array([[12,130,140]]))" Traceback (most recent call last): File "", line 1, in File "/home/d/code/dljy-matplotlib/lib/matplotlib/__init__.py", line 1764, in inner return func(ax, *args, **kwargs) File "/home/d/code/dljy-matplotlib/lib/matplotlib/axes/_axes.py", line 4232, in scatter raise e File "/home/d/code/dljy-matplotlib/lib/matplotlib/axes/_axes.py", line 4210, in scatter colors = mcolors.to_rgba_array(c) File "/home/d/code/dljy-matplotlib/lib/matplotlib/colors.py", line 244, in to_rgba_array raise ValueError("RGBA values should be within 0-1 range") ValueError: RGBA values should be within 0-1 range Case 2: color array is wrong shape python -c "import numpy as np; import matplotlib.pyplot as plt; f =plt.figure(); ax = plt.axes(); ax.scatter(np.array([2]), np.array([3]), c=np.array([[.12,.130,.140],[.1,.1,.1]]))" Traceback (most recent call last): File "", line 1, in File "/home/d/code/dljy-matplotlib/lib/matplotlib/__init__.py", line 1764, in inner return func(ax, *args, **kwargs) File "/home/d/code/dljy-matplotlib/lib/matplotlib/axes/_axes.py", line 4232, in scatter raise e File "/home/d/code/dljy-matplotlib/lib/matplotlib/axes/_axes.py", line 4220, in scatter .format(nc=n_elem, xs=x.size, ys=y.size) ValueError: 'c' argument has 2 elements, which is not acceptable for use with 'x' with size 1, 'y' with size 1. Case 3: color is 'jaune' python -c "import numpy as np; import matplotlib.pyplot as plt; f =plt.figure(); ax = plt.axes(); ax.scatter(np.array([2]), np.array([3]), c='jaune')" Traceback (most recent call last): File "/home/d/code/dljy-matplotlib/lib/matplotlib/colors.py", line 158, in to_rgba rgba = _colors_full_map.cache[c, alpha] KeyError: ('j', None) During handling of the above exception, another exception occurred: Traceback (most recent call last): File "/home/d/code/dljy-matplotlib/lib/matplotlib/axes/_axes.py", line 4210, in scatter colors = mcolors.to_rgba_array(c) File "/home/d/code/dljy-matplotlib/lib/matplotlib/colors.py", line 259, in to_rgba_array result[i] = to_rgba(cc, alpha) File "/home/d/code/dljy-matplotlib/lib/matplotlib/colors.py", line 160, in to_rgba rgba = _to_rgba_no_colorcycle(c, alpha) File "/home/d/code/dljy-matplotlib/lib/matplotlib/colors.py", line 204, in _to_rgba_no_colorcycle raise ValueError("Invalid RGBA argument: {!r}".format(orig_c)) ValueError: Invalid RGBA argument: 'j' The above exception was the direct cause of the following exception: Traceback (most recent call last): File "", line 1, in File "/home/d/code/dljy-matplotlib/lib/matplotlib/__init__.py", line 1764, in inner return func(ax, *args, **kwargs) File "/home/d/code/dljy-matplotlib/lib/matplotlib/axes/_axes.py", line 4231, in scatter ) from e ValueError: 'c' argument must either be valid as mpl color(s) or as numbers to be mapped to colors. Here c = jaune. PR Checklist Has Pytest style unit tests Code is Flake 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Open Graph Description: PR Summary Fixes issue #11919 . This PR chains (appropriate) exceptions raised by mcolors.to_rgba_array() to additional exceptions raised by its caller scatter(). Now, the exception raised by mcol...

X Description: PR Summary Fixes issue #11919 . This PR chains (appropriate) exceptions raised by mcolors.to_rgba_array() to additional exceptions raised by its caller scatter(). Now, the exception raised by mcol...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/11930

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width