René's URL Explorer Experiment


Title: Change {FigureCanvasAgg,RendererAgg}.buffer_rgba to return a memoryview. by anntzer · Pull Request #11735 · matplotlib/matplotlib · GitHub

Open Graph Title: Change {FigureCanvasAgg,RendererAgg}.buffer_rgba to return a memoryview. by anntzer · Pull Request #11735 · matplotlib/matplotlib

X Title: Change {FigureCanvasAgg,RendererAgg}.buffer_rgba to return a memoryview. by anntzer · Pull Request #11735 · matplotlib/matplotlib

Description: The buffer_rgba method now allows direct access to the renderer's underlying buffer (as a (m, n, 4)-shape memoryview) rather than copying the data to a new bytestring. This is consistent with the behavior on Py2, where a buffer object was returned. While this is technically a backwards-incompatible change, memoryviews are in fact quite compatible with bytes for most uses, and I'd argue that the bigger compatibility break was the change from no-copy in Py2 to copy in Py3 (after all that's the main point of the method...). See also discussion in #11726. Added second commit: reimplement tostring_rgba, tostring_rgb using numpy to access the buffer. Note that this was one of the suggestions of the original removal of PyCXX (#3646) :-) PR Summary PR Checklist Has Pytest style unit tests Code is PEP 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Open Graph Description: The buffer_rgba method now allows direct access to the renderer's underlying buffer (as a (m, n, 4)-shape memoryview) rather than copying the data to a new bytestring. This is consistent with ...

X Description: The buffer_rgba method now allows direct access to the renderer's underlying buffer (as a (m, n, 4)-shape memoryview) rather than copying the data to a new bytestring. This is consistent w...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/11735

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:3b5253ef-39a5-ed29-be8e-004e0f2b4d13
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBDEA:B33E1:B7EC60:FCEF7F:6A572534
html-safe-noncef0f44e4e5b692fbd1649602edab6c2f2c53e26221278d53e630c82f0e1fd5de2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCREVBOkIzM0UxOkI3RUM2MDpGQ0VGN0Y6NkE1NzI1MzQiLCJ2aXNpdG9yX2lkIjoiODc4NTQ4MjcyODE5NDEyMzA2MCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaccea8dbae36f6851457b48e19385e0583a1b784ead94290846983665f38959afb
hovercard-subject-tagpull_request:203057410
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/11735/files
twitter:imagehttps://avatars.githubusercontent.com/u/1322974?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1322974?s=400&v=4
og:image:altThe buffer_rgba method now allows direct access to the renderer's underlying buffer (as a (m, n, 4)-shape memoryview) rather than copying the data to a new bytestring. This is consistent with ...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None4e7a7296a3830877cf21a6ad2a972c9e618a48915e03966cf0c53eb08e5aad98
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2576d1f0198cf1588faf2edf27f1ed120903be10
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/11735/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F11735%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F11735%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/11735/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/11735/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/11735/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11735/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11735/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 410 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
QuLogichttps://github.com/QuLogic
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
anntzer:aggbufferrgbahttps://github.com/anntzer/matplotlib/tree/aggbufferrgba
Conversation 7 https://github.com/matplotlib/matplotlib/pull/11735
Commits 2 https://github.com/matplotlib/matplotlib/pull/11735/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/11735/checks
Files changed https://github.com/matplotlib/matplotlib/pull/11735/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11735/files
Change {FigureCanvasAgg,RendererAgg}.buffer_rgba to return a memoryview. https://github.com/matplotlib/matplotlib/pull/11735/files#top
Show all changes 2 commits https://github.com/matplotlib/matplotlib/pull/11735/files
54cd9ce Change {FigureCanvasAgg,RendererAgg}.buffer_rgba to return a memoryview. anntzer Jul 22, 2018 https://github.com/matplotlib/matplotlib/pull/11735/commits/54cd9ceeac50d2a986c86a1c98cc67113dc73381
5c16eca Use numpy.take instead of C-level manipulations for tostring_argb etc. anntzer Jul 23, 2018 https://github.com/matplotlib/matplotlib/pull/11735/commits/5c16eca829c3ec1dccdd9c31dfb98000fc0f8953
Clear filters https://github.com/matplotlib/matplotlib/pull/11735/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11735/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11735/files
2018-07-22-AL.rst https://github.com/matplotlib/matplotlib/pull/11735/files#diff-4573623adc0901d8fe78fd0b78c0b417aba8ee7059d54b5bd8208868f207ad96
agg_buffer_to_array.py https://github.com/matplotlib/matplotlib/pull/11735/files#diff-13103f1f07b1ec544d22bc1e6eb97ffffed5668968c641b548bba42d3e639b2d
backend_agg.py https://github.com/matplotlib/matplotlib/pull/11735/files#diff-0a415dbb618fcfb73e6191c735f6e5a91f530d4a29b8886afdfd56604892de61
_backend_agg.cpp https://github.com/matplotlib/matplotlib/pull/11735/files#diff-bd30be7fdf9f73d70ce643e564d6d83a124832850504a0d5df90b3cfc5123cf4
_backend_agg.h https://github.com/matplotlib/matplotlib/pull/11735/files#diff-34559c7ee959645e82cd258d9684eab40456cbfa5b417fed59780e07ea670df7
_backend_agg_wrapper.cpp https://github.com/matplotlib/matplotlib/pull/11735/files#diff-f3dd8a3c75d95382019d5d8bb7deb2251a857f12e36470d1de3df3a2899b0ab2
doc/api/next_api_changes/2018-07-22-AL.rsthttps://github.com/matplotlib/matplotlib/pull/11735/files#diff-4573623adc0901d8fe78fd0b78c0b417aba8ee7059d54b5bd8208868f207ad96
View file https://github.com/anntzer/matplotlib/blob/5c16eca829c3ec1dccdd9c31dfb98000fc0f8953/doc/api/next_api_changes/2018-07-22-AL.rst
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/11735/{{ revealButtonHref }}
examples/misc/agg_buffer_to_array.pyhttps://github.com/matplotlib/matplotlib/pull/11735/files#diff-13103f1f07b1ec544d22bc1e6eb97ffffed5668968c641b548bba42d3e639b2d
View file https://github.com/anntzer/matplotlib/blob/5c16eca829c3ec1dccdd9c31dfb98000fc0f8953/examples/misc/agg_buffer_to_array.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/11735/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-13103f1f07b1ec544d22bc1e6eb97ffffed5668968c641b548bba42d3e639b2d
pelsonhttps://github.com/pelson
Dec 19, 2018https://github.com/matplotlib/matplotlib/pull/11735/files#r242933975
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11735/files
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-13103f1f07b1ec544d22bc1e6eb97ffffed5668968c641b548bba42d3e639b2d
lib/matplotlib/backends/backend_agg.pyhttps://github.com/matplotlib/matplotlib/pull/11735/files#diff-0a415dbb618fcfb73e6191c735f6e5a91f530d4a29b8886afdfd56604892de61
View file https://github.com/anntzer/matplotlib/blob/5c16eca829c3ec1dccdd9c31dfb98000fc0f8953/lib/matplotlib/backends/backend_agg.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/11735/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-0a415dbb618fcfb73e6191c735f6e5a91f530d4a29b8886afdfd56604892de61
pelsonhttps://github.com/pelson
Dec 19, 2018https://github.com/matplotlib/matplotlib/pull/11735/files#r242935763
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11735/files
anntzerhttps://github.com/anntzer
Dec 19, 2018https://github.com/matplotlib/matplotlib/pull/11735/files#r243031934
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11735/files
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-0a415dbb618fcfb73e6191c735f6e5a91f530d4a29b8886afdfd56604892de61
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-0a415dbb618fcfb73e6191c735f6e5a91f530d4a29b8886afdfd56604892de61
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-0a415dbb618fcfb73e6191c735f6e5a91f530d4a29b8886afdfd56604892de61
src/_backend_agg.cpphttps://github.com/matplotlib/matplotlib/pull/11735/files#diff-bd30be7fdf9f73d70ce643e564d6d83a124832850504a0d5df90b3cfc5123cf4
View file https://github.com/anntzer/matplotlib/blob/5c16eca829c3ec1dccdd9c31dfb98000fc0f8953/src/_backend_agg.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/11735/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-bd30be7fdf9f73d70ce643e564d6d83a124832850504a0d5df90b3cfc5123cf4
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-bd30be7fdf9f73d70ce643e564d6d83a124832850504a0d5df90b3cfc5123cf4
src/_backend_agg.hhttps://github.com/matplotlib/matplotlib/pull/11735/files#diff-34559c7ee959645e82cd258d9684eab40456cbfa5b417fed59780e07ea670df7
View file https://github.com/anntzer/matplotlib/blob/5c16eca829c3ec1dccdd9c31dfb98000fc0f8953/src/_backend_agg.h
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/11735/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-34559c7ee959645e82cd258d9684eab40456cbfa5b417fed59780e07ea670df7
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-34559c7ee959645e82cd258d9684eab40456cbfa5b417fed59780e07ea670df7
src/_backend_agg_wrapper.cpphttps://github.com/matplotlib/matplotlib/pull/11735/files#diff-f3dd8a3c75d95382019d5d8bb7deb2251a857f12e36470d1de3df3a2899b0ab2
View file https://github.com/anntzer/matplotlib/blob/5c16eca829c3ec1dccdd9c31dfb98000fc0f8953/src/_backend_agg_wrapper.cpp
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/11735/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-f3dd8a3c75d95382019d5d8bb7deb2251a857f12e36470d1de3df3a2899b0ab2
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-f3dd8a3c75d95382019d5d8bb7deb2251a857f12e36470d1de3df3a2899b0ab2
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-f3dd8a3c75d95382019d5d8bb7deb2251a857f12e36470d1de3df3a2899b0ab2
https://github.com/matplotlib/matplotlib/pull/11735/files#diff-f3dd8a3c75d95382019d5d8bb7deb2251a857f12e36470d1de3df3a2899b0ab2
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.