René's URL Explorer Experiment


Title: FIX: make update-from also set the original face/edgecolor by jklymak · Pull Request #11703 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: make update-from also set the original face/edgecolor by jklymak · Pull Request #11703 · matplotlib/matplotlib

X Title: FIX: make update-from also set the original face/edgecolor by jklymak · Pull Request #11703 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary Closes #11702... patches.update_from wasn't setting _original_face/edgecolor PR Checklist Has Pytest style unit tests Code is PEP 8 compliant New features are documented, with ex...

X Description: PR Summary Closes #11702... patches.update_from wasn't setting _original_face/edgecolor PR Checklist Has Pytest style unit tests Code is PEP 8 compliant New features are documented, wit...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/11703

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:c2e089e1-1c12-09a2-778e-2a9885f29c1f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8F52:2A736A:132D666:195E7F5:6A534041
html-safe-nonce8e471e901663ea6ac6469b5c6cf392bd9d0bc17dafc509e855a728cd05ceb4f2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4RjUyOjJBNzM2QToxMzJENjY2OjE5NUU3RjU6NkE1MzQwNDEiLCJ2aXNpdG9yX2lkIjoiNTIzMzc2MzgxMzQzODk5NjU0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac6a6b63ccb0df678f1cfb244de82ae69915a539d222875ae96b3e8b7331698215
hovercard-subject-tagpull_request:202429190
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/11703/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/5c23b5f84336a216b54b85daadba63695c0979ebfacd7dcc123e05be436b6cea/matplotlib/matplotlib/pull/11703
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5c23b5f84336a216b54b85daadba63695c0979ebfacd7dcc123e05be436b6cea/matplotlib/matplotlib/pull/11703
og:image:altPR Summary Closes #11702... patches.update_from wasn't setting _original_face/edgecolor PR Checklist Has Pytest style unit tests Code is PEP 8 compliant New features are documented, with ex...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejklymak
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/11703#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F11703
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F11703
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/11703
Reloadhttps://github.com/matplotlib/matplotlib/pull/11703
Reloadhttps://github.com/matplotlib/matplotlib/pull/11703
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11703
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11703
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
phobsonhttps://github.com/phobson
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-update-from-patcheshttps://github.com/jklymak/matplotlib/tree/fix-update-from-patches
Conversationhttps://github.com/matplotlib/matplotlib/pull/11703
Commits2 (2)https://github.com/matplotlib/matplotlib/pull/11703/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/11703/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/11703/files
FIX: make update-from also set the original face/edgecolorhttps://github.com/matplotlib/matplotlib/pull/11703#top
phobsonhttps://github.com/phobson
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-update-from-patcheshttps://github.com/jklymak/matplotlib/tree/fix-update-from-patches
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Jul 19, 2018https://github.com/matplotlib/matplotlib/pull/11703#issue-342556747
#11702https://github.com/matplotlib/matplotlib/issues/11702
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11703
https://github.com/jklymak
FIX: make update-from also set the original face/edgecoloehttps://github.com/matplotlib/matplotlib/pull/11703/commits/c28818a887e8e4fdd9b0ec504cd3ad412c63139c
c28818ahttps://github.com/matplotlib/matplotlib/pull/11703/commits/c28818a887e8e4fdd9b0ec504cd3ad412c63139c
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Jul 19, 2018 https://github.com/matplotlib/matplotlib/pull/11703#ref-issue-342548873
Setting alpha on legend handle changes patch color #11702 https://github.com/matplotlib/matplotlib/issues/11702
https://github.com/jklymak
TST: test that setting alpha keeps rest of color okhttps://github.com/matplotlib/matplotlib/pull/11703/commits/af43dae448d5938403ef4bb699cc74e22d051ca0
af43daehttps://github.com/matplotlib/matplotlib/pull/11703/commits/af43dae448d5938403ef4bb699cc74e22d051ca0
https://github.com/jklymak
jklymakhttps://github.com/jklymak
force-pushedhttps://github.com/matplotlib/matplotlib/compare/ab09f2c98b898136ca4441551edc5722413f9d36..af43dae448d5938403ef4bb699cc74e22d051ca0
ab09f2chttps://github.com/matplotlib/matplotlib/commit/ab09f2c98b898136ca4441551edc5722413f9d36
af43daehttps://github.com/matplotlib/matplotlib/commit/af43dae448d5938403ef4bb699cc74e22d051ca0
Compare https://github.com/matplotlib/matplotlib/compare/ab09f2c98b898136ca4441551edc5722413f9d36..af43dae448d5938403ef4bb699cc74e22d051ca0
July 19, 2018 04:31https://github.com/matplotlib/matplotlib/pull/11703#event-1741637627
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Jul 20, 2018 https://github.com/matplotlib/matplotlib/pull/11703#pullrequestreview-138949486
View reviewed changes https://github.com/matplotlib/matplotlib/pull/11703/files/af43dae448d5938403ef4bb699cc74e22d051ca0
anntzerhttps://github.com/anntzer
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11703
https://github.com/matplotlib/matplotlib/pull/11703#pullrequestreview-138949486
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#11710https://github.com/matplotlib/matplotlib/issues/11710
#11711https://github.com/matplotlib/matplotlib/pull/11711
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11703
Patches eagerly resolve colors and apply alpha, but should do so lazily like Line2Ds #11710 https://github.com/matplotlib/matplotlib/issues/11710
Lazily resolve colors for Patches. #11711 https://github.com/matplotlib/matplotlib/pull/11711
https://github.com/phobson
phobsonhttps://github.com/phobson
Jul 27, 2018 https://github.com/matplotlib/matplotlib/pull/11703#pullrequestreview-141158562
View reviewed changes https://github.com/matplotlib/matplotlib/pull/11703/files/af43dae448d5938403ef4bb699cc74e22d051ca0
https://github.com/phobson
phobsonhttps://github.com/phobson
c552bdchttps://github.com/matplotlib/matplotlib/commit/c552bdc116ad518d988461a28a2dd43ca342f2ee
Jul 27, 2018https://github.com/matplotlib/matplotlib/pull/11703#event-1757533067
https://github.com/jklymak
jklymakhttps://github.com/jklymak
July 27, 2018 15:24https://github.com/matplotlib/matplotlib/pull/11703#event-1757535255
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
v3.0https://github.com/matplotlib/matplotlib/milestone/23
Jul 27, 2018https://github.com/matplotlib/matplotlib/pull/11703#event-1758115045
Default color after setting alptha to Patch in legened #10574 https://github.com/matplotlib/matplotlib/issues/10574
FIX patch.update_from to also copy _original_edge/facecolor #10575 https://github.com/matplotlib/matplotlib/pull/10575
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 15, 2021 https://github.com/matplotlib/matplotlib/pull/11703#ref-issue-1081262421
[Bug]: Regression: Setting alpha on legend handle changes patch color #21966 https://github.com/matplotlib/matplotlib/issues/21966
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F11703
https://github.com/phobson
phobson https://github.com/phobson
https://github.com/matplotlib/matplotlib/pull/11703/files/af43dae448d5938403ef4bb699cc74e22d051ca0
https://github.com/anntzer
anntzer https://github.com/anntzer
https://github.com/matplotlib/matplotlib/pull/11703/files/af43dae448d5938403ef4bb699cc74e22d051ca0
v3.0.0 https://github.com/matplotlib/matplotlib/milestone/23
Setting alpha on legend handle changes patch color https://github.com/matplotlib/matplotlib/issues/11702
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11703
https://github.com/jklymak
https://github.com/phobson
https://github.com/anntzer
https://github.com/QuLogic
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.