René's URL Explorer Experiment


Title: Refactor color parsing of Axes.scatter by timhoffm · Pull Request #11663 · matplotlib/matplotlib · GitHub

Open Graph Title: Refactor color parsing of Axes.scatter by timhoffm · Pull Request #11663 · matplotlib/matplotlib

X Title: Refactor color parsing of Axes.scatter by timhoffm · Pull Request #11663 · matplotlib/matplotlib

Description: PR Summary As discussed in #11383, it would be helpful to extract the color parameter parsing of Axes.scatter() to a separate method. This helps in managing the complexity of the code: separted from other stuff in scatter(), easier and faster to test because one does need a figure to test the parameter parsing. Some things that can be improved in the future, but are beyond the scope of this PR: I did only some simple refactorings so far. I'm quite sure this function can be untangled more. This will become easier after this PR, because we can now add a further tests. The tests from TestScatter::test_scatter_c should be moved to simple tests on the Axes._parse_scatter_color_args later on. Ideally, Axes._parse_scatter_color_args would be a static method. So far, it still has a single self reference for obtaining self._get_patches_for_fill.get_next_color(). We cannot easily get rid of that. Passing the fallback color in is not an option, because it's only evaluated conditionally and evaluation has the side effect of advancing the color cycle. On the other hand, we cannot return a 'DUMMY_FALLBACK_COLOR' and evaluate it outside the method, because the result is further processed within the method. Good ideas how to handle this are welcome. PR Checklist Has Pytest style unit tests Code is PEP 8 compliant

Open Graph Description: PR Summary As discussed in #11383, it would be helpful to extract the color parameter parsing of Axes.scatter() to a separate method. This helps in managing the complexity of the code: separted fro...

X Description: PR Summary As discussed in #11383, it would be helpful to extract the color parameter parsing of Axes.scatter() to a separate method. This helps in managing the complexity of the code: separted fro...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/11663

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8e35b08c-1f47-a9dc-d48a-2e1a5baa09de
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idB454:3F34E9:22B22:2E33A:6A5543C0
html-safe-nonce65443b6463a56cb1700393aa2638c442031ea5e5e7897ad7cf0c6d0466866f98
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNDU0OjNGMzRFOToyMkIyMjoyRTMzQTo2QTU1NDNDMCIsInZpc2l0b3JfaWQiOiI0NjM2NzY4MDEwNzQ0NzEwMDgwIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9e9e7d69e64698a0ea409e052a46a3ed509d14e5232e194ccc7d150a6c8975ea
hovercard-subject-tagpull_request:201506233
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/11663/files
twitter:imagehttps://avatars.githubusercontent.com/u/2836374?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/2836374?s=400&v=4
og:image:altPR Summary As discussed in #11383, it would be helpful to extract the color parameter parsing of Axes.scatter() to a separate method. This helps in managing the complexity of the code: separted fro...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Nonecd9eea424140838b22e9eabd53d92b5702617ddd6d76efcd3a37f08d44309ca5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3084b9f587e8f1e19803bbe0c77ac77ce3c99c5c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/11663/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F11663%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F11663%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/11663/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/11663/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/11663/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
anntzerhttps://github.com/anntzer
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
timhoffm:scatter-parameter-parsinghttps://github.com/timhoffm/matplotlib/tree/scatter-parameter-parsing
Conversation 24 https://github.com/matplotlib/matplotlib/pull/11663
Commits 1 https://github.com/matplotlib/matplotlib/pull/11663/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/11663/checks
Files changed https://github.com/matplotlib/matplotlib/pull/11663/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
Refactor color parsing of Axes.scatter https://github.com/matplotlib/matplotlib/pull/11663/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/11663/files
1b68e69 Refactor color parsing of Axes.scatter timhoffm Jul 15, 2018 https://github.com/matplotlib/matplotlib/pull/11663/commits/1b68e691a29708209e85c16b7f57f6f1457b386f
Clear filters https://github.com/matplotlib/matplotlib/pull/11663/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
_axes.py https://github.com/matplotlib/matplotlib/pull/11663/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
test_axes.py https://github.com/matplotlib/matplotlib/pull/11663/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
lib/matplotlib/axes/_axes.pyhttps://github.com/matplotlib/matplotlib/pull/11663/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
View file https://github.com/timhoffm/matplotlib/blob/1b68e691a29708209e85c16b7f57f6f1457b386f/lib/matplotlib/axes/_axes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/11663/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/11663/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
https://github.com/matplotlib/matplotlib/pull/11663/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
https://github.com/matplotlib/matplotlib/pull/11663/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
anntzerhttps://github.com/anntzer
Nov 4, 2018https://github.com/matplotlib/matplotlib/pull/11663/files#r230586006
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
timhoffmhttps://github.com/timhoffm
Nov 4, 2018https://github.com/matplotlib/matplotlib/pull/11663/files#r230587260
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#12735https://github.com/matplotlib/matplotlib/issues/12735
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
mathematicalmichaelhttps://github.com/mathematicalmichael
Jan 26, 2019https://github.com/matplotlib/matplotlib/pull/11663/files#r251204842
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
jklymakhttps://github.com/jklymak
Jan 26, 2019https://github.com/matplotlib/matplotlib/pull/11663/files#r251206241
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#12735https://github.com/matplotlib/matplotlib/issues/12735
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
anntzerhttps://github.com/anntzer
Nov 4, 2018https://github.com/matplotlib/matplotlib/pull/11663/files#r230589200
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
timhoffmhttps://github.com/timhoffm
Nov 4, 2018https://github.com/matplotlib/matplotlib/pull/11663/files#r230591482
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
anntzerhttps://github.com/anntzer
Nov 4, 2018https://github.com/matplotlib/matplotlib/pull/11663/files#r230586441
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
timhoffmhttps://github.com/timhoffm
Nov 4, 2018https://github.com/matplotlib/matplotlib/pull/11663/files#r230587022
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
anntzerhttps://github.com/anntzer
Nov 4, 2018https://github.com/matplotlib/matplotlib/pull/11663/files#r230588320
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
anntzerhttps://github.com/anntzer
Nov 4, 2018https://github.com/matplotlib/matplotlib/pull/11663/files#r230589244
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
timhoffmhttps://github.com/timhoffm
Nov 4, 2018https://github.com/matplotlib/matplotlib/pull/11663/files#r230591508
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/11663/files
https://github.com/matplotlib/matplotlib/pull/11663/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
https://github.com/matplotlib/matplotlib/pull/11663/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
https://github.com/matplotlib/matplotlib/pull/11663/files#diff-608e2a1bf3d32fd631b0763599a3334d59822c11cb4fec1fa7398c9714592900
lib/matplotlib/tests/test_axes.pyhttps://github.com/matplotlib/matplotlib/pull/11663/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
View file https://github.com/timhoffm/matplotlib/blob/1b68e691a29708209e85c16b7f57f6f1457b386f/lib/matplotlib/tests/test_axes.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/11663/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/11663/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/11663/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/11663/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com/matplotlib/matplotlib/pull/11663/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.