René's URL Explorer Experiment

Title: FIX: layout for mixed descent multiline text objects by jklymak · Pull Request #11499 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: layout for mixed descent multiline text objects by jklymak · Pull Request #11499 · matplotlib/matplotlib

X Title: FIX: layout for mixed descent multiline text objects by jklymak · Pull Request #11499 · matplotlib/matplotlib

Description: PR Summary Closes #11498 partially closes #11468 WIP: this'll fail some tests that depended on the previous bad behaviour... EDIT This indeed failed some tests, but I'd pretty strongly argue the tests were broken and this PR makes them correct... Test: import matplotlib.pyplot as plt import matplotlib.patches as mpatches fig, ax = plt.subplots(constrained_layout=False) ax.set_xlim([0, 1.4]) ax.set_ylim([0, 2]) ax.axhline(0.5, color='C2', linewidth=0.3) sts = ['Line', '2 Lines g\n 2nd Line g', '$\sum_i x $', 'hi $\sum_i x $\ntest', 'test\n $\sum_i x $', '$\sum_i x $\n $\sum_i x $'] for nn, st in enumerate(sts): tt = ax.text(0.2 * nn + 0.1, 0.5, st, horizontalalignment='center', verticalalignment='bottom') bb = tt.get_window_extent(fig.canvas.get_renderer()) bbt = bb.inverse_transformed(ax.transAxes) r = mpatches.Rectangle((0,0), 1, 1, clip_on=False, transform=ax.transAxes) r.set_bounds(bbt.bounds) ax.add_patch(r) ax.text(1.2, 0.5, 'Bottom align', color='C2') if 1: ax.axhline(1.3, color='C2', linewidth=0.3) for nn, st in enumerate(sts): tt = ax.text(0.2 * nn + 0.1, 1.3, st, horizontalalignment='center', verticalalignment='top') bb = tt.get_window_extent(fig.canvas.get_renderer()) bbt = bb.inverse_transformed(ax.transAxes) r = mpatches.Rectangle((0,0), 1, 1, clip_on=False, transform=ax.transAxes) r.set_bounds(bbt.bounds) ax.add_patch(r) ax.text(1.2, 1.3, 'Top align', color='C2') ax.axhline(1.8, color='C2', linewidth=0.3) for nn, st in enumerate(sts): tt = ax.text(0.2 * nn + 0.1, 1.8, st, horizontalalignment='center', verticalalignment='baseline') bb = tt.get_window_extent(fig.canvas.get_renderer()) bbt = bb.inverse_transformed(ax.transAxes) r = mpatches.Rectangle((0,0), 1, 1, clip_on=False, transform=ax.transAxes) r.set_bounds(bbt.bounds) ax.add_patch(r) ax.text(1.2, 1.8, 'Baseline align', color='C2') ax.axhline(0.1, color='C2', linewidth=0.3) for nn, st in enumerate(sts): tt = ax.text(0.2 * nn + 0.1, 0.1, st, horizontalalignment='center', verticalalignment='bottom', rotation=20) bb = tt.get_window_extent(fig.canvas.get_renderer()) bbt = bb.inverse_transformed(ax.transAxes) r = mpatches.Rectangle((0,0), 1, 1, clip_on=False, transform=ax.transAxes) r.set_bounds(bbt.bounds) ax.add_patch(r) ax.text(1.2, 0.1, 'Bot align, rot20', color='C2') bb = tt.get_window_extent(fig.canvas.get_renderer()) bbt = bb.inverse_transformed(ax.transAxes) r = mpatches.Rectangle((0,0), 1, 1, clip_on=False, transform=ax.transAxes) r.set_bounds(bbt.bounds) ax.add_patch(r) fig.savefig('Old.png') plt.show() Before: With PR: PR Checklist FIX baseline alignment for multiline Add blue boxes to test... Has Pytest style unit tests Code is PEP 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

Open Graph Description: PR Summary Closes #11498 partially closes #11468 WIP: this'll fail some tests that depended on the previous bad behaviour... EDIT This indeed failed some tests, but I'd pretty strongly argu...

X Description: PR Summary Closes #11498 partially closes #11468 WIP: this'll fail some tests that depended on the previous bad behaviour... EDIT This indeed failed some tests, but I'd pretty stron...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/11499

X: @github

direct link

Domain: github.com

Links:

Viewport: width=device-width