Title: Fix two undefined names by cclauss · Pull Request #10938 · matplotlib/matplotlib · GitHub
Open Graph Title: Fix two undefined names by cclauss · Pull Request #10938 · matplotlib/matplotlib
X Title: Fix two undefined names by cclauss · Pull Request #10938 · matplotlib/matplotlib
Description: PR Summary Fix two undefined names: import inspect in decorators.py Change ret --> __ret in pyplot.py The pyplot.py change is probably not useful as this is generated code but it does highlight a bug in the code generator. Fixes: $ python3 -m flake8 . --count --select=E9,F821,F822,F823 --show-source --statistics ./lib/matplotlib/pyplot.py:2837:19: F821 undefined name 'ret' if isinstance(ret, cm.ScalarMappable): sci(__ret) ^ ./lib/matplotlib/testing/decorators.py:88:12: F821 undefined name 'inspect' if inspect.isgeneratorfunction(func): ^ 2 F821 undefined name 'ret' PR Checklist Has Pytest style unit tests Code is PEP 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: PR Summary Fix two undefined names: import inspect in decorators.py Change ret --> __ret in pyplot.py The pyplot.py change is probably not useful as this is generated code but it does highligh...
X Description: PR Summary Fix two undefined names: import inspect in decorators.py Change ret --> __ret in pyplot.py The pyplot.py change is probably not useful as this is generated code but it does high...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/10938
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:b936fba9-7f4c-b311-d2d1-5c25e344ffa4 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | 9B9C:3EAFB3:5B197B:7C665F:6A569694 |
| html-safe-nonce | b1660cf81ea6a66d0e38bba5557829299ea63e18e2a99aa3b9de95940654951b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QjlDOjNFQUZCMzo1QjE5N0I6N0M2NjVGOjZBNTY5Njk0IiwidmlzaXRvcl9pZCI6IjU3OTYyNTIxNzM4NDAzMjQyNDQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 411525e4d93f83caa0021819e6ce4b362df5f5026d8110812e91483d83b94d73 |
| hovercard-subject-tag | pull_request:178740552 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/10938/files |
| twitter:image | https://avatars.githubusercontent.com/u/3709715?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/3709715?s=400&v=4 |
| og:image:alt | PR Summary Fix two undefined names: import inspect in decorators.py Change ret --> __ret in pyplot.py The pyplot.py change is probably not useful as this is generated code but it does highligh... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | 647a25f437e2f54eccdd162bd007c8ae70f4235c4125dba0f4518747cc8b9615 |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 05adb86a60ce3d701e556eded3ab26300ec6bcc4 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width