René's URL Explorer Experiment


Title: FIX: tight_layout having negative width axes by jklymak · Pull Request #10915 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: tight_layout having negative width axes by jklymak · Pull Request #10915 · matplotlib/matplotlib

X Title: FIX: tight_layout having negative width axes by jklymak · Pull Request #10915 · matplotlib/matplotlib

Description: PR Summary Closes #4413 #8062 fig.tight_layout() could cause axes to flip sign if the title was too big, and cause the whole thing to Error if the title was really big. This PR adds a check that the axes width and height is still greater than zero after the margins have been set. It would be nice to just collapse the axes when this happens, but thats actually a bit of work to fake because subplots_adjust 's space parameter is specified as a fraction of average axes width (not the way I'd have expressed this parameter, but...) Discussion in #4413 suggested that something could be done to ignore the title, but otherwise compute the tight_layout. I think that's theoretically possible, but if someone has a really long title they should probably shorten it or adjust the spacing manually rather than trying to make tight_layout do something magical. import matplotlib.pyplot as plt fig, axs = plt.subplots(1, 2, figsize=(6,2)) leng = 95 axs[0].set_title('A'+('a' * leng)) axs[0].set_yticks([]) axs[1].set_title('B' +('b' * leng)) axs[1].set_yticks([]) axs[0].set_xlabel('title length %d' % leng) fig.tight_layout() plt.show() For the second and third plots, a warning is emitted... PR Checklist Has Pytest style unit tests Code is PEP 8 compliant

Open Graph Description: PR Summary Closes #4413 #8062 fig.tight_layout() could cause axes to flip sign if the title was too big, and cause the whole thing to Error if the title was really big. This PR adds a check that t...

X Description: PR Summary Closes #4413 #8062 fig.tight_layout() could cause axes to flip sign if the title was too big, and cause the whole thing to Error if the title was really big. This PR adds a check that t...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/10915

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:0f5d0d2e-bf7c-3ebd-9534-38c051933c8f
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC410:2961BA:15D554:1E003F:6A551CEE
html-safe-nonce893f11e41db60333e03c2845e987e98eeeacf962813c01e46ab82813e4783768
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDEwOjI5NjFCQToxNUQ1NTQ6MUUwMDNGOjZBNTUxQ0VFIiwidmlzaXRvcl9pZCI6IjE3NDc4Mzk3OTQ3NDk0NDc0MDYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacc3ebf5ab90431f5d3b21475c4d2cf900ba25b286cea7d81146c7992ff78ff0bf
hovercard-subject-tagpull_request:178222285
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/10915/files
twitter:imagehttps://avatars.githubusercontent.com/u/1562854?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/1562854?s=400&v=4
og:image:altPR Summary Closes #4413 #8062 fig.tight_layout() could cause axes to flip sign if the title was too big, and cause the whole thing to Error if the title was really big. This PR adds a check that t...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
None682d273eacb2ac51680c6eb9c0b270f029f7ce74c32090f319083c34497e28a5
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release3b6d37c6470adadff4194742daaab9a817cc4980
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/10915/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10915%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10915%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/10915/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/10915/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/10915/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10915/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10915/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
efiringhttps://github.com/efiring
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-tight-layout-too-smallhttps://github.com/jklymak/matplotlib/tree/fix-tight-layout-too-small
Conversation 14 https://github.com/matplotlib/matplotlib/pull/10915
Commits 2 https://github.com/matplotlib/matplotlib/pull/10915/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/10915/checks
Files changed https://github.com/matplotlib/matplotlib/pull/10915/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10915/files
FIX: tight_layout having negative width axes https://github.com/matplotlib/matplotlib/pull/10915/files#top
Show all changes 2 commits https://github.com/matplotlib/matplotlib/pull/10915/files
491c388 FIX: tight_layout having negative width axes jklymak Mar 29, 2018 https://github.com/matplotlib/matplotlib/pull/10915/commits/491c388010f0281b7fab8751bd5d72f8e38e2d74
abf260f TST: tight_layout having negative width axes jklymak Mar 29, 2018 https://github.com/matplotlib/matplotlib/pull/10915/commits/abf260f930b9f20578175bace0aeeb1a77b4dd68
Clear filters https://github.com/matplotlib/matplotlib/pull/10915/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10915/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10915/files
test_tightlayout.py https://github.com/matplotlib/matplotlib/pull/10915/files#diff-1be03a4413cbf98750d368562365435d3ab263836341d7a03424e9aff154932a
tight_layout.py https://github.com/matplotlib/matplotlib/pull/10915/files#diff-10debfd0ac57a591c4fe93987427a88707d0342695705334479d17820a3c8fe8
lib/matplotlib/tests/test_tightlayout.pyhttps://github.com/matplotlib/matplotlib/pull/10915/files#diff-1be03a4413cbf98750d368562365435d3ab263836341d7a03424e9aff154932a
View file https://github.com/jklymak/matplotlib/blob/abf260f930b9f20578175bace0aeeb1a77b4dd68/lib/matplotlib/tests/test_tightlayout.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/10915/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/10915/files#diff-1be03a4413cbf98750d368562365435d3ab263836341d7a03424e9aff154932a
QuLogichttps://github.com/QuLogic
Apr 1, 2018https://github.com/matplotlib/matplotlib/pull/10915/files#r178449777
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10915/files
QuLogichttps://github.com/QuLogic
Apr 1, 2018https://github.com/matplotlib/matplotlib/pull/10915/files#r178449795
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10915/files
lib/matplotlib/tight_layout.pyhttps://github.com/matplotlib/matplotlib/pull/10915/files#diff-10debfd0ac57a591c4fe93987427a88707d0342695705334479d17820a3c8fe8
View file https://github.com/jklymak/matplotlib/blob/abf260f930b9f20578175bace0aeeb1a77b4dd68/lib/matplotlib/tight_layout.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/10915/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/10915/files#diff-10debfd0ac57a591c4fe93987427a88707d0342695705334479d17820a3c8fe8
https://github.com/matplotlib/matplotlib/pull/10915/files#diff-10debfd0ac57a591c4fe93987427a88707d0342695705334479d17820a3c8fe8
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.