René's URL Explorer Experiment


Title: FIX: return proper legend window extent by jklymak · Pull Request #10910 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: return proper legend window extent by jklymak · Pull Request #10910 · matplotlib/matplotlib

X Title: FIX: return proper legend window extent by jklymak · Pull Request #10910 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary As per #10844, it was not possible to properly use text.OffsetFrom if the artist was a legend. The issue was that legend.get_window_extent was calling the wrong patch object to get the ...

X Description: PR Summary As per #10844, it was not possible to properly use text.OffsetFrom if the artist was a legend. The issue was that legend.get_window_extent was calling the wrong patch object to get the ...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/10910

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:aef9aa9f-5fda-1882-1973-beefd3ff7cf1
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idC45A:2ADBE8:394B137:51776CA:6A56AE89
html-safe-nonce4e75ab1f6ce67e4567ad9e13aa8be750fb3c87ebadc2aa73f193c3cd3ac7479c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDVBOjJBREJFODozOTRCMTM3OjUxNzc2Q0E6NkE1NkFFODkiLCJ2aXNpdG9yX2lkIjoiNTc0NDgxODc1NTA1OTc1NjY4MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1d40385807e03a868327d22337c5851bc8ba6f2d88e9dd2f7dc61c6e5bf1930a
hovercard-subject-tagpull_request:178117153
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/10910/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/3477a611a0405daf85670e996b21ce7919b6f29bf7732784ea76f2fe022701a6/matplotlib/matplotlib/pull/10910
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/3477a611a0405daf85670e996b21ce7919b6f29bf7732784ea76f2fe022701a6/matplotlib/matplotlib/pull/10910
og:image:altPR Summary As per #10844, it was not possible to properly use text.OffsetFrom if the artist was a legend. The issue was that legend.get_window_extent was calling the wrong patch object to get the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejklymak
hostnamegithub.com
expected-hostnamegithub.com
Nonedf99b7164e1d961b639cf5d3cbd6b5ba673edc67bd7e47cdc4746b96099e11ae
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
releasec29ba03b1896083dbe1084f6cd1c5367d8a0d67c
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/10910#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10910
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10910
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/10910
Reloadhttps://github.com/matplotlib/matplotlib/pull/10910
Reloadhttps://github.com/matplotlib/matplotlib/pull/10910
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10910
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10910
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 410 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
phobsonhttps://github.com/phobson
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-proper-legend-window-extenthttps://github.com/jklymak/matplotlib/tree/fix-proper-legend-window-extent
Conversationhttps://github.com/matplotlib/matplotlib/pull/10910
Commits2 (2)https://github.com/matplotlib/matplotlib/pull/10910/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/10910/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/10910/files
FIX: return proper legend window extenthttps://github.com/matplotlib/matplotlib/pull/10910#top
phobsonhttps://github.com/phobson
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-proper-legend-window-extenthttps://github.com/jklymak/matplotlib/tree/fix-proper-legend-window-extent
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Mar 28, 2018https://github.com/matplotlib/matplotlib/pull/10910#issue-309470336
#10844https://github.com/matplotlib/matplotlib/issues/10844
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10910
https://github.com/jklymak
FIX: return proper legend window extenthttps://github.com/matplotlib/matplotlib/pull/10910/commits/bc32dc4909decefcbac3e13da12367bdb0f26e95
bc32dc4https://github.com/matplotlib/matplotlib/pull/10910/commits/bc32dc4909decefcbac3e13da12367bdb0f26e95
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Mar 28, 2018 https://github.com/matplotlib/matplotlib/pull/10910#ref-issue-306690547
savefig PDF output - incorrect annotation location #10844 https://github.com/matplotlib/matplotlib/issues/10844
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Mar 28, 2018https://github.com/matplotlib/matplotlib/pull/10910#event-1546263492
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Mar 28, 2018 https://github.com/matplotlib/matplotlib/pull/10910#pullrequestreview-107822700
View reviewed changes https://github.com/matplotlib/matplotlib/pull/10910/files
https://github.com/jklymak
TST: check that size changeshttps://github.com/matplotlib/matplotlib/pull/10910/commits/9a03a2d4ae8aec10015c9517b8c7b1f014b6edb4
9a03a2dhttps://github.com/matplotlib/matplotlib/pull/10910/commits/9a03a2d4ae8aec10015c9517b8c7b1f014b6edb4
https://github.com/jklymak
jklymakhttps://github.com/jklymak
force-pushedhttps://github.com/matplotlib/matplotlib/compare/3b273374c33912a90d96a39d4370b53aed0f9c25..9a03a2d4ae8aec10015c9517b8c7b1f014b6edb4
3b27337https://github.com/matplotlib/matplotlib/commit/3b273374c33912a90d96a39d4370b53aed0f9c25
9a03a2dhttps://github.com/matplotlib/matplotlib/commit/9a03a2d4ae8aec10015c9517b8c7b1f014b6edb4
Compare https://github.com/matplotlib/matplotlib/compare/3b273374c33912a90d96a39d4370b53aed0f9c25..9a03a2d4ae8aec10015c9517b8c7b1f014b6edb4
March 28, 2018 20:36https://github.com/matplotlib/matplotlib/pull/10910#event-1546532105
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Apr 1, 2018https://github.com/matplotlib/matplotlib/pull/10910#issuecomment-377742241
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10910
https://github.com/jklymak
jklymakhttps://github.com/jklymak
status: needs review https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20review%22
Apr 1, 2018https://github.com/matplotlib/matplotlib/pull/10910#event-1550966932
https://github.com/phobson
phobsonhttps://github.com/phobson
Apr 8, 2018 https://github.com/matplotlib/matplotlib/pull/10910#pullrequestreview-110274536
View reviewed changes https://github.com/matplotlib/matplotlib/pull/10910/files/9a03a2d4ae8aec10015c9517b8c7b1f014b6edb4
https://github.com/phobson
phobsonhttps://github.com/phobson
9b15a52https://github.com/matplotlib/matplotlib/commit/9b15a52f8da0e16613eb5d9abe526e6225df6283
Apr 8, 2018https://github.com/matplotlib/matplotlib/pull/10910#event-1562454734
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Apr 8, 2018https://github.com/matplotlib/matplotlib/pull/10910#issuecomment-379521886
@phobsonhttps://github.com/phobson
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10910
https://github.com/jklymak
jklymakhttps://github.com/jklymak
April 8, 2018 05:33https://github.com/matplotlib/matplotlib/pull/10910#event-1562462641
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
status: needs review https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22status%3A%20needs%20review%22
Apr 8, 2018https://github.com/matplotlib/matplotlib/pull/10910#event-1562626583
compatibility fix needed for matplotlib-3 ? mwaskom/seaborn#1551 https://github.com/mwaskom/seaborn/issues/1551
Legend.get_window_extent now requires a renderer #11970 https://github.com/matplotlib/matplotlib/issues/11970
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10910
https://github.com/tacaswell
tacaswell https://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/10910/files/3b273374c33912a90d96a39d4370b53aed0f9c25
https://github.com/phobson
phobson https://github.com/phobson
https://github.com/matplotlib/matplotlib/pull/10910/files/9a03a2d4ae8aec10015c9517b8c7b1f014b6edb4
v3.0.0 https://github.com/matplotlib/matplotlib/milestone/23
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10910
https://github.com/jklymak
https://github.com/tacaswell
https://github.com/phobson
https://github.com/dstansby
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.