René's URL Explorer Experiment


Title: Fix tk icon loading. by anntzer · Pull Request #10681 · matplotlib/matplotlib · GitHub

Open Graph Title: Fix tk icon loading. by anntzer · Pull Request #10681 · matplotlib/matplotlib

X Title: Fix tk icon loading. by anntzer · Pull Request #10681 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: Accidentally broke this for no good reason in #8773. Milestoning as 2.2 as it's fixing a bug introduced in 2.1. PR Checklist Has Pytest style unit tests Code is PEP 8 compliant New feature...

X Description: Accidentally broke this for no good reason in #8773. Milestoning as 2.2 as it's fixing a bug introduced in 2.1. PR Checklist Has Pytest style unit tests Code is PEP 8 compliant New fea...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/10681

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:ff12e5da-250f-ad2e-5004-762f517ea5df
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-id8C44:279B75:23C04C:3026AD:6A52E80C
html-safe-nonce302f340be0b7f31880775fa0ae7e2ce39336f5db5c403ea6ea93877cb89cbf50
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4QzQ0OjI3OUI3NToyM0MwNEM6MzAyNkFEOjZBNTJFODBDIiwidmlzaXRvcl9pZCI6Ijg0OTc2NDc2MTc4ODIzODQzOTYiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac42919cb5d27d089e594ff5f7f654720f2c474d421b83e00d70f96a1d0885ef99
hovercard-subject-tagpull_request:172773650
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/10681/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/b2184bcf550e666338187fe4d55a93234dcac859118b0716948c632e506e1f75/matplotlib/matplotlib/pull/10681
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/b2184bcf550e666338187fe4d55a93234dcac859118b0716948c632e506e1f75/matplotlib/matplotlib/pull/10681
og:image:altAccidentally broke this for no good reason in #8773. Milestoning as 2.2 as it's fixing a bug introduced in 2.1. PR Checklist Has Pytest style unit tests Code is PEP 8 compliant New feature...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameanntzer
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/10681#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10681
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10681
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/10681
Reloadhttps://github.com/matplotlib/matplotlib/pull/10681
Reloadhttps://github.com/matplotlib/matplotlib/pull/10681
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10681
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10681
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
jklymakhttps://github.com/jklymak
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
anntzer:tkiconhttps://github.com/anntzer/matplotlib/tree/tkicon
Conversationhttps://github.com/matplotlib/matplotlib/pull/10681
Commits1 (1)https://github.com/matplotlib/matplotlib/pull/10681/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/10681/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/10681/files
Fix tk icon loading.https://github.com/matplotlib/matplotlib/pull/10681#top
jklymakhttps://github.com/jklymak
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
anntzer:tkiconhttps://github.com/anntzer/matplotlib/tree/tkicon
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Mar 5, 2018https://github.com/matplotlib/matplotlib/pull/10681#issue-302171187
#8773https://github.com/matplotlib/matplotlib/pull/8773
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10681
https://github.com/anntzer
Fix tk icon loading.https://github.com/matplotlib/matplotlib/pull/10681/commits/6355088797f9b5f88bab8db7cdb964933950cc66
6355088https://github.com/matplotlib/matplotlib/pull/10681/commits/6355088797f9b5f88bab8db7cdb964933950cc66
https://github.com/anntzer
anntzerhttps://github.com/anntzer
GUI: tk https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20tk%22
Mar 5, 2018https://github.com/matplotlib/matplotlib/pull/10681#event-1503353361
https://github.com/anntzer
anntzerhttps://github.com/anntzer
v2.2.0https://github.com/matplotlib/matplotlib/milestone/31
Mar 5, 2018https://github.com/matplotlib/matplotlib/pull/10681#event-1503353362
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
v2.2.0https://github.com/matplotlib/matplotlib/milestone/31
v2.2.1https://github.com/matplotlib/matplotlib/milestone/32
Mar 5, 2018https://github.com/matplotlib/matplotlib/pull/10681#event-1503377805
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Mar 5, 2018https://github.com/matplotlib/matplotlib/pull/10681#issuecomment-370380725
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10681
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Mar 5, 2018https://github.com/matplotlib/matplotlib/pull/10681#issuecomment-370381639
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10681
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Mar 5, 2018https://github.com/matplotlib/matplotlib/pull/10681#issuecomment-370435812
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10681
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Mar 5, 2018https://github.com/matplotlib/matplotlib/pull/10681#issuecomment-370578972
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10681
https://github.com/QuLogic
QuLogichttps://github.com/QuLogic
Mar 5, 2018 https://github.com/matplotlib/matplotlib/pull/10681#pullrequestreview-101341273
View reviewed changes https://github.com/matplotlib/matplotlib/pull/10681/files/6355088797f9b5f88bab8db7cdb964933950cc66
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Mar 5, 2018 https://github.com/matplotlib/matplotlib/pull/10681#pullrequestreview-101374022
View reviewed changes https://github.com/matplotlib/matplotlib/pull/10681/files/6355088797f9b5f88bab8db7cdb964933950cc66
https://github.com/jklymak
jklymakhttps://github.com/jklymak
cc127ebhttps://github.com/matplotlib/matplotlib/commit/cc127ebecdbf2622e479d94384825fcb825011eb
Mar 5, 2018https://github.com/matplotlib/matplotlib/pull/10681#event-1505383207
lumberbot-apphttps://github.com/apps/lumberbot-app
Mar 5, 2018 https://github.com/matplotlib/matplotlib/pull/10681#ref-commit-5129d70
https://github.com/jklymak
Backport PRhttps://github.com/matplotlib/matplotlib/commit/5129d70687a38d258ec5c5d19c82870bf6823f31
#10681https://github.com/matplotlib/matplotlib/pull/10681
: Fix tk icon loading.https://github.com/matplotlib/matplotlib/commit/5129d70687a38d258ec5c5d19c82870bf6823f31
5129d70https://github.com/matplotlib/matplotlib/commit/5129d70687a38d258ec5c5d19c82870bf6823f31
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Mar 5, 2018 https://github.com/matplotlib/matplotlib/pull/10681#ref-pullrequest-302510239
Backport PR #10681 on branch v2.2.x #10694 https://github.com/matplotlib/matplotlib/pull/10694
https://github.com/anntzer
anntzerhttps://github.com/anntzer
March 6, 2018 00:33https://github.com/matplotlib/matplotlib/pull/10681#event-1505431129
dstansbyhttps://github.com/dstansby
Mar 6, 2018 https://github.com/matplotlib/matplotlib/pull/10681#ref-commit-1d311f2
https://github.com/dstansby
Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/1d311f251c2702a4fad053587b49b91d0ec6e804
#10694https://github.com/matplotlib/matplotlib/pull/10694
from matplotlib/auto-backport-of-pr-10681https://github.com/matplotlib/matplotlib/commit/1d311f251c2702a4fad053587b49b91d0ec6e804
1d311f2https://github.com/matplotlib/matplotlib/commit/1d311f251c2702a4fad053587b49b91d0ec6e804
#10681https://github.com/matplotlib/matplotlib/pull/10681
https://github.com/anntzer
anntzerhttps://github.com/anntzer
Mar 14, 2018 https://github.com/matplotlib/matplotlib/pull/10681#ref-issue-305262888
TkAgg reports bad option 'foobar' for icon with logging set to INFO level #10785 https://github.com/matplotlib/matplotlib/issues/10785
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10681
https://github.com/QuLogic
QuLogic https://github.com/QuLogic
https://github.com/matplotlib/matplotlib/pull/10681/files/6355088797f9b5f88bab8db7cdb964933950cc66
https://github.com/jklymak
jklymak https://github.com/jklymak
https://github.com/matplotlib/matplotlib/pull/10681/files/6355088797f9b5f88bab8db7cdb964933950cc66
GUI: tk https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22GUI%3A%20tk%22
v2.2.1 https://github.com/matplotlib/matplotlib/milestone/32
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10681
https://github.com/anntzer
https://github.com/dstansby
https://github.com/QuLogic
https://github.com/jklymak
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.