Title: FigureCanvasWx/Agg fixed size by DietmarSchwertberger · Pull Request #10153 · matplotlib/matplotlib · GitHub
Open Graph Title: FigureCanvasWx/Agg fixed size by DietmarSchwertberger · Pull Request #10153 · matplotlib/matplotlib
X Title: FigureCanvasWx/Agg fixed size by DietmarSchwertberger · Pull Request #10153 · matplotlib/matplotlib
Description: PR Summary (sorry, it seems that I should have checked out master before creating the new branch; now the two commits from PR #10145 are visible as well) The embedded FigureCanvasWx currently can't be set to a fixed size. When it is added to a sizer with proportion=0 and wx.EXPAND not set, then it will not expand over it's defined size, as expected. But when the visible area is reduced below the defined size, it will re-scale itself to fit the visible area because 'self.GetClientSize()' is used to read the size. This could happen if the window size is reduced or a splitter is used. When placed on a scrolled window, the problem does not occur, as then the VirtualSize will not change, even when the widget is not 100% visible. This is not a big issue as the behaviour can easily be modified in a derived class. It would be nice though, to have the correct behaviour by default. See attached file embedding_in_wx4_fixed.py for an example. With the modification from the pull request the size will stay fixed. The only change is the sizer.Add call with proportion=0 and without EXPAND: self.figure = Figure(figsize=(5, 4), dpi=100) ... self.canvas = FigureCanvas(self, -1, self.figure) self.sizer = wx.BoxSizer(wx.VERTICAL) #self.sizer.Add(self.canvas, 1, wx.TOP | wx.LEFT | wx.EXPAND) self.sizer.Add(self.canvas, 0, wx.TOP | wx.LEFT) embedding_in_wx4_fixed.py.txt I could commit the example file, but that's probably not worth it. If there is consensus to change the behaviour, then I would ask Robin to review the implementation to check whether this is the best way to check for fixed size. If the canvas is directly used as single child of a frame (i.e. instead of a Panel), the behaviour is not modified by the pull request. This could be changed, but I don't see a use case for this. Btw.: I just noticed that the embedding_in_wx4.py example includes a EVT_PAINT handler. I don't think that this is required, as the plot is static. PR Checklist Has Pytest style unit tests Code is PEP 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: PR Summary (sorry, it seems that I should have checked out master before creating the new branch; now the two commits from PR #10145 are visible as well) The embedded FigureCanvasWx currently can&#...
X Description: PR Summary (sorry, it seems that I should have checked out master before creating the new branch; now the two commits from PR #10145 are visible as well) The embedded FigureCanvasWx currently can&a...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/10153
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c5d15246-4266-be9b-4185-de649d0e02b6 |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C5F4:2B6B99:1E0B6E4:2906BF7:6A540AA0 |
| html-safe-nonce | ae949b4021cddc2605480a5499d937fe68fe16434ab1d851e8b52e4c97c93bfb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNUY0OjJCNkI5OToxRTBCNkU0OjI5MDZCRjc6NkE1NDBBQTAiLCJ2aXNpdG9yX2lkIjoiNTc3NjUwMTQ2NjA4MTc5MDYyNCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 742c6aa9d87fe308698fbdd29a125e10ee3074e908d3c8d314280666d646439a |
| hovercard-subject-tag | pull_request:161024965 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/10153/files |
| twitter:image | https://avatars.githubusercontent.com/u/5512021?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5512021?s=400&v=4 |
| og:image:alt | PR Summary (sorry, it seems that I should have checked out master before creating the new branch; now the two commits from PR #10145 are visible as well) The embedded FigureCanvasWx currently can&#... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width