Title: refactor non wx.ToolBar specific parts of NavigationToolbar2Wx/Agg into NavigationController2Wx/Agg by DietmarSchwertberger · Pull Request #10145 · matplotlib/matplotlib · GitHub
Open Graph Title: refactor non wx.ToolBar specific parts of NavigationToolbar2Wx/Agg into NavigationController2Wx/Agg by DietmarSchwertberger · Pull Request #10145 · matplotlib/matplotlib
X Title: refactor non wx.ToolBar specific parts of NavigationToolbar2Wx/Agg into NavigationController2Wx/Agg by DietmarSchwertberger · Pull Request #10145 · matplotlib/matplotlib
Description: plus bug fix: add missing 'import six' PR Summary When embedding a FigureCanvasWx or FigureCanvasWxAgg into a larger application, the functionality of NavigationToolbar2Wx/Agg is quite useful, but actually having to integrate the ToolBar is not too nice. With this pull request you still can use the functionality (pan, zoom, save_figure etc.) now as the non-ToolBar specific code is refactored into NavigationController2Wx/Agg. I'm currently using this to prepare a more comprehensive example of a matplotlib application to be supplied with wxGlade. PR Checklist I don't think that NavigationToolbar2Wx is documented anywhere except in the examples. If anyone wants to use NavigationController2Wx/Agg, he/she probably needs to look into the sources anyway. If the pull request is accepted, I could prepare an example with standard wx Buttons instead of the toolbar. Has Pytest style unit tests Code is PEP 8 compliant New features are documented, with examples if plot related Documentation is sphinx and numpydoc compliant Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there) Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: plus bug fix: add missing 'import six' PR Summary When embedding a FigureCanvasWx or FigureCanvasWxAgg into a larger application, the functionality of NavigationToolbar2Wx/Agg is quite usef...
X Description: plus bug fix: add missing 'import six' PR Summary When embedding a FigureCanvasWx or FigureCanvasWxAgg into a larger application, the functionality of NavigationToolbar2Wx/Agg is qu...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/10145
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:c7934eda-a9c2-0740-df58-90cfaa96df6b |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | C1F2:16035A:9232C0:C40039:6A53FD37 |
| html-safe-nonce | 9459e6ff4467928d02100b51332f7a3eb1e41a36be27a315f44abe4c71418d6e |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUYyOjE2MDM1QTo5MjMyQzA6QzQwMDM5OjZBNTNGRDM3IiwidmlzaXRvcl9pZCI6IjUzOTIzNTI0MTQyMzcxOTU1NzUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | eb2465a01165b62141641bbfe035fa8e250d4abcf98c3f441c72782be91a863c |
| hovercard-subject-tag | pull_request:160818603 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/10145/files |
| twitter:image | https://avatars.githubusercontent.com/u/5512021?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/5512021?s=400&v=4 |
| og:image:alt | plus bug fix: add missing 'import six' PR Summary When embedding a FigureCanvasWx or FigureCanvasWxAgg into a larger application, the functionality of NavigationToolbar2Wx/Agg is quite usef... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 07a982c1d40157c619b364352b704c3ce66bb332 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width