Title: FIX: remove repeated label legend logic by jklymak · Pull Request #10064 · matplotlib/matplotlib · GitHub
Open Graph Title: FIX: remove repeated label legend logic by jklymak · Pull Request #10064 · matplotlib/matplotlib
X Title: FIX: remove repeated label legend logic by jklymak · Pull Request #10064 · matplotlib/matplotlib
Description: PR Summary Fixes #10030, #10053, #10056. Pre #9324, there was logic in Figure.legend() to not include duplicate labels in the legend if the linecolors or marker colors were the same. That logic was buggy, and didn't include all possible line properties, but presumably users of Figure.legend() worked around this. In #9324, I homogenized the logic between Figure.legend() and Axes.legend(). I still think that re-factoring was a good thing to do, but I missed that Axes.legend() didn't have the no-duplicate logic in it. That exposed the bugs noted above. This PR, goes the other way of making Figure.legend() the same as pre-9324 Axes.legend() and not removing the duplicate legend entries. PR Checklist Has Pytest style unit tests Code is PEP 8 compliant Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way
Open Graph Description: PR Summary Fixes #10030, #10053, #10056. Pre #9324, there was logic in Figure.legend() to not include duplicate labels in the legend if the linecolors or marker colors were the same. That logic wa...
X Description: PR Summary Fixes #10030, #10053, #10056. Pre #9324, there was logic in Figure.legend() to not include duplicate labels in the legend if the linecolors or marker colors were the same. That logic wa...
Opengraph URL: https://github.com/matplotlib/matplotlib/pull/10064
X: @github
Domain: github.com
| route-pattern | /:user_id/:repository/pull/:id/files(.:format) |
| route-controller | pull_requests |
| route-action | files |
| fetch-nonce | v2:d8299824-0dee-67a9-0212-6e3f441b0dcf |
| current-catalog-service-hash | ae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b |
| request-id | BC44:9B27A:10F6840:1656294:6A51A95D |
| html-safe-nonce | 1816ed633c243afaad3bc6997d73ca278554800ab64fcda2bfe00407dea85a3a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQzQ0OjlCMjdBOjEwRjY4NDA6MTY1NjI5NDo2QTUxQTk1RCIsInZpc2l0b3JfaWQiOiI2ODUzNTI4MjUxNzQyMDY4MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | fb99b2493a6801758f4391531bec8d57ecf149b04f178a19f57a8f83925b2c60 |
| hovercard-subject-tag | pull_request:159513337 |
| github-keyboard-shortcuts | repository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/10064/files |
| twitter:image | https://avatars.githubusercontent.com/u/1562854?s=400&v=4 |
| twitter:card | summary_large_image |
| og:image | https://avatars.githubusercontent.com/u/1562854?s=400&v=4 |
| og:image:alt | PR Summary Fixes #10030, #10053, #10056. Pre #9324, there was logic in Figure.legend() to not include duplicate labels in the legend if the linecolors or marker colors were the same. That logic wa... |
| og:site_name | GitHub |
| og:type | object |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| diff-view | unified |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive full-width |
| disable-turbo | true |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width