René's URL Explorer Experiment


Title: FIX: remove repeated label legend logic by jklymak · Pull Request #10064 · matplotlib/matplotlib · GitHub

Open Graph Title: FIX: remove repeated label legend logic by jklymak · Pull Request #10064 · matplotlib/matplotlib

X Title: FIX: remove repeated label legend logic by jklymak · Pull Request #10064 · matplotlib/matplotlib

Description: matplotlib: plotting with Python. Contribute to matplotlib/matplotlib development by creating an account on GitHub.

Open Graph Description: PR Summary Fixes #10030, #10053, #10056. Pre #9324, there was logic in Figure.legend() to not include duplicate labels in the legend if the linecolors or marker colors were the same. That logic wa...

X Description: PR Summary Fixes #10030, #10053, #10056. Pre #9324, there was logic in Figure.legend() to not include duplicate labels in the legend if the linecolors or marker colors were the same. That logic wa...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/10064

X: @github

direct link

Domain: github.com

route-pattern/_view_fragments/voltron/pull_requests/show/:user_id/:repository/:id/pull_request_layout(.:format)
route-controllervoltron_pull_requests_fragments
route-actionpull_request_layout
fetch-noncev2:b221a02a-13ed-8b70-5a90-431f44c38a81
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idBE34:19F60D:8F5252:BDB220:6A5182F9
html-safe-noncee863d3a9f115ad25b5bb1e8f747a74d986331fe9fef76dcf4799185b8d045943
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCRTM0OjE5RjYwRDo4RjUyNTI6QkRCMjIwOjZBNTE4MkY5IiwidmlzaXRvcl9pZCI6IjYwNjA4NjM4MTYxNjEzOTU0NDkiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac3c0434ff7f4e7cd1e72ee63b329c128b181510bc8918bcf0821d45725edc4b78
hovercard-subject-tagpull_request:159513337
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/pull_requests_fragments/pull_request_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/voltron/pull_requests/show/matplotlib/matplotlib/10064/pull_request_layout
twitter:imagehttps://opengraph.githubassets.com/88d6af49f7a1da15e301b07591ff2a21ef92f323ccc16619114f0851cebba7d3/matplotlib/matplotlib/pull/10064
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/88d6af49f7a1da15e301b07591ff2a21ef92f323ccc16619114f0851cebba7d3/matplotlib/matplotlib/pull/10064
og:image:altPR Summary Fixes #10030, #10053, #10056. Pre #9324, there was logic in Figure.legend() to not include duplicate labels in the legend if the linecolors or marker colors were the same. That logic wa...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejklymak
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-cache
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
released01c62704ef24df49056c63892a149b775e1353d
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/10064#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10064
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10064
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fpull_requests_fragments%2Fpull_request_layout&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/10064
Reloadhttps://github.com/matplotlib/matplotlib/pull/10064
Reloadhttps://github.com/matplotlib/matplotlib/pull/10064
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 409 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
dstansbyhttps://github.com/dstansby
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-legend-logichttps://github.com/jklymak/matplotlib/tree/fix-legend-logic
Conversationhttps://github.com/matplotlib/matplotlib/pull/10064
Commits1 (1)https://github.com/matplotlib/matplotlib/pull/10064/commits
Checkshttps://github.com/matplotlib/matplotlib/pull/10064/checks
Files changedhttps://github.com/matplotlib/matplotlib/pull/10064/files
FIX: remove repeated label legend logichttps://github.com/matplotlib/matplotlib/pull/10064#top
dstansbyhttps://github.com/dstansby
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
jklymak:fix-legend-logichttps://github.com/jklymak/matplotlib/tree/fix-legend-logic
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 20, 2017https://github.com/matplotlib/matplotlib/pull/10064#issue-283689045
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
#10030https://github.com/matplotlib/matplotlib/pull/10030
#10053https://github.com/matplotlib/matplotlib/issues/10053
#10056https://github.com/matplotlib/matplotlib/issues/10056
#9324https://github.com/matplotlib/matplotlib/pull/9324
#9324https://github.com/matplotlib/matplotlib/pull/9324
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
https://github.com/jklymak
jklymakhttps://github.com/jklymak
force-pushedhttps://github.com/matplotlib/matplotlib/compare/4f421c942afd550fb026cb3f7f17e62160290c18..d5e325d99105cd33d04d1dee4eb9ca7776ef42ac
4f421c9https://github.com/matplotlib/matplotlib/commit/4f421c942afd550fb026cb3f7f17e62160290c18
d5e325dhttps://github.com/matplotlib/matplotlib/commit/d5e325d99105cd33d04d1dee4eb9ca7776ef42ac
Compare https://github.com/matplotlib/matplotlib/compare/4f421c942afd550fb026cb3f7f17e62160290c18..d5e325d99105cd33d04d1dee4eb9ca7776ef42ac
December 20, 2017 20:43https://github.com/matplotlib/matplotlib/pull/10064#event-1396859741
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 20, 2017 https://github.com/matplotlib/matplotlib/pull/10064#ref-pullrequest-283621621
TST: the legend repeat marker test can run #10059 https://github.com/matplotlib/matplotlib/pull/10059
https://github.com/jklymak
jklymakhttps://github.com/jklymak
v2.1.2https://github.com/matplotlib/matplotlib/milestone/30
Dec 20, 2017https://github.com/matplotlib/matplotlib/pull/10064#event-1396863629
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Release critical https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22
API: changes https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22API%3A%20changes%22
API: consistency https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22API%3A%20consistency%22
Dec 20, 2017https://github.com/matplotlib/matplotlib/pull/10064#event-1396863910
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 20, 2017 https://github.com/matplotlib/matplotlib/pull/10064#ref-issue-281276621
sympy/plotting/tests/test_plot.py matplotlib failures on Travis sympy/sympy#13730 https://github.com/sympy/sympy/issues/13730
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 20, 2017https://github.com/matplotlib/matplotlib/pull/10064#issuecomment-353181665
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Dec 20, 2017 https://github.com/matplotlib/matplotlib/pull/10064#pullrequestreview-84898197
View reviewed changes https://github.com/matplotlib/matplotlib/pull/10064/files
doc/api/api_changes/2017-12-20-JMK.rsthttps://github.com/matplotlib/matplotlib/pull/10064/files#diff-0bb8b08ca6bc0bc5a1f6260a14e3c6750b98f4448c117ff2739124964a719a96
tacaswellhttps://github.com/tacaswell
Dec 20, 2017https://github.com/matplotlib/matplotlib/pull/10064#discussion_r158136429
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
jklymakhttps://github.com/jklymak
Dec 20, 2017https://github.com/matplotlib/matplotlib/pull/10064#discussion_r158137625
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
tacaswellhttps://github.com/tacaswell
Dec 20, 2017https://github.com/matplotlib/matplotlib/pull/10064#discussion_r158137808
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
https://github.com/tacaswell
tacaswellhttps://github.com/tacaswell
Dec 20, 2017 https://github.com/matplotlib/matplotlib/pull/10064#pullrequestreview-84899714
View reviewed changes https://github.com/matplotlib/matplotlib/pull/10064/files
tacaswellhttps://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/10064#pullrequestreview-84899714
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 20, 2017 https://github.com/matplotlib/matplotlib/pull/10064#ref-pullrequest-282686503
Fix using .get_color() and friends in labels handling #10030 https://github.com/matplotlib/matplotlib/pull/10030
https://github.com/jklymak
jklymakhttps://github.com/jklymak
force-pushedhttps://github.com/matplotlib/matplotlib/compare/39cee8958d756796ad4636fab6e5222a88e22165..6ae1c886baa96be8e971f430a31a43317de75c43
39cee89https://github.com/matplotlib/matplotlib/commit/39cee8958d756796ad4636fab6e5222a88e22165
6ae1c88https://github.com/matplotlib/matplotlib/commit/6ae1c886baa96be8e971f430a31a43317de75c43
Compare https://github.com/matplotlib/matplotlib/compare/39cee8958d756796ad4636fab6e5222a88e22165..6ae1c886baa96be8e971f430a31a43317de75c43
December 20, 2017 23:20https://github.com/matplotlib/matplotlib/pull/10064#event-1397075411
https://github.com/jklymak
FIX: drop logic to check for repeat labelshttps://github.com/matplotlib/matplotlib/pull/10064/commits/3ea5f8303946aa440e1a44478fbb7afd5036294b
3ea5f83https://github.com/matplotlib/matplotlib/pull/10064/commits/3ea5f8303946aa440e1a44478fbb7afd5036294b
https://github.com/jklymak
jklymakhttps://github.com/jklymak
force-pushedhttps://github.com/matplotlib/matplotlib/compare/6ae1c886baa96be8e971f430a31a43317de75c43..3ea5f8303946aa440e1a44478fbb7afd5036294b
6ae1c88https://github.com/matplotlib/matplotlib/commit/6ae1c886baa96be8e971f430a31a43317de75c43
3ea5f83https://github.com/matplotlib/matplotlib/commit/3ea5f8303946aa440e1a44478fbb7afd5036294b
Compare https://github.com/matplotlib/matplotlib/compare/6ae1c886baa96be8e971f430a31a43317de75c43..3ea5f8303946aa440e1a44478fbb7afd5036294b
December 20, 2017 23:21https://github.com/matplotlib/matplotlib/pull/10064#event-1397077049
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Dec 21, 2017https://github.com/matplotlib/matplotlib/pull/10064#issuecomment-353218612
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
Dec 21, 2017 https://github.com/matplotlib/matplotlib/pull/10064#pullrequestreview-85003375
View reviewed changes https://github.com/matplotlib/matplotlib/pull/10064/files/3ea5f8303946aa440e1a44478fbb7afd5036294b
https://github.com/dstansby
dstansbyhttps://github.com/dstansby
2f529fahttps://github.com/matplotlib/matplotlib/commit/2f529fa7e5dfcf60b9c9575bc1b8095758c89027
Dec 21, 2017https://github.com/matplotlib/matplotlib/pull/10064#event-1397607959
lumberbot-apphttps://github.com/apps/lumberbot-app
Dec 21, 2017 https://github.com/matplotlib/matplotlib/pull/10064#ref-commit-c0fc4e2
https://github.com/dstansby
Backport PRhttps://github.com/matplotlib/matplotlib/commit/c0fc4e2dcd04abdc5b0bcb00b54bd86e02f29fbe
#10064https://github.com/matplotlib/matplotlib/pull/10064
: FIX: remove repeated label legend logichttps://github.com/matplotlib/matplotlib/commit/c0fc4e2dcd04abdc5b0bcb00b54bd86e02f29fbe
c0fc4e2https://github.com/matplotlib/matplotlib/commit/c0fc4e2dcd04abdc5b0bcb00b54bd86e02f29fbe
https://github.com/apps/lumberbot-app
lumberbot-apphttps://github.com/apps/lumberbot-app
Dec 21, 2017 https://github.com/matplotlib/matplotlib/pull/10064#ref-pullrequest-283818482
Backport PR #10064 on branch v2.1.x #10068 https://github.com/matplotlib/matplotlib/pull/10068
https://github.com/jklymak
jklymakhttps://github.com/jklymak
December 21, 2017 14:51https://github.com/matplotlib/matplotlib/pull/10064#event-1398107322
jklymakhttps://github.com/jklymak
Dec 21, 2017 https://github.com/matplotlib/matplotlib/pull/10064#ref-commit-249a360
https://github.com/jklymak
Merge pull requesthttps://github.com/matplotlib/matplotlib/commit/249a360bff55ca37af22e5dd6cc144e8b29d6a9b
#10068https://github.com/matplotlib/matplotlib/pull/10068
from matplotlib/auto-backport-of-pr-10064https://github.com/matplotlib/matplotlib/commit/249a360bff55ca37af22e5dd6cc144e8b29d6a9b
249a360https://github.com/matplotlib/matplotlib/commit/249a360bff55ca37af22e5dd6cc144e8b29d6a9b
#10064https://github.com/matplotlib/matplotlib/pull/10064
Only one legend entry is rendered for items with the same label and color #10056 https://github.com/matplotlib/matplotlib/issues/10056
Duplicate legend labels with different colors can often result in an error. #10053 https://github.com/matplotlib/matplotlib/issues/10053
https://github.com/jklymak
jklymakhttps://github.com/jklymak
Jan 16, 2018 https://github.com/matplotlib/matplotlib/pull/10064#ref-issue-289039880
OrderedDict legends no longer work 2.1 #10262 https://github.com/matplotlib/matplotlib/issues/10262
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/{{ revealButtonHref }}
Sign up for freehttps://github.com/join?source=comment-repo
Sign in to commenthttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10064
https://github.com/tacaswell
tacaswell https://github.com/tacaswell
https://github.com/matplotlib/matplotlib/pull/10064/files/39cee8958d756796ad4636fab6e5222a88e22165
https://github.com/dstansby
dstansby https://github.com/dstansby
https://github.com/matplotlib/matplotlib/pull/10064/files/3ea5f8303946aa440e1a44478fbb7afd5036294b
API: changes https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22API%3A%20changes%22
API: consistency https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22API%3A%20consistency%22
Release critical https://github.com/matplotlib/matplotlib/issues?q=state%3Aopen%20label%3A%22Release%20critical%22
v2.1.2 https://github.com/matplotlib/matplotlib/milestone/30
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10064
https://github.com/jklymak
https://github.com/tacaswell
https://github.com/dstansby
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.