René's URL Explorer Experiment


Title: Improve handling of shared axes with specified aspect ratio by efiring · Pull Request #10033 · matplotlib/matplotlib · GitHub

Open Graph Title: Improve handling of shared axes with specified aspect ratio by efiring · Pull Request #10033 · matplotlib/matplotlib

X Title: Improve handling of shared axes with specified aspect ratio by efiring · Pull Request #10033 · matplotlib/matplotlib

Description: This is an attempt to resurrect #8752. I stripped out the parts related to cla() efficiency, thinking that had been handled by #8626, but now I see that the latter was reverted and does not appear to have been revived. I think the Axes initialization slowness problem was attacked from a different angle since then, but I haven't been able to find the PR. In any case, it is possible, but by no means certain, that something like the approach I used in 8752 should go back in. The idea is that cla() is often too blunt an instrument; finer control over what is needed could be added via arguments to the function. In addition to clarifying the handling of aspect ratios with shared axes (see the set_adjustable docstring edit), this adds tracking of twinned axes, and keeps their positions in sync. This solves a bug in which adding a colorbar to a twinned axes previously would leave a mess--the box of the other twin was not being changed to match. Axis sharing works across figures. The "box-forced" adjustable is no longer needed. Sharing both axes requires the use of "box", not "datalim". A new "share" kwarg triggers synchronized setting of aspect ratio and adjustable in Axes within shared axis groups. Added a test for axis sharing with aspect ratio setting. Fixed and updated skew_rects test.

Open Graph Description: This is an attempt to resurrect #8752. I stripped out the parts related to cla() efficiency, thinking that had been handled by #8626, but now I see that the latter was reverted and does not appear...

X Description: This is an attempt to resurrect #8752. I stripped out the parts related to cla() efficiency, thinking that had been handled by #8626, but now I see that the latter was reverted and does not appear...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/10033

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:8911f122-fa1a-e6bd-1dfd-3994d59ed5ed
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idD58C:1F2FB0:1B0CE47:23C8112:6A52CE81
html-safe-noncee979cee2dd97d5785cb36860c1d6c61a98eb2e9fb1f16560c85fa7d156441a90
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJENThDOjFGMkZCMDoxQjBDRTQ3OjIzQzgxMTI6NkE1MkNFODEiLCJ2aXNpdG9yX2lkIjoiNDkwMzcyMTc5NzUxNjcwOTUwNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1e4ad316bf9071fbe03026daacd36b1a577e2b96a4560f4f3035c204fc075afd
hovercard-subject-tagpull_request:158810358
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/10033/files
twitter:imagehttps://avatars.githubusercontent.com/u/85125?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/85125?s=400&v=4
og:image:altThis is an attempt to resurrect #8752. I stripped out the parts related to cla() efficiency, thinking that had been handled by #8626, but now I see that the latter was reverted and does not appear...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/10033/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10033%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10033%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/10033/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/10033/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/10033/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10033/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10033/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
jklymakhttps://github.com/jklymak
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
efiring:share_and_aspecthttps://github.com/efiring/matplotlib/tree/share_and_aspect
Conversation 28 https://github.com/matplotlib/matplotlib/pull/10033
Commits 1 https://github.com/matplotlib/matplotlib/pull/10033/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/10033/checks
Files changed https://github.com/matplotlib/matplotlib/pull/10033/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10033/files
Improve handling of shared axes with specified aspect ratio https://github.com/matplotlib/matplotlib/pull/10033/files#top
Show all changes 1 commit https://github.com/matplotlib/matplotlib/pull/10033/files
4d6448a Clarify axis sharing with aspect ratio control efiring Jun 12, 2017 https://github.com/matplotlib/matplotlib/pull/10033/commits/4d6448ab5b392a943b7f3f704dfe5b18c0764aa4
Clear filters https://github.com/matplotlib/matplotlib/pull/10033/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10033/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10033/files
_base.py https://github.com/matplotlib/matplotlib/pull/10033/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
_subplots.py https://github.com/matplotlib/matplotlib/pull/10033/files#diff-7452babd771a5640e657d38cb31f9a76244db6d3fffa8515a3e20f16108e4cb2
skew_rects.pdf https://github.com/matplotlib/matplotlib/pull/10033/files#diff-3017cda2946dbb7483037f35a3684aae5f6ca9489f9a8984485cac49cb6f0a3e
skew_rects.png https://github.com/matplotlib/matplotlib/pull/10033/files#diff-bd63743ccd36a83a9e496fb8a7d133ae2d296c3defdda9b8cfeda71bfdb9f25d
skew_rects.svg https://github.com/matplotlib/matplotlib/pull/10033/files#diff-75d7948213a2e775c865acc8627c0bf10f476f91086126f42160e9801a1d5c68
test_axes.py https://github.com/matplotlib/matplotlib/pull/10033/files#diff-ef5144bd27a700deb760ef56ccf51dc6fcfe86723f9ffa84df7f024985bf3ee7
test_skew.py https://github.com/matplotlib/matplotlib/pull/10033/files#diff-fd1c1c31dca58237316615611cd0815f5ed731d3487247a1028e3a48240a3f52
axes_divider.py https://github.com/matplotlib/matplotlib/pull/10033/files#diff-0014c00e68d6ac3852a40c94a0a6358690282ae2ef8b2d975500a1870a7bd287
lib/matplotlib/axes/_base.pyhttps://github.com/matplotlib/matplotlib/pull/10033/files#diff-eab8def55235f317e1ea06840d82467044586af2a7f9ec994356a14f70509b72
View file https://github.com/efiring/matplotlib/blob/4d6448ab5b392a943b7f3f704dfe5b18c0764aa4/lib/matplotlib/axes/_base.py
Open in desktop https://desktop.github.com
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10033/files
lib/matplotlib/axes/_subplots.pyhttps://github.com/matplotlib/matplotlib/pull/10033/files#diff-7452babd771a5640e657d38cb31f9a76244db6d3fffa8515a3e20f16108e4cb2
View file https://github.com/efiring/matplotlib/blob/4d6448ab5b392a943b7f3f704dfe5b18c0764aa4/lib/matplotlib/axes/_subplots.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/10033/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/10033/files#diff-7452babd771a5640e657d38cb31f9a76244db6d3fffa8515a3e20f16108e4cb2
https://github.com/matplotlib/matplotlib/pull/10033/files#diff-7452babd771a5640e657d38cb31f9a76244db6d3fffa8515a3e20f16108e4cb2
lib/matplotlib/tests/baseline_images/test_skew/skew_rects.pdfhttps://github.com/matplotlib/matplotlib/pull/10033/files#diff-3017cda2946dbb7483037f35a3684aae5f6ca9489f9a8984485cac49cb6f0a3e
View file https://github.com/efiring/matplotlib/blob/4d6448ab5b392a943b7f3f704dfe5b18c0764aa4/lib/matplotlib/tests/baseline_images/test_skew/skew_rects.pdf
Open in desktop https://desktop.github.com
lib/matplotlib/tests/baseline_images/test_skew/skew_rects.pnghttps://github.com/matplotlib/matplotlib/pull/10033/files#diff-bd63743ccd36a83a9e496fb8a7d133ae2d296c3defdda9b8cfeda71bfdb9f25d
View file https://github.com/efiring/matplotlib/blob/4d6448ab5b392a943b7f3f704dfe5b18c0764aa4/lib/matplotlib/tests/baseline_images/test_skew/skew_rects.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/10033/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10033/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.