René's URL Explorer Experiment


Title: MAINT/BUG: Don't use 5-sided quadrilaterals in Axes3D.plot_surface by eric-wieser · Pull Request #10001 · matplotlib/matplotlib · GitHub

Open Graph Title: MAINT/BUG: Don't use 5-sided quadrilaterals in Axes3D.plot_surface by eric-wieser · Pull Request #10001 · matplotlib/matplotlib

X Title: MAINT/BUG: Don't use 5-sided quadrilaterals in Axes3D.plot_surface by eric-wieser · Pull Request #10001 · matplotlib/matplotlib

Description: Previously: "cell" perimeters were clumsily calculated with duplicates, which were then removed at runtime code to calculate normals was spread into multiple places average z was calculated even if not used repeated conversion between stride and count was done Should have no visible behavior changes This should be up to 25% faster, since the quadrilateral polygons now have 4 points, rather than 5 (!)

Open Graph Description: Previously: "cell" perimeters were clumsily calculated with duplicates, which were then removed at runtime code to calculate normals was spread into multiple places average z was calcula...

X Description: Previously: "cell" perimeters were clumsily calculated with duplicates, which were then removed at runtime code to calculate normals was spread into multiple places average z was...

Opengraph URL: https://github.com/matplotlib/matplotlib/pull/10001

X: @github

direct link

Domain: github.com

route-pattern/:user_id/:repository/pull/:id/files(.:format)
route-controllerpull_requests
route-actionfiles
fetch-noncev2:1748b0c1-169b-34d7-3d3e-f1cf3275800b
current-catalog-service-hashae870bc5e265a340912cde392f23dad3671a0a881730ffdadd82f2f57d81641b
request-idE6AC:191DCC:14F60BB:1BC6F69:6A534BCE
html-safe-nonce5c16095739f0d211506d241e8c4271f0adc2ddcc1f8bbf3325c25466ab095f0b
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNkFDOjE5MURDQzoxNEY2MEJCOjFCQzZGNjk6NkE1MzRCQ0UiLCJ2aXNpdG9yX2lkIjoiODA5ODEzNDY0NzY4MTI3Mjc4MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacb3ab5a793e52af9e2dc0aa6ee85e062b4249243cc75cc647340cec378241ac13
hovercard-subject-tagpull_request:158287455
github-keyboard-shortcutsrepository,pull-request-list,pull-request-conversation,pull-request-files-changed,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///pull_requests/show/files
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/matplotlib/matplotlib/pull/10001/files
twitter:imagehttps://avatars.githubusercontent.com/u/425260?s=400&v=4
twitter:cardsummary_large_image
og:imagehttps://avatars.githubusercontent.com/u/425260?s=400&v=4
og:image:altPreviously: "cell" perimeters were clumsily calculated with duplicates, which were then removed at runtime code to calculate normals was spread into multiple places average z was calcula...
og:site_nameGitHub
og:typeobject
hostnamegithub.com
expected-hostnamegithub.com
Noneb9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb
turbo-cache-controlno-preview
diff-viewunified
go-importgithub.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git
octolytics-dimension-user_id215947
octolytics-dimension-user_loginmatplotlib
octolytics-dimension-repository_id1385122
octolytics-dimension-repository_nwomatplotlib/matplotlib
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id1385122
octolytics-dimension-repository_network_root_nwomatplotlib/matplotlib
turbo-body-classeslogged-out env-production page-responsive full-width
disable-turbotrue
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release07a982c1d40157c619b364352b704c3ce66bb332
ui-targetfull
theme-color#1e2327
color-schemelight dark

Links:

Skip to contenthttps://github.com/matplotlib/matplotlib/pull/10001/files#start-of-content
https://github.com/
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10001%2Ffiles
GitHub CopilotWrite better code with AIhttps://github.com/features/copilot
GitHub Copilot appDirect agents from issue to mergehttps://github.com/features/ai/github-app
MCP RegistryNewIntegrate external toolshttps://github.com/mcp
ActionsAutomate any workflowhttps://github.com/features/actions
CodespacesInstant dev environmentshttps://github.com/features/codespaces
IssuesPlan and track workhttps://github.com/features/issues
Code ReviewManage code changeshttps://github.com/features/code-review
GitHub Advanced SecurityFind and fix vulnerabilitieshttps://github.com/security/advanced-security
Code securitySecure your code as you buildhttps://github.com/security/advanced-security/code-security
Secret protectionStop leaks before they starthttps://github.com/security/advanced-security/secret-protection
Why GitHubhttps://github.com/why-github
Documentationhttps://docs.github.com
Bloghttps://github.blog
Changeloghttps://github.blog/changelog
Marketplacehttps://github.com/marketplace
View all featureshttps://github.com/features
Enterpriseshttps://github.com/enterprise
Small and medium teamshttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
App Modernizationhttps://github.com/solutions/use-case/app-modernization
DevSecOpshttps://github.com/solutions/use-case/devsecops
DevOpshttps://github.com/solutions/use-case/devops
CI/CDhttps://github.com/solutions/use-case/ci-cd
View all use caseshttps://github.com/solutions/use-case
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
View all industrieshttps://github.com/solutions/industry
View all solutionshttps://github.com/solutions
AIhttps://github.com/resources/articles?topic=ai
Software Developmenthttps://github.com/resources/articles?topic=software-development
DevOpshttps://github.com/resources/articles?topic=devops
Securityhttps://github.com/resources/articles?topic=security
View all topicshttps://github.com/resources/articles
Customer storieshttps://github.com/customer-stories
Events & webinarshttps://github.com/resources/events
Ebooks & reportshttps://github.com/resources/whitepapers
Business insightshttps://github.com/solutions/executive-insights
GitHub Skillshttps://skills.github.com
Documentationhttps://docs.github.com
Customer supporthttps://support.github.com
Community forumhttps://github.com/orgs/community/discussions
Trust centerhttps://github.com/trust-center
Partnershttps://github.com/partners
View all resourceshttps://github.com/resources
GitHub SponsorsFund open source developershttps://github.com/open-source/sponsors
Security Labhttps://securitylab.github.com
Maintainer Communityhttps://maintainers.github.com
Acceleratorhttps://github.com/open-source/accelerator
GitHub Starshttps://stars.github.com
Archive Programhttps://archiveprogram.github.com
Topicshttps://github.com/topics
Trendinghttps://github.com/trending
Collectionshttps://github.com/collections
Enterprise platformAI-powered developer platformhttps://github.com/enterprise
GitHub Advanced SecurityEnterprise-grade security featureshttps://github.com/security/advanced-security
Copilot for BusinessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Pricinghttps://github.com/pricing
Search syntax tipshttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
documentationhttps://docs.github.com/search-github/github-code-search/understanding-github-code-search-syntax
Sign in https://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fmatplotlib%2Fmatplotlib%2Fpull%2F10001%2Ffiles
Sign up https://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fpull_requests%2Fshow%2Ffiles&source=header-repo&source_repo=matplotlib%2Fmatplotlib
Reloadhttps://github.com/matplotlib/matplotlib/pull/10001/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/10001/files
Reloadhttps://github.com/matplotlib/matplotlib/pull/10001/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
matplotlib https://github.com/matplotlib
matplotlibhttps://github.com/matplotlib/matplotlib
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
Notifications https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Fork 8.4k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Star 23k https://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib
Code https://github.com/matplotlib/matplotlib
Issues 1.1k https://github.com/matplotlib/matplotlib/issues
Pull requests 408 https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality 0 https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Code https://github.com/matplotlib/matplotlib
Issues https://github.com/matplotlib/matplotlib/issues
Pull requests https://github.com/matplotlib/matplotlib/pulls
Actions https://github.com/matplotlib/matplotlib/actions
Projects https://github.com/matplotlib/matplotlib/projects
Wiki https://github.com/matplotlib/matplotlib/wiki
Security and quality https://github.com/matplotlib/matplotlib/security
Insights https://github.com/matplotlib/matplotlib/pulse
Sign up for GitHub https://github.com/signup?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
terms of servicehttps://docs.github.com/terms
privacy statementhttps://docs.github.com/privacy
Sign inhttps://github.com/login?return_to=%2Fmatplotlib%2Fmatplotlib%2Fissues%2Fnew%2Fchoose
jklymakhttps://github.com/jklymak
matplotlib:masterhttps://github.com/matplotlib/matplotlib/tree/master
eric-wieser:more-normalshttps://github.com/eric-wieser/matplotlib/tree/more-normals
Conversation 60 https://github.com/matplotlib/matplotlib/pull/10001
Commits 3 https://github.com/matplotlib/matplotlib/pull/10001/commits
Checks 0 https://github.com/matplotlib/matplotlib/pull/10001/checks
Files changed https://github.com/matplotlib/matplotlib/pull/10001/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
MAINT/BUG: Don't use 5-sided quadrilaterals in Axes3D.plot_surface https://github.com/matplotlib/matplotlib/pull/10001/files#top
Show all changes 3 commits https://github.com/matplotlib/matplotlib/pull/10001/files
98c627d MAINT: Reduce duplication of stride / count calculations eric-wieser Mar 18, 2018 https://github.com/matplotlib/matplotlib/pull/10001/commits/98c627d6633b9a36342c6537bb71582d865f9989
b84c83d MAINT/BUG: Simplify logic in plot_surface eric-wieser Dec 13, 2017 https://github.com/matplotlib/matplotlib/pull/10001/commits/b84c83ddb095ee51adae90e95e05714c696f6e5e
b0d7e4b Merge branch 'master' into more-normals eric-wieser May 12, 2018 https://github.com/matplotlib/matplotlib/pull/10001/commits/b0d7e4b1629f934df086ed7578a29d8c2431f180
Clear filters https://github.com/matplotlib/matplotlib/pull/10001/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
__init__.py https://github.com/matplotlib/matplotlib/pull/10001/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
axes3d.py https://github.com/matplotlib/matplotlib/pull/10001/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
mixedsubplot.pdf https://github.com/matplotlib/matplotlib/pull/10001/files#diff-ba8d83c2da161a6b262fa3f18f47b96f7903c5183a941689d8b29a92ba9f2f6f
mixedsubplot.png https://github.com/matplotlib/matplotlib/pull/10001/files#diff-5df03ddad6963863a81ecff30550c36b20a2e726ecea86a27e28c726defc15ee
mixedsubplot.svg https://github.com/matplotlib/matplotlib/pull/10001/files#diff-e8f69b4e6e71ac4066ffa500b9d43c484c01456b17cd1c670f60c373cd793f75
surface3d.pdf https://github.com/matplotlib/matplotlib/pull/10001/files#diff-704f6341c11788d655835f1451d1c7b3d0283cdb84ad16ca2321cdcaffeecd48
surface3d.png https://github.com/matplotlib/matplotlib/pull/10001/files#diff-9790501c36b9eb385b6648706c2223ab08977f66376839e60cdb383fc8961319
surface3d.svg https://github.com/matplotlib/matplotlib/pull/10001/files#diff-8c6fd7d32a969c8d37e78e4683d88fec29e31952df7b188b32f2f493ad403bd5
surface3d_shaded.png https://github.com/matplotlib/matplotlib/pull/10001/files#diff-21cfe56a20210f3595dd81bca5ea34a333470d773c68627c7b12977249d238e0
test_mplot3d.py https://github.com/matplotlib/matplotlib/pull/10001/files#diff-92e80a964dd888ffff51f54d8acd8189c645c989d947d9819d5c46b213f60ad4
lib/matplotlib/cbook/__init__.pyhttps://github.com/matplotlib/matplotlib/pull/10001/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
View file https://github.com/eric-wieser/matplotlib/blob/b0d7e4b1629f934df086ed7578a29d8c2431f180/lib/matplotlib/cbook/__init__.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/10001/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/10001/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
https://github.com/matplotlib/matplotlib/pull/10001/files#diff-22d7b6f88a379f8ed094611e4034b673df1af718cd74a4b2981a192ff08e446f
lib/mpl_toolkits/mplot3d/axes3d.pyhttps://github.com/matplotlib/matplotlib/pull/10001/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
View file https://github.com/eric-wieser/matplotlib/blob/b0d7e4b1629f934df086ed7578a29d8c2431f180/lib/mpl_toolkits/mplot3d/axes3d.py
Open in desktop https://desktop.github.com
https://github.co/hiddenchars
https://github.com/matplotlib/matplotlib/pull/10001/{{ revealButtonHref }}
https://github.com/matplotlib/matplotlib/pull/10001/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
https://github.com/matplotlib/matplotlib/pull/10001/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
WeatherGodhttps://github.com/WeatherGod
May 13, 2018https://github.com/matplotlib/matplotlib/pull/10001/files#r187785968
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
eric-wieserhttps://github.com/eric-wieser
May 13, 2018https://github.com/matplotlib/matplotlib/pull/10001/files#r187790088
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
WeatherGodhttps://github.com/WeatherGod
May 15, 2018https://github.com/matplotlib/matplotlib/pull/10001/files#r188152429
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
eric-wieserhttps://github.com/eric-wieser
May 15, 2018https://github.com/matplotlib/matplotlib/pull/10001/files#r188152854
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
eric-wieserhttps://github.com/eric-wieser
Sep 16, 2018https://github.com/matplotlib/matplotlib/pull/10001/files#r217929944
Learn morehttps://docs.github.com/articles/managing-disruptive-comments/#hiding-a-comment
#12136https://github.com/matplotlib/matplotlib/pull/12136
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
https://github.com/matplotlib/matplotlib/pull/10001/files#diff-a67656224bfb26dc6de0a0f89e398cd6999377d1482aca3e867ee550ff05be57
lib/mpl_toolkits/tests/baseline_images/test_mplot3d/mixedsubplot.pdfhttps://github.com/matplotlib/matplotlib/pull/10001/files#diff-ba8d83c2da161a6b262fa3f18f47b96f7903c5183a941689d8b29a92ba9f2f6f
View file https://github.com/eric-wieser/matplotlib/blob/b0d7e4b1629f934df086ed7578a29d8c2431f180/lib/mpl_toolkits/tests/baseline_images/test_mplot3d/mixedsubplot.pdf
Open in desktop https://desktop.github.com
lib/mpl_toolkits/tests/baseline_images/test_mplot3d/mixedsubplot.pnghttps://github.com/matplotlib/matplotlib/pull/10001/files#diff-5df03ddad6963863a81ecff30550c36b20a2e726ecea86a27e28c726defc15ee
View file https://github.com/eric-wieser/matplotlib/blob/b0d7e4b1629f934df086ed7578a29d8c2431f180/lib/mpl_toolkits/tests/baseline_images/test_mplot3d/mixedsubplot.png
Open in desktop https://desktop.github.com
Reload?https://github.com/matplotlib/matplotlib/pull/10001/files
Please reload this pagehttps://github.com/matplotlib/matplotlib/pull/10001/files
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width

URLs of crawlers that visited me.