René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[MNT]: Remove macOS 10.12 compatibility from ft2font_wrapper","articleBody":"### Summary\n\nThere are several comments in ft2font_wrapper.cpp related to macOS 10.12 compatibility:\n\n```c++\nFT2Font::LanguageType languages;\nif (auto value = std::get_if\u003cFT2Font::LanguageType\u003e(\u0026languages_or_str)) {\n    languages = std::move(*value);\n} else if (auto value = std::get_if\u003cstd::string\u003e(\u0026languages_or_str)) {\n    languages = std::vector\u003cFT2Font::LanguageRange\u003e{\n        FT2Font::LanguageRange{*value, 0, text.size()}\n    };\n} else {\n    // NOTE: this can never happen as pybind11 would have checked the type in the\n    // Python wrapper before calling this function, but we need to keep the\n    // std::get_if instead of std::get for macOS 10.12 compatibility.\n    throw py::type_error(\"languages must be str or list of tuple\");\n}\n```\n\nSince the ARC changes in PR #31855 requires macOS 10.14 or later, I believe that the above logic can be simplified.\n\nMy knowledge of the C++ std is very limited, Claude suggests using `std::holds_alternative`:\n\n```c++\nFT2Font::LanguageType languages;\nif (std::holds_alternative\u003cFT2Font::LanguageType\u003e(languages_or_str)) {\n    languages = std::move(std::get\u003cFT2Font::LanguageType\u003e(languages_or_str));\n} else {\n    languages = std::vector\u003cFT2Font::LanguageRange\u003e{\n        FT2Font::LanguageRange{std::get\u003cstd::string\u003e(languages_or_str), 0, text.size()}\n    };\n}\n```\n\nI'm happy to do this cleanup and submit a PR if someone with C++ knowledge can give guidance!\n\n\n### Proposed fix\n\n_No response_","author":{"url":"https://github.com/iccir","@type":"Person","name":"iccir"},"datePublished":"2026-06-27T16:37:53.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":0},"url":"https://github.com/31963/matplotlib/issues/31963"}