René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[Bug]: triage_tests.py is brittle against failures in test modules that have only check_figures_equal test","articleBody":"### Bug summary\n\nIf a check_figures_equal test fails in test_pickle.py (which has no baseline image tests at all), then running triage_tests.py fails with \"ValueError: Can't find baseline dir for test_pickle\".\n\n### Code for reproduction\n\n```Python\nMake test_pickle::test_complete fail, e.g. by commenting out the `fig_test.figimage(loaded.canvas.renderer.buffer_rgba())` line; run that test (which should fail), and run tools/triage_tests.py.\n```\n\n### Actual outcome\n\nValueError: Can't find baseline dir for test_pickle\n\n### Expected outcome\n\nThe test triager succeeds.\n\n### Additional information\n\nFixing involves either creating an empty test_pickle directory in the baseline_images directory, or allowing missing directories in triage_tests (which already interprets missing *baselines* as arising from check_figures_equal tests):\n```patch\ndiff --git i/tools/triage_tests.py w/tools/triage_tests.py\nindex 5153b1c712..6df720f29d 100644\n--- i/tools/triage_tests.py\n+++ w/tools/triage_tests.py\n@@ -263,7 +263,7 @@ class Entry:\n             ]\n         self.thumbnails = [self.dir / x for x in self.thumbnails]\n\n-        if not Path(self.destdir, self.generated).exists():\n+        if self.destdir is None or not Path(self.destdir, self.generated).exists():\n             # This case arises from a check_figures_equal test.\n             self.status = 'autogen'\n         elif ((self.dir / self.generated).read_bytes()\n@@ -281,7 +281,6 @@ class Entry:\n             path = self.source / baseline_dir / reldir\n             if path.is_dir():\n                 return path\n-        raise ValueError(f\"Can't find baseline dir for {reldir}\")\n\n     @property\n     def display(self):\n```\n\nOpening as an issue because I don't really mind about which solution to pick, so I'll let whoever cares pick one.\n\n### Operating system\n\n_No response_\n\n### Matplotlib Version\n\n3.11.0.dev525+g9f7b3dd205\n\n### Matplotlib Backend\n\n_No response_\n\n### Python version\n\n3.13\n\n### Jupyter version\n\n_No response_\n\n### Installation\n\ngit checkout","author":{"url":"https://github.com/anntzer","@type":"Person","name":"anntzer"},"datePublished":"2025-03-18T23:17:10.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/29774/matplotlib/issues/29774"}