Title: [MNT]: deprecate auto hatch fallback to patch.edgecolor when edgecolor='None' · Issue #29380 · matplotlib/matplotlib · GitHub
Open Graph Title: [MNT]: deprecate auto hatch fallback to patch.edgecolor when edgecolor='None' · Issue #29380 · matplotlib/matplotlib
X Title: [MNT]: deprecate auto hatch fallback to patch.edgecolor when edgecolor='None' · Issue #29380 · matplotlib/matplotlib
Description: Summary Since #28104 now separates out hatchcolor, users should not be allowed to specifically ask to fallback to edgecolor and also explicitly set that edgecolor to none because silently falling back on edgecolor="None" introduces the p...
Open Graph Description: Summary Since #28104 now separates out hatchcolor, users should not be allowed to specifically ask to fallback to edgecolor and also explicitly set that edgecolor to none because silently falling b...
X Description: Summary Since #28104 now separates out hatchcolor, users should not be allowed to specifically ask to fallback to edgecolor and also explicitly set that edgecolor to none because silently falling b...
Opengraph URL: https://github.com/matplotlib/matplotlib/issues/29380
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[MNT]: deprecate auto hatch fallback to patch.edgecolor when edgecolor='None'","articleBody":"### Summary\r\n\r\nSince #28104 now separates out hatchcolor, users should not be allowed to specifically ask to fallback to edgecolor and also explicitly set that edgecolor to none because silently falling back on ```edgecolor=\"None\"``` introduces the problem that:\r\n\r\n1. because of eager color resolution and frequently setting \"none\" by knocking out the alpha, the way to check for none is checking the alpha, which leads to fallback being dependent on the interplay between alpha and edgecolor:\r\n\r\n\r\n3. fallback to edgecolor rcParams doesn't check if the rcParam is also none so could sink the problem a layer deeper\r\n\r\n\r\n\r\n### Proposed fix\r\n\r\nDeprecate this fallback behavior and raise a warning on \r\n\r\n``` Rectangle( (0,0), .5, .5, hatchcolor='edge', edgecolor='None')```\r\n\r\nThe alternatives are:\r\n* set a hatchcolor \r\n* don't set edgecolor at all, .i.e. ``` Rectangle( (0,0), .5, .5, hatchcolor='edge')``` falls back to the rcParam in `get_edgecolor`","author":{"url":"https://github.com/story645","@type":"Person","name":"story645"},"datePublished":"2024-12-25T00:19:58.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":2},"url":"https://github.com/29380/matplotlib/issues/29380"}
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:59daa619-b479-ce6d-4017-3f037e7c9538 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | E03A:C92EC:1D3D41:2795B8:6A5255C8 |
| html-safe-nonce | 471906a01f2d8e80a0ed9b333f738c0d3473040ef4801d7fda41ddeda8225de6 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFMDNBOkM5MkVDOjFEM0Q0MToyNzk1Qjg6NkE1MjU1QzgiLCJ2aXNpdG9yX2lkIjoiNjM1Njc3NzY4Njk0MjI0MjI0OCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8f059b2644b053f2890feeeaa7fcf462b0be3d655dd2e6bf224e129674c6952a |
| hovercard-subject-tag | issue:2758369847 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/matplotlib/matplotlib/29380/issue_layout |
| twitter:image | https://opengraph.githubassets.com/1c1b7c90304c18f5a4a8e964c51a590995b88231bb7540e5735bb10db072be5e/matplotlib/matplotlib/issues/29380 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/1c1b7c90304c18f5a4a8e964c51a590995b88231bb7540e5735bb10db072be5e/matplotlib/matplotlib/issues/29380 |
| og:image:alt | Summary Since #28104 now separates out hatchcolor, users should not be allowed to specifically ask to fallback to edgecolor and also explicitly set that edgecolor to none because silently falling b... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | story645 |
| hostname | github.com |
| expected-hostname | github.com |
| None | b9a586c06a05a7a86fc7e3f4dbd03e42f6869085879aa184aa6369456dbd50fb |
| turbo-cache-control | no-preview |
| go-import | github.com/matplotlib/matplotlib git https://github.com/matplotlib/matplotlib.git |
| octolytics-dimension-user_id | 215947 |
| octolytics-dimension-user_login | matplotlib |
| octolytics-dimension-repository_id | 1385122 |
| octolytics-dimension-repository_nwo | matplotlib/matplotlib |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 1385122 |
| octolytics-dimension-repository_network_root_nwo | matplotlib/matplotlib |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 7aed05249554b889eb33d002851a973eebcc7e91 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
Links:
Viewport: width=device-width